Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2692894lqp; Mon, 25 Mar 2024 06:52:33 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUV2CtjULhmTK77bOLx0nhzG6RgTHdajynCGff1CP0EyVB53Enhbay8CxlNQuNV2RBNIX1jHrT62mVHZ5YkircWTjOMVnvjkehDp+Imkw== X-Google-Smtp-Source: AGHT+IE/D0TIh+575mRYG31rZ+8GHq+ogEOBPDB/PukLmQIQKPsuk6FRjNJPFacJ83mJzmG2XUDF X-Received: by 2002:a17:902:f551:b0:1e0:b871:53f5 with SMTP id h17-20020a170902f55100b001e0b87153f5mr4412469plf.20.1711374752795; Mon, 25 Mar 2024 06:52:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711374751; cv=pass; d=google.com; s=arc-20160816; b=W7lVOfRFlB7EUcSmHaoHekQS94tvXxEtyySw5HrjuLED6CLkmOHMlstOB4XoCiGgc4 Wq3Nc1DxJBN+KG11Nf2swtAnxXxYBpCUBD6myTMbWtS10zmR6BVwEsVXPEtbG/IpuLkH TLAw0JC7qhNVkXmKSxYA2MJPxW/Funb/pXFJdANHI1DGe9KxmGmc5s816JxBsUKyqOGQ auWspMTVgoZkL5KZLpKS3iAoAkOrHCVEgOF7hbh9KflP+te++OapvrEPVviBrAlRFtRN vNP6ASBZNS1o5BUgQv+UZYqfJCOPWUXh05zOhNimFP+KM7PwVb5097/iPLTr68HMGDOD zMkA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=HtPFwm5y4yZ/EGt/JRMMm+28Wg15G7xjM5Kv8R/kl/0=; fh=+GJMzaEGep8RIn2eZPbWgYulq/9/FNoX9r/JO7oLxtk=; b=heaY4sqbGicuYfyHcODKU4GUK6+1i/Gepu0axTErHwERIjL1uaSCawpVYnvqYUEC3R Td8vghe7i9t+l32GsSW2luJ+CYGKKog5N3Pcbv9irWhGaMAHSepAx5QAenDfAg69xeKX tiEi5lpZxYVK/Gxz1XHEZS+ssXjH2RX/mpdTEe+1qWfEVYMF1yE4c+iBDDX3+U35TsIr MjktltfxJrrrMZgMySa0QqMTCKNmTF77j3iujHs+F6JhlJJ/gEGXWwJd6MYFfGbAltyT bQjd+ZTV95FkaYZrcNxxtVBcIN4f+gsKmw01DpwDq8Z6/4QOkbNPB6wwLHddghApgHzI yYRQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=nfschina.com); spf=pass (google.com: domain of linux-kernel+bounces-116649-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-116649-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id x23-20020a1709027c1700b001defa2d8e0bsi5186471pll.414.2024.03.25.06.52.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 06:52:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-116649-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=nfschina.com); spf=pass (google.com: domain of linux-kernel+bounces-116649-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-116649-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id E1C09BC3682 for ; Mon, 25 Mar 2024 13:29:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9CBE813473B; Mon, 25 Mar 2024 10:20:35 +0000 (UTC) Received: from mail.nfschina.com (unknown [42.101.60.195]) by smtp.subspace.kernel.org (Postfix) with SMTP id 394D8127B7F; Mon, 25 Mar 2024 07:36:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=42.101.60.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711352180; cv=none; b=MSeNy+YRIAwhcQpJc0GHCvLDbFdwnckz/mHKhraZ55HGxoX8FYIMXS8G6SbPdxRtw/AIxOAzhYGxeJu4KYCTAZXg2lp4ruVuSO6X57J7/yB824VRvqV/dzYe0O9GY7G1dU61/EmsEJspcuBKt5bGXSbr3GO684bg0tQxcZJ5g6E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711352180; c=relaxed/simple; bh=LZaq53O1GNO3two+ZlL0W1CK0F15y8eavHKu0/CkY/g=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=TvaUMllQBw8oSCB3jsXU5XkUqz3NvtVeNc+9lTP0t+zytCR+jZh/h1BxHK27q2C9c7pYyFu0bv0IHat/gOsIw1J0p5cmSPhFWGEf03mHK3m34qvnoHz/PEd40x7PEko+q7TTZYMrA/lrhIIIbB+eFTQT3olJdg4o2jG3wuEcg/Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nfschina.com; spf=pass smtp.mailfrom=nfschina.com; arc=none smtp.client-ip=42.101.60.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nfschina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nfschina.com Received: from localhost.localdomain (unknown [180.167.10.98]) by mail.nfschina.com (Maildata Gateway V2.8.8) with ESMTPSA id 5067F602E36D9; Mon, 25 Mar 2024 15:36:04 +0800 (CST) X-MD-Sfrom: suhui@nfschina.com X-MD-SrcIP: 180.167.10.98 From: Su Hui To: sgoutham@marvell.com, gakula@marvell.com, sbhatta@marvell.com, hkelam@marvell.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: Su Hui , saikrishnag@marvell.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH 1/2] octeontx2-pf: check negative error code in otx2_open() Date: Mon, 25 Mar 2024 15:35:49 +0800 Message-Id: <20240325073549.823832-1-suhui@nfschina.com> X-Mailer: git-send-email 2.30.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit otx2_rxtx_enable() return negative error code such as -EIO, check -EIO rather than EIO to fix this problem. Fixes: c926252205c4 ("octeontx2-pf: Disable packet I/O for graceful exit") Signed-off-by: Su Hui --- drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c index b40bd0e46751..3f46d5e0fb2e 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c @@ -1933,7 +1933,7 @@ int otx2_open(struct net_device *netdev) * mcam entries are enabled to receive the packets. Hence disable the * packet I/O. */ - if (err == EIO) + if (err == -EIO) goto err_disable_rxtx; else if (err) goto err_tx_stop_queues; -- 2.30.2