Received-SPF: pass (google.com: domain of linux-kernel+bounces-116737-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 25 Mar 2024 10:09:16 +0100
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Alexander Dahl <ada@thorsis.com>
Cc: linux-mtd@lists.infradead.org, Richard Weinberger <richard@nod.at>,
 Vignesh Raghavendra <vigneshr@ti.com>, linux-kernel@vger.kernel.org
Subject: Re: mtd: nand: raw: Possible bug in nand_onfi_detect()?
Message-ID: <20240325100917.502c75b7@xps-13>
In-Reply-To: <20240307181931.440c9c3f@xps-13>
References: <20240306-shaky-bunion-d28b65ea97d7@thorsis.com>
	<20240306164831.29eed907@xps-13>
	<20240307-pantry-deceit-78ce20f47899@thorsis.com>
	<20240307181931.440c9c3f@xps-13>
Organization: Bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hello Alexander,

> > > > The condition is true and nand_change_read_column_op() returns with
> > > > -EINVAL, because mtd->writesize and mtd->oobsize are not set yet in
> > > > that code path.  Those are probably initialized later, maybe with
> > > > parameters read from that ONFI param page?
> > > >=20
> > > > Returning with error from nand_change_read_column_op() leads to
> > > > jumping out of nand_onfi_detect() early, and no ONFI param page is
> > > > evaluated at all, although the second or third page could be intact.
> > > >=20
> > > > I guess this would also fail with any other reason for not matching
> > > > CRCs in the first page, but I have not faulty NAND flash chip to
> > > > confirm that.   =20
> > >=20
> > > Thanks for the whole report, it is interesting and should lead to fix=
es:
> > > - why does the controller refuses the datain op?   =20
> >=20
> > See above.
> >  =20
> > > - why nand_soft_waitrdy is not enough?   =20
> >=20
> > I don't know.  That's one reason I asked here.
> >  =20
> > > - changing the condition in nand_change_read_column_op()
> > >=20
> > > Can you take care of these?   =20

Now would be a perfect time to send these fixes. Could you work on them?

Thanks!
Miqu=C3=A8l