Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2741240lqp; Mon, 25 Mar 2024 08:03:21 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVB6Vr1a83qG6xgg1X3M9b+UBLFoXuS4Mb4BqgjFspZcRATOoOMiCDksM+Isrkp+ELHNy3vHS8Z+ECmZ+kJxJUNIoWWO4rCdz74FizdcQ== X-Google-Smtp-Source: AGHT+IEo9ZLmiK3Ig4tyl3t20v7ZLg5xFSCIbVJUqWR/3ICU6xyDJuxYDyFszeMjH1EaOAOlitdS X-Received: by 2002:a17:902:7795:b0:1dd:73ba:cd7f with SMTP id o21-20020a170902779500b001dd73bacd7fmr6598158pll.47.1711379001513; Mon, 25 Mar 2024 08:03:21 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711379001; cv=pass; d=google.com; s=arc-20160816; b=jwnxD8GLRXbQQs8JWWBjVOPKmI2i1sth0vs+XfGL5i7aEq+ucjrUDXT0QyfYznHcda ZT0MA7sKAQHwmdXXoSdLn0MYowsS+qsf3FU7lZ4MFFXca3l/LaRUgoBPtHEzfg6AX6Cm SKA3h7qhZpYBhSo3eH0kWvebVZZLUbUunRUKvu1OxhtyjJg4zJvzT3qMGvf7Zlv8/08p b3DDbX7qFTEfUg1OJWpvLyk1E7vyRoKZwGTPf/rcMGGqyx6/fe+NnUwBKyHoz6u7sb7Q 7jVbpOTHJCcdw0zTEsmFc1b2nuR2FvePwwATMJo/ZrIdBGldVzdjMPn36S6SjguCx1dw hTbg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:precedence:robot-unsubscribe:robot-id :message-id:mime-version:list-unsubscribe:list-subscribe:list-id :precedence:references:in-reply-to:cc:subject:to:reply-to:sender :from:dkim-signature:dkim-signature:date; bh=b0foAp6Jh3HG07zsbyZU5KG4EcvhR89BySV+yv087Pc=; fh=wXm8X1UpePYZ16S7bpAo6tEDlCg/OcCBwnyYmXYC6HQ=; b=U8d59RazfLUtygwq/KMZ/e5N0rXVlungJFCnvu17IBwgd7xZwArFR2YlzAIl3flwwW FrUvntx7i8/F0fxLNQ+MI1EhK1BEBb6cJicZ9lww2KMf9GJ89SMF+RRtJKhbhw/VidXl DorE087wnQowMFpaQXjZive7aS6j7rskdrzZbKVRNc2iWijmZD/FQbipDfEAutKgz+ZL MJS31W8D4Ftv4DSJhAzpkfdDxfKj9m26CWlkqnwaHHD2ZA9gvrwKXEBRITO6YnBZAvNR 1tsdlsKAmOnPsebTSnog2XDPWebA8nNelHQ3Y/B32RqhO/6F93FTXK5kw3+Clmjn0MAW GF9Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=aGIjHI5p; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-116937-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-116937-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id o5-20020a170902d4c500b001e023358f7csi5389617plg.363.2024.03.25.08.03.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 08:03:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-116937-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=aGIjHI5p; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-116937-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-116937-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 968BD2E0A6D for ; Mon, 25 Mar 2024 14:54:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3A9FA183BBB; Mon, 25 Mar 2024 11:53:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="aGIjHI5p"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="+249sJcc" Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BD771B676C; Mon, 25 Mar 2024 11:28:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711366102; cv=none; b=ZpP8XESxTGoJbqdggqkLY3HRwZsHZkCcXAoHqAk8x2K0sjTLknazAgmt6AjJAK1ZF2KnoW6aTIvzkkYvIhdsKijRQaFili+MLYkuVRQjHjcKjxoCLCsUoc34HghTZMa2Ac6PoAoNnccRu4geKK1z3IsEVZXyA3bwNnbFZcDWPnw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711366102; c=relaxed/simple; bh=KNDp3jRDFDklfJlUKQQts+H70dIwd0ih7z/WwhczkXg=; h=Date:From:To:Subject:Cc:In-Reply-To:References:MIME-Version: Message-ID:Content-Type; b=K5P2ozS8sPFhzD7aqSbKbfSuVxsVef6BTOjbvtsiuWKodI9KhRW3NXQveqsoFIiqDBW4K2Ft5GVg2/lLq7esGEJ9nmQKjsvfiPTPOVDpyxxouCfNKgh4mGhhGnS4Xb8SdUgMgUlvAyvJCoUnvVH/ZL0+QC6QOv/wKXXcx9SJyJM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=aGIjHI5p; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=+249sJcc; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Date: Mon, 25 Mar 2024 11:28:18 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1711366099; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b0foAp6Jh3HG07zsbyZU5KG4EcvhR89BySV+yv087Pc=; b=aGIjHI5p1MDcpzC9ZS30bWhZjhSFeIfCaVMDygBPVIbE6vHiuaDM3qMFO2nClQh8u3nIIc fRpIs/wvTjCeMjboNJ57bBw8APER1GnqLX9LW8/hLgV9Fp3yMqGIYoHLOvjdiaOOvYWjga fKOX5OCAaU64UlZr0MbBz/x40MKjcIp3xEDdvpR/4AoaGUfQ+7u0oUTXQfKwI0mGMTDtCm ng4PXZRK5rRF084v8h5IUouJRNZmDFlJqyEPHEQWgXmkJ7/tbtduSwulPRSLPc/v76CevG ptIQwxVdsYYqmt/KfEHR/QnEjZQe5jOE81Atzzjzo8fYpMXsUhgHHoVsJHF9Lw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1711366099; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b0foAp6Jh3HG07zsbyZU5KG4EcvhR89BySV+yv087Pc=; b=+249sJccnOPbWT7s8XbRfWrYvpV2a33ZzCMe2xC0DcCqjlOJ8ygi58E0Ij38ef/4Tvo8W4 2Y0zWaWanK1TpXDA== From: "tip-bot2 for Qais Yousef" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: sched/core] sched/topology: Remove root_domain::max_cpu_capacity Cc: Qais Yousef , Ingo Molnar , Vincent Guittot , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20240324004552.999936-4-qyousef@layalina.io> References: <20240324004552.999936-4-qyousef@layalina.io> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <171136609892.10875.3581762872501656625.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Precedence: bulk Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit The following commit has been merged into the sched/core branch of tip: Commit-ID: fa427e8e53d8db15090af7e952a55870dc2a453f Gitweb: https://git.kernel.org/tip/fa427e8e53d8db15090af7e952a55870dc2a453f Author: Qais Yousef AuthorDate: Sun, 24 Mar 2024 00:45:51 Committer: Ingo Molnar CommitterDate: Mon, 25 Mar 2024 12:09:56 +01:00 sched/topology: Remove root_domain::max_cpu_capacity The value is no longer used as we now keep track of max_allowed_capacity for each task instead. Signed-off-by: Qais Yousef Signed-off-by: Ingo Molnar Reviewed-by: Vincent Guittot Link: https://lore.kernel.org/r/20240324004552.999936-4-qyousef@layalina.io --- kernel/sched/sched.h | 2 -- kernel/sched/topology.c | 13 ++----------- 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index f77c00d..4f9e952 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -917,8 +917,6 @@ struct root_domain { cpumask_var_t rto_mask; struct cpupri cpupri; - unsigned long max_cpu_capacity; - /* * NULL-terminated list of performance domains intersecting with the * CPUs of the rd. Protected by RCU. diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 44ed3d0..63aecd2 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -2514,16 +2514,9 @@ build_sched_domains(const struct cpumask *cpu_map, struct sched_domain_attr *att /* Attach the domains */ rcu_read_lock(); for_each_cpu(i, cpu_map) { - unsigned long capacity; - rq = cpu_rq(i); sd = *per_cpu_ptr(d.sd, i); - capacity = arch_scale_cpu_capacity(i); - /* Use READ_ONCE()/WRITE_ONCE() to avoid load/store tearing: */ - if (capacity > READ_ONCE(d.rd->max_cpu_capacity)) - WRITE_ONCE(d.rd->max_cpu_capacity, capacity); - cpu_attach_domain(sd, d.rd, i); if (lowest_flag_domain(i, SD_CLUSTER)) @@ -2537,10 +2530,8 @@ build_sched_domains(const struct cpumask *cpu_map, struct sched_domain_attr *att if (has_cluster) static_branch_inc_cpuslocked(&sched_cluster_active); - if (rq && sched_debug_verbose) { - pr_info("root domain span: %*pbl (max cpu_capacity = %lu)\n", - cpumask_pr_args(cpu_map), rq->rd->max_cpu_capacity); - } + if (rq && sched_debug_verbose) + pr_info("root domain span: %*pbl\n", cpumask_pr_args(cpu_map)); ret = 0; error: