Received-SPF: pass (google.com: domain of linux-kernel+bounces-116980-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 25 Mar 2024 14:13:39 +0200
From: Andy Shevchenko <andy@black.fi.intel.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: David Ober <dober6023@gmail.com>, linux-hwmon@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	jdelvare@suse.com, corbet@lwn.net, dober@lenovo.com,
	mpearson@lenovo.com
Subject: Re: [PATCH v4] hwmon:Add EC Chip driver for Lenovo ThinkStation
 motherboards
Message-ID: <ZgFqc5Lz3P8BfPw7@black.fi.intel.com>
References: <20240315115810.15816-1-dober6023@gmail.com>
 <f748574c-93cf-48ec-8e88-44d5b35fb107@roeck-us.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f748574c-93cf-48ec-8e88-44d5b35fb107@roeck-us.net>

On Wed, Mar 20, 2024 at 10:59:34AM -0700, Guenter Roeck wrote:
> On Fri, Mar 15, 2024 at 07:58:10AM -0400, David Ober wrote:
> > This addition adds in the ability for the system to scan
> > the EC chip in the Lenovo ThinkStation systems to get the
> > current fan RPM speeds the Maximum speed value for each
> > fan also provides the CPU, DIMM other thermal statuses
> > 
> > Signed-off-by: David Ober <dober@lenovo.com>
> > Signed-off-by: David Ober <dober6023@gmail.com>
> 
> Applied to hwmon-next.
> 
> Please note that I'll push the branch after the commit window closed.

Hmm... Was it even compiled?

lenovo-ec-sensors.c:154:31: error: expected '}'
static int p8_fan_map[] = {0. 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 14};
                              ^
lenovo-ec-sensors.c:154:27: note: to match this '{'
static int p8_fan_map[] = {0. 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 14};
                          ^

-- 
With Best Regards,
Andy Shevchenko