Received-SPF: pass (google.com: domain of linux-kernel+bounces-117001-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <a9a84b30-838f-41e6-8faf-b3508d1ba263@gmail.com>
Date: Mon, 25 Mar 2024 20:30:48 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 05/14] mm/ksm: use folio in stable_node_dup
Content-Language: en-US
To: Matthew Wilcox <willy@infradead.org>, alexs@kernel.org
Cc: Andrea Arcangeli <aarcange@redhat.com>,
 Izik Eidus <izik.eidus@ravellosystems.com>, david@redhat.com,
 Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org, Hugh Dickins <hughd@google.com>,
 Chris Wright <chrisw@sous-sol.org>
References: <20240322083703.232364-1-alexs@kernel.org>
 <20240322083703.232364-6-alexs@kernel.org>
 <Zf2qcH-bDEgLAP7d@casper.infradead.org>
From: Alex Shi <seakeel@gmail.com>
In-Reply-To: <Zf2qcH-bDEgLAP7d@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 3/22/24 11:57 PM, Matthew Wilcox wrote:
> On Fri, Mar 22, 2024 at 04:36:52PM +0800, alexs@kernel.org wrote:
>> -static struct page *stable_node_dup(struct ksm_stable_node **_stable_node_dup,
>> -				    struct ksm_stable_node **_stable_node,
>> -				    struct rb_root *root,
>> -				    bool prune_stale_stable_nodes)
>> +static void *stable_node_dup(struct ksm_stable_node **_stable_node_dup,
>> +			     struct ksm_stable_node **_stable_node,
>> +			     struct rb_root *root,
>> +			     bool prune_stale_stable_nodes)
> 
> Do we really have to go through this void * stage?

Hi Willy,
Thank a lot for reminder. Yes, we could keep the 'struct page*' return value here.
And so we don't need to change indent here.

Thanks!

> 
> Also, please stop reindenting the arguments.  I tend to just switch to
> two tabs, but lining them up with the opening bracket leads to extra
> churn.  Either leave them alone for the entire series or switch _once_.
>