Received-SPF: pass (google.com: domain of linux-kernel+bounces-117075-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Emilio Mendoza Reyes <emendoz@g.clemson.edu>
To: neil.armstrong@linaro.org, dianders@chromium.org,
 linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Jani Nikula <jani.nikula@linux.intel.com>
Subject:
 Re: [PATCH 2/2] drm/panel: Promote warn_dev to WARN for invalid calls in
 drm_panel.c
Date: Mon, 25 Mar 2024 08:46:16 -0400
Message-ID: <4878769.GXAFRqVoOG@mephi-laptop>
In-Reply-To: <87jzlqk5xr.fsf@intel.com>
References: <2388112.ElGaqSPkdT@mephi-laptop> <87jzlqk5xr.fsf@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart1881631.tdWV9SEqCh";
 micalg="pgp-sha512"; protocol="application/pgp-signature"

--nextPart1881631.tdWV9SEqCh
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"; protected-headers="v1"
From: Emilio Mendoza Reyes <emendoz@g.clemson.edu>
Date: Mon, 25 Mar 2024 08:46:16 -0400
Message-ID: <4878769.GXAFRqVoOG@mephi-laptop>
In-Reply-To: <87jzlqk5xr.fsf@intel.com>
MIME-Version: 1.0

On Monday, March 25, 2024 5:37:52=E2=80=AFAM EDT Jani Nikula wrote:
> Please use git format-patch and/or send-email to send patches, without
> the inline PGP.
Yeah, sorry about that. I only noticed it was inline PGP after I sent the
patches. I didn't know if it would be okay to resend right after since I
didn't want to email spam. Sorry!

> Please use dev_WARN() which will handle the device specific warns for
> you, including dev_name().
Alright I changed my patch to use dev_WARN. The new version is at the
end of this email. Thank you for your time. Let me know if I there is
anything else to change.

Thanks,
EMR


Subject: [PATCH] drm/panel: Promote warn_dev to dev_WARN for invalid calls =
in
 drm_panel.c

Partially solve todo in kernel doc by promoting dev_warn calls to
dev_WARN.
Link: https://www.kernel.org/doc/html/v6.8/gpu/todo.html#clean-up-checks-fo=
r-already-prepared-enabled-in-panels

Signed-off-by: Emilio Mendoza Reyes <emendoz@clemson.edu>
=2D--
 drivers/gpu/drm/drm_panel.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c
index cfbe020de54e..4459f4f5fe66 100644
=2D-- a/drivers/gpu/drm/drm_panel.c
+++ b/drivers/gpu/drm/drm_panel.c
@@ -114,7 +114,7 @@ int drm_panel_prepare(struct drm_panel *panel)
 		return -EINVAL;
=20
 	if (panel->prepared) {
=2D		dev_warn(panel->dev, "Skipping prepare of already prepared panel\n");
+		dev_WARN(panel->dev, "Unexpected attempt to prepare an already prepared =
panel\n");
 		return 0;
 	}
=20
@@ -162,7 +162,7 @@ int drm_panel_unprepare(struct drm_panel *panel)
 		return -EINVAL;
=20
 	if (!panel->prepared) {
=2D		dev_warn(panel->dev, "Skipping unprepare of already unprepared panel\n=
");
+		dev_WARN(panel->dev, "Unexpected attempt to unprepare an already unprepa=
red panel\n");
 		return 0;
 	}
=20
@@ -208,7 +208,7 @@ int drm_panel_enable(struct drm_panel *panel)
 		return -EINVAL;
=20
 	if (panel->enabled) {
=2D		dev_warn(panel->dev, "Skipping enable of already enabled panel\n");
+		dev_WARN(panel->dev, "Unexpected attempt to enable an already enabled pa=
nel\n");
 		return 0;
 	}
=20
@@ -246,7 +246,7 @@ int drm_panel_disable(struct drm_panel *panel)
 		return -EINVAL;
=20
 	if (!panel->enabled) {
=2D		dev_warn(panel->dev, "Skipping disable of already disabled panel\n");
+		dev_WARN(panel->dev, "Unexpected attempt to disable an already disabled =
panel\n");
 		return 0;
 	}
=20
=2D-=20
2.44.0


--nextPart1881631.tdWV9SEqCh
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTcaZbABwnECYA0cZI0LAN3EqikFgUCZgFyGAAKCRA0LAN3Eqik
FpFuAP4/1QuAz/TJZuulntE7Vh0B9fC++3b8IMjZjxBRd369WwEAxeqpvHwRFFmN
3W4H7asKnWDJeQl2nAz8RswSfucKgg4=
=Lpy8
-----END PGP SIGNATURE-----

--nextPart1881631.tdWV9SEqCh--