Received-SPF: pass (google.com: domain of linux-kernel+bounces-117086-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <2625bf93-1501-4e5d-b492-de9bcffa93ec@collabora.com>
Date: Mon, 25 Mar 2024 14:06:31 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 0/2] soc: mediatek: pm-domains: solve power domain glitch
 issue
To: "yu-chang.lee" <yu-chang.lee@mediatek.com>,
 Ulf Hansson <ulf.hansson@linaro.org>,
 Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org,
 Project_Global_Chrome_Upstream_Group@mediatek.com, mandyjh.liu@mediatek.com,
 fan.chen@mediatek.com, xiufeng.li@mediatek.com
References: <20240325121908.3958-1-yu-chang.lee@mediatek.com>
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Content-Language: en-US
In-Reply-To: <20240325121908.3958-1-yu-chang.lee@mediatek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Il 25/03/24 13:19, yu-chang.lee ha scritto:
> Hi,
> 
> This series aims to solve power-off failures and occasional SMI hang issues that
> occur during camera stress tests. The issue arises because, when MTCMOS powers on
> or off, signal glitches are sometimes produced. This is fairly normal, but the
> software must address it to avoid mistaking the glitch for a transaction signal.
> 
> The solutions in these patches can be summarized as follows:
> 
> 1. Disable the sub-common port after turning off the Larb CG and before turning
>     off the Larb MTCMOS.
> 2. Use CLAMP to disable/enable the SMI common port.
> 3. Implement an AXI reset.
> For previous discussion on the direction of the code modifications, please refer
> to: https://lore.kernel.org/linux-arm-kernel/c476cc48-17ec-4e14-98d8-35bdffb5d296@collabora.com/
> 
> 
> yu-chang.lee (2):
>    soc: mediatek: pm-domains: add smi_larb_reset function when power on
>    soc: mediatek: pm-domains: support smi clamp protection

Can you please change both commit titles to use "pmdomain: mediatek:" instead of
"soc: mediatek:"?

Thanks
Angelo

> 
>   drivers/pmdomain/mediatek/mt8188-pm-domains.h |  69 +++++-
>   drivers/pmdomain/mediatek/mtk-pm-domains.c    | 206 +++++++++++++++---
>   drivers/pmdomain/mediatek/mtk-pm-domains.h    |  13 ++
>   3 files changed, 255 insertions(+), 33 deletions(-)
>