Received-SPF: pass (google.com: domain of linux-kernel+bounces-117144-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 25 Mar 2024 08:26:15 -0500
From: Rob Herring <robh@kernel.org>
To: INAGAKI Hiroshi <musashino.open@gmail.com>
Cc: lee@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	devicetree@vger.kernel.org, Hauke Mehrtens <hauke@hauke-m.de>,
	pavel@ucw.cz, conor+dt@kernel.org, linux-kernel@vger.kernel.org,
	linux-leds@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for
 mobile network
Message-ID: <171137317301.3201816.3242642839812091788.robh@kernel.org>
References: <20240323074326.1428-1-musashino.open@gmail.com>
 <20240323074326.1428-2-musashino.open@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240323074326.1428-2-musashino.open@gmail.com>


On Sat, 23 Mar 2024 16:36:09 +0900, INAGAKI Hiroshi wrote:
> Add LED_FUNCTION_MOBILE for LEDs that indicate status of mobile network
> connection. This is useful to distinguish those LEDs from LEDs that
> indicates status of wired "wan" connection.
> 
> example (on stock fw):
> 
> IIJ SA-W2 has "Mobile" LEDs that indicate status (no signal, too low,
> low, good) of mobile network connection via dongle connected to USB
> port.
> 
> - no signal: (none, turned off)
> -   too low: green:mobile & red:mobile (amber, blink)
> -       low: green:mobile & red:mobile (amber, turned on)
> -      good: green:mobile (turned on)
> 
> Suggested-by: Hauke Mehrtens <hauke@hauke-m.de>
> Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com>
> ---
> v1 -> v2
> 
>   - move _MOBILE before _MTD
>   - improve the commit description
> 
>  include/dt-bindings/leds/common.h | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>