Received-SPF: pass (google.com: domain of linux-kernel+bounces-117147-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Zi Yan <ziy@nvidia.com>
To: John Hubbard <jhubbard@nvidia.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
 LKML <linux-kernel@vger.kernel.org>, linux-mm@kvack.org,
 David Hildenbrand <david@redhat.com>, Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH] huge_memory.c: document huge page splitting rules more
 thoroughly
Date: Mon, 25 Mar 2024 09:28:17 -0400
Message-ID: <B9A3BBFA-5DE2-4C72-9CB0-38086001577F@nvidia.com>
In-Reply-To: <20240325044452.217463-1-jhubbard@nvidia.com>
References: <20240325044452.217463-1-jhubbard@nvidia.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_DDAFBCDB-A1D1-423F-969B-5B792FD518AB_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?/npDiC7tFk9If5xSrZ4c7ObCOXHifMSQp5NYm1KC2L15haJrOpYngAvlFqA+?=
 =?us-ascii?Q?n7Enufc5zEbHuluOTR2EdYrPSB1TOnLNQwlUfKZYfvusYzb8cYrMgzRFkM6N?=
 =?us-ascii?Q?OorhcPUIK7hMdtYRWqPG7TpYtsWdtfQ8B9FMIaWzdwUtm9wMgc40p91Nzwt5?=
 =?us-ascii?Q?a4CsSqkpCoLRFOw5MwAic6NOJhhEwbjVz8gxb1uWpfeZw50/ab36mEXHIHX5?=
 =?us-ascii?Q?24M56IYP5sPlcFrXuB32t16FCXysFBFSVWPTLjI4ol1ukP7Bp2v7Qtq1MZ/P?=
 =?us-ascii?Q?TCgVhLs+mbpSfBrtMbe+ArUL1xjmqcGkOTczwOQdhgFVvw6yXT+78Wis8+Lo?=
 =?us-ascii?Q?p8yphSfqTF7VAqQZb/Sibv8YXqmtBxChnQ4wcK3lgY/ES3L8WAVP6YcNItuY?=
 =?us-ascii?Q?kii4OmNhWWFhbgYxh9igBKH/ikCpFRikMbjKD6tBO6THF/V3YiFupjH78jmt?=
 =?us-ascii?Q?TbSuoFc1hLaP33rIw0XnmO8ezjVLICSSj2L9SperKMBVtVolMMaMlzoOU8v0?=
 =?us-ascii?Q?PzETDVYnIMGBumwdLEXEDUKOSh4rYPYauWw54XtXsT565+7JXgW/hxe6hBXP?=
 =?us-ascii?Q?o0kfSZCrpJhUmsae7fGrOflJk3Oea4cPv7yKuaGM91Et0gJLmHk6pQb+Oqo1?=
 =?us-ascii?Q?l4eMxAX5I9wWiKc7GaKEHmq4AvD/xQkRRNh4wOa0zo5HqsZesz+7Dm+TPhC+?=
 =?us-ascii?Q?NSDXV4/UG7p15V23YFeDjl2c6F5iQ4iy0JKQp/LWdvtKEl0p9g5pyFC2qbFY?=
 =?us-ascii?Q?pfwGWDczQ/1cbNjYNUk5jqm0CM5VcjZLHpAW41ZsifVl6niC8SG8bjpJ65l0?=
 =?us-ascii?Q?XX2qwmZ3Nm2dCpSPLD/y+s/SCFdt2vFGeW4rHdVjzFUzIFu04HbqiU1lEqjT?=
 =?us-ascii?Q?EEy58X3BTnSeVY9+GbvBIfqePE0RvmjQciOezGwmKVw6c5wY9Ov4FbVHqB/j?=
 =?us-ascii?Q?dWt13hCV2QE04VKsP+ewTvOhYrCRELLCvS9JWp78CPfmYZUqCnCzxktHu6yf?=
 =?us-ascii?Q?93vi22MIAnYO1TMP1Qc/7ogNoYddGA3VyqCH8H2zu4lKg2JrlrKP3ulRA+Sk?=
 =?us-ascii?Q?FBRtsessJpI127tEFITncDKl5AgOsBlzQ2UbJf9WeT0/+f3lkeaS+fQVM1uF?=
 =?us-ascii?Q?8NZyleFUoLYH5LbU2QgXKb0pTB9y928Sq+En/+v1l06C3ckfgH9bBjBb1wBV?=
 =?us-ascii?Q?VjaEomhdMZp8WdrvvCYA1IxWicQeXJYo8RWlLG3dBdrZybKiRLnU3Fg19xzj?=
 =?us-ascii?Q?on1f9xDgRlkm9Fte2uhHIs0b/OUdYScARU/3fjeLROhWFDv+G4P9499nNGIY?=
 =?us-ascii?Q?Qrk3Y2b0/w68HsCX+MpiY/m84OLQ6I+DDWbh9jSMGcP9tv8j90xcI+oY1mP3?=
 =?us-ascii?Q?/XmBxeQfHO5Hz/C1mjflaynNoMs2Fc85qtO1RUOjnwWES1qNFwezgl2zEQB0?=
 =?us-ascii?Q?nPTjr/hiSuSrB+rZ1nhhDsxnX/X8n1sP4qC4jcohm+gioc3Mv6ZNnA3FVPV4?=
 =?us-ascii?Q?BVauc1E70aghrvCfJwhdkdno3bY2tLwpIU3NQL7jGVeI4Z2b8WV0xTJvmkWU?=
 =?us-ascii?Q?FV450HNH/Asap4eDKC8=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: acdbe4ef-8203-4c4b-bb16-08dc4ccf6fcb
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2024 13:28:19.8433
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GSc8y8CGEUSCl8SYfLmD7awEWaegucs26EqBn57NJyBu/pJIwppkchJNkrxDqs9u
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7983

--=_MailMate_DDAFBCDB-A1D1-423F-969B-5B792FD518AB_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 25 Mar 2024, at 0:44, John Hubbard wrote:

> 1. Add information about the behavior of huge page splitting, with
>    respect to page/folio refcounts, and gup/pup pins.
>
> 2. Update and clarify the existing documentation, to compensate for the=

>    ravages of time and code change.
>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: Zi Yan <ziy@nvidia.com>
>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> ---
>
> Hi David, Matthew, Zi,
>
> This is a follow up from our short email thread of a week ago [1].
>
> Zi, I've inflicted some minor violence upon your original wording, and
> moved it into a Prerequisites section (item 4).
>
>
> [1] https://lore.kernel.org/all/d9c06bec-805f-4d53-9f91-6b8ad29fcb6b@re=
dhat.com/
>
> thanks,
> John Hubbard
> NVIDIA
>
>  mm/huge_memory.c | 42 +++++++++++++++++++++++++++---------------
>  1 file changed, 27 insertions(+), 15 deletions(-)
>
LGTM. Thanks. Reviewed-by: Zi Yan <ziy@nvidia.com>

--
Best Regards,
Yan, Zi

--=_MailMate_DDAFBCDB-A1D1-423F-969B-5B792FD518AB_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmYBe/IPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUA9AQAIVyi8yvBYVeUpP/o7g+C3moGAD8TrXR/Qyn
s6LDdahfGD+03ev9hUh6VbyO8xSMF339WZq6+tcEoBAvLt0NFH5F43W3qgZ35kr2
lw6CH8nYljHlk/YYTZ6Iq/sv2P2k4kYF9raIYD1uL817MHXDCIPEEzXNINzZPWtE
G397IrfUJKyvDX8Vqi9DQhO62q5Btj5lzfnM1km1htS8kU408+D9OriSVR7L9IfK
MJNHJUoK3HtoaeS0DCGFUaBzKYHmM+1TLFIEe7ZJPmLtGtdWEerlA20keL4RiBY9
yHJ/MXEqgUvJvhci/lxiuD5Vhn7xP5XRVCj4jh8updQkocp7bM2XcAzhIhl7wDtc
jWU6esVHyefrty0yE8sKf5ov+EvvwuyEB4wXaQ40c2LH5J+RtIlc0ovNAmZOOR2+
KA4vVIxkFZlifoEB7VMy7ZMxqNsZjflk37Rf1tVtBvMozjZT1HISI7pWC202Lv/9
5KxUy4bZQexhsbea7ZL95Lzl/0CyvBrYLQk7KdTH0CY2QIBtiBeYMzsLb9/O7Woz
THF2LyMzT6F3TzcsxooUZuDp/ZiugHxOMQ4mCVT27KyjB1fUhnSKa9wOK084BuK7
A2ciKx6QpQynhVRcWlQdY6waJU1uV5ZYzcpiPS5ynHlx5uHfMz6DNJy41NzrrxBP
qZNjDLnX
=WX2j
-----END PGP SIGNATURE-----

--=_MailMate_DDAFBCDB-A1D1-423F-969B-5B792FD518AB_=--