Received-SPF: pass (google.com: domain of linux-kernel+bounces-117124-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 25 Mar 2024 10:18:05 -0300
From: Jason Gunthorpe <jgg@nvidia.com>
To: Mostafa Saleh <smostafa@google.com>
Cc: will@kernel.org, robin.murphy@arm.com,
	linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
	linux-kernel@vger.kernel.org, joro@8bytes.org, nicolinc@nvidia.com,
	mshavit@google.com
Subject: Re: [PATCH] iommu/arm-smmu-v3: Fix access for STE.SHCFG
Message-ID: <20240325131805.GB6245@nvidia.com>
References: <20240323134658.464743-1-smostafa@google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240323134658.464743-1-smostafa@google.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?wCfItVl25NRx/HrcTK7jiJuliHpohXwWL897X4wrmV1zDYTMUlT3r88dzjDa?=
 =?us-ascii?Q?ymThI+RWsbO8sjqoM0huRQHmfS6Xktiip+caqN/urYYERDOipzMbjdgwuDhy?=
 =?us-ascii?Q?Nt9gzdWaedxy3xVfbmEylBQmO1Q3NZOyJMB0bGAZ3eT+9oLutonnBz/LbeYB?=
 =?us-ascii?Q?V31jKyhatnNKeC1GQWjPITBYdnBBkoO1eMfSXIjfQx8YJSfg4ifUeFALV4pE?=
 =?us-ascii?Q?ya9FwCDe9aEF+hQI21pRWEqblwQrLDTz5Feihj31OhNXppi5yhotBuiWi4sN?=
 =?us-ascii?Q?rPmYw5oZtPpc236ePGCwqQ+HzBzeLe+V7mNhMNOZE+qO3dXoF/Lr7p34S5J4?=
 =?us-ascii?Q?w+mJMPgJ+qHvOwqSAEo2On3M3COfx9RwUx/Ui8rJl6h16Q65YD0dF/JC3sxx?=
 =?us-ascii?Q?N6mB6R8n4p49Pm/pMrqXC+uRQVg9yNDGV27byJ/yRKBZMeyQrNSvhroXmgAL?=
 =?us-ascii?Q?HOfKujJq+ocMyXA/A4h31vGeLj3RkA4YamZDQWfQ7eKVCDWl7HovZ94TaAJl?=
 =?us-ascii?Q?E6E3lRB3h9rrg3zEPMUAJMaiACNhyfJNGR2EkMrVodv8MYiqAHEm/kn9w9TB?=
 =?us-ascii?Q?QzIQ9Tjv8DNz/8J56FuNcmfpSi1dxZNA2C9VzBu6V31X7Fmb9OpwpCA230xf?=
 =?us-ascii?Q?iBrMUbCVVAb4oiPmt5BBLKo3hIFhRYkfIsTpPod8EJLVUUs4DFtGPl6+/+l8?=
 =?us-ascii?Q?Bjp/eDCoQ9O8/86fq1fKo9eyWv6s40PXOG7LQzXpftT0flprBX8/MmiSG6d1?=
 =?us-ascii?Q?sRRY8SiUwLS+6XJa0MIOhZPdp2D96BdpWMMW4pl+X7MzvDah8gKNDi4VXXku?=
 =?us-ascii?Q?Amw0SHVddwYEtJC2O4ipIz9Jd230KpOv6ehAmdaCz6ZVFBBomgDvm8nEHrqV?=
 =?us-ascii?Q?qf0CR1f/ucyp/PyBts3LtUchAzQXuWsDjrJMNe2n6G2h88rr9f/nDf6GwLEV?=
 =?us-ascii?Q?4+mLWmeRrkceAefRz0YFD0XlkuGvcChSTUbPJ331R4nz0/MiRq3eEtP4r0uF?=
 =?us-ascii?Q?Hcz2qK0wiqcvdrSf93lcGznFbuwfLH0ffPZ8fCsIk+Ef93SCyavBcrYQDvxZ?=
 =?us-ascii?Q?Xzx+/ZuKrI38ZPZkv57JP687DU+IDbdyQXA8rPrPhZmHHupCUNNzo/L/9Dtd?=
 =?us-ascii?Q?qQ4cE1fIM9p3HT5m+Ex5kPcQs0Oit/IyhoRWrgSkBLylNBJcV6RjeSnV6qqL?=
 =?us-ascii?Q?RebvL7uvX/gJV+3vXUcD0IUJnI7N2rhs3dJKLTwRgb+TpfDOJxDSYlK5xeXp?=
 =?us-ascii?Q?qlbAkvqVoaNfTwm4xBGt2DBNVtDnxrrvbyLaA/fj+cp4Tl4lHkQ3iqtyWxut?=
 =?us-ascii?Q?uWY5PcQ7+jHeCzdnmOjjawJFg3UWnvKlRD+/lCB+RGfTPhAZoIDJCRDbPVIb?=
 =?us-ascii?Q?KqaYYyqrEHCDpJaS+Ga14OsjzaQs+y4DO77CK+Hhp1vrl9/FN+JYZl5AFopQ?=
 =?us-ascii?Q?sLQSUj+TjC1sZw1npDdP95EVuRW6ZrU2nIlnkoshmvz5X0TgUSraQAZfIf7V?=
 =?us-ascii?Q?S/Z7qnAQcLPKFO5qH2RcQ5ai8mDcS5K0YjKjB4hJIYfuUGaV2VekwS1uEdW9?=
 =?us-ascii?Q?xFieG2Bw7ZI7ouxUg6Y=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b5162f5-e29a-4699-074c-08dc4cce027c
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2024 13:18:06.9457
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tBYs9D0MV7CvlXf0ZjbjxjjkaYYNjV2oLiZlvQUv5asiNau3c9l7650S0Q0WYjS9
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7370

On Sat, Mar 23, 2024 at 01:46:58PM +0000, Mostafa Saleh wrote:
> STE attributes(NSCFG, PRIVCFG, INSTCFG) use value 0 for "Use Icomming",
> for some reason SHCFG doesn't follow that, and it is defined as "0b01".
> 
> Currently the driver sets SHCFG to Use Incoming for stage-2 and bypass
> domains.
> 
> However according to the User Manual (ARM IHI 0070 F.b):
> 	When SMMU_IDR1.ATTR_TYPES_OVR == 0, this field is RES0 and the
> 	incoming Shareability attribute is used.
> 
> This patch adds a condition for writing SHCFG to Use incoming to be
> compliant with the architecture, and defines ATTR_TYPE_OVR as a new
> feature discovered from IDR1.
> This also required to propagate the SMMU through some functions args.
> 
> There is no need to add similar condition for the newly introduced function
> arm_smmu_get_ste_used() as the values of the STE are the same before and
> after any transition, so this will not trigger any change. (we already
> do the same for the VMID).
> 
> Although this is a misconfiguration from the driver, this has been there
> for a long time, so probably no HW running Linux is affected by it.
> 
> Reported-by: Will Deacon <will@kernel.org>
> Closes: https://lore.kernel.org/all/20240215134952.GA690@willie-the-truck/
> Signed-off-by: Mostafa Saleh <smostafa@google.com>
> ---
>  drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 35 ++++++++++++++-------
>  drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h |  2 ++
>  2 files changed, 25 insertions(+), 12 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Thanks,
Jason