Received-SPF: pass (google.com: domain of linux-kernel+bounces-117132-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240314091512.1323650-1-lizhijian@fujitsu.com>
In-Reply-To: <20240314091512.1323650-1-lizhijian@fujitsu.com>
From: Ulf Hansson <ulf.hansson@linaro.org>
Date: Mon, 25 Mar 2024 14:18:47 +0100
Message-ID: <CAPDyKFo_D7cCoMMr3LQ6c=G-fVnaCU==_v0n9Dq_0biAaytqhg@mail.gmail.com>
Subject: Re: [PATCH] mmc: core: Convert sprintf/snprintf to sysfs_emit
To: Li Zhijian <lizhijian@fujitsu.com>
Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

On Thu, 14 Mar 2024 at 10:15, Li Zhijian <lizhijian@fujitsu.com> wrote:
>
> Per filesystems/sysfs.rst, show() should only use sysfs_emit()
> or sysfs_emit_at() when formatting the value to be returned to user space.
>
> coccinelle complains that there are still a couple of functions that use
> snprintf(). Convert them to sysfs_emit().
>
> sprintf() will be converted as weel if they have.
>
> Generally, this patch is generated by
> make coccicheck M=<path/to/file> MODE=patch \
> COCCI=scripts/coccinelle/api/device_attr_show.cocci
>
> No functional change intended
>
> CC: Ulf Hansson <ulf.hansson@linaro.org>
> CC: linux-mmc@vger.kernel.org
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
> This is a part of the work "Fix coccicheck device_attr_show warnings"[1]
> Split them per subsystem so that the maintainer can review it easily
> [1] https://lore.kernel.org/lkml/20240116041129.3937800-1-lizhijian@fujitsu.com/
> ---
>  drivers/mmc/core/block.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
> index 64a3492e8002..1e1e136d9e72 100644
> --- a/drivers/mmc/core/block.c
> +++ b/drivers/mmc/core/block.c
> @@ -234,7 +234,7 @@ static ssize_t power_ro_lock_show(struct device *dev,
>         else if (card->ext_csd.boot_ro_lock & EXT_CSD_BOOT_WP_B_PWR_WP_EN)
>                 locked = 1;
>
> -       ret = snprintf(buf, PAGE_SIZE, "%d\n", locked);
> +       ret = sysfs_emit(buf, "%d\n", locked);
>
>         mmc_blk_put(md);
>
> @@ -296,9 +296,9 @@ static ssize_t force_ro_show(struct device *dev, struct device_attribute *attr,
>         int ret;
>         struct mmc_blk_data *md = mmc_blk_get(dev_to_disk(dev));
>
> -       ret = snprintf(buf, PAGE_SIZE, "%d\n",
> -                      get_disk_ro(dev_to_disk(dev)) ^
> -                      md->read_only);
> +       ret = sysfs_emit(buf, "%d\n",
> +                        get_disk_ro(dev_to_disk(dev)) ^
> +                        md->read_only);
>         mmc_blk_put(md);
>         return ret;
>  }
> --
> 2.29.2
>