Received-SPF: pass (google.com: domain of linux-kernel+bounces-117171-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Content-Type: multipart/signed;
 boundary=825d513444cbcfd21e325bb336a957fc7c42f554a23f2161a262d85b011f;
 micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: bulk
Mime-Version: 1.0
Date: Mon, 25 Mar 2024 14:46:58 +0100
Message-Id: <D02VLMHNDLXY.16ACXUWB3TWZF@gmail.com>
Cc: <linux-media@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
 <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] staging: media: tegra-video: Fix
 -Wmaybe-unitialized warn in gcc
From: "Thierry Reding" <thierry.reding@gmail.com>
To: "Ricardo Ribalda" <ribalda@chromium.org>, "Jonathan Hunter"
 <jonathanh@nvidia.com>, "Sowjanya Komatineni" <skomatineni@nvidia.com>,
 "Luca Ceresoli" <luca.ceresoli@bootlin.com>, "Mauro Carvalho Chehab"
 <mchehab@kernel.org>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
 "Hans Verkuil" <hverkuil@xs4all.nl>
References: <20240323-gcc-arm-warnings-v1-0-0b45cc52f39e@chromium.org>
 <20240323-gcc-arm-warnings-v1-1-0b45cc52f39e@chromium.org>
In-Reply-To: <20240323-gcc-arm-warnings-v1-1-0b45cc52f39e@chromium.org>

--825d513444cbcfd21e325bb336a957fc7c42f554a23f2161a262d85b011f
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

On Sat Mar 23, 2024 at 11:41 AM CET, Ricardo Ribalda wrote:
> Make sure that tegra20_vi_get_input_formats always assign a value for
> yuv_input_format.
>
> Fix:
> drivers/staging/media/tegra-video/tegra20.c:624:72: warning: =E2=80=98yuv=
_input_format=E2=80=99 may be used uninitialized [-Wmaybe-uninitialized]
>
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
>  drivers/staging/media/tegra-video/tegra20.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/tegra-video/tegra20.c b/drivers/stagin=
g/media/tegra-video/tegra20.c
> index c25286772603c..c39b52d0e4447 100644
> --- a/drivers/staging/media/tegra-video/tegra20.c
> +++ b/drivers/staging/media/tegra-video/tegra20.c
> @@ -176,6 +176,7 @@ static void tegra20_vi_get_input_formats(struct tegra=
_vi_channel *chan,
>  		(*yuv_input_format) =3D VI_INPUT_YUV_INPUT_FORMAT_YUYV;
>  		break;
>  	case MEDIA_BUS_FMT_YVYU8_2X8:
> +	default:

This default seems rather arbitrary. Maybe we should follow the
tegra20_vi_get_output_formats() and default to UYVY? Also, maybe follow
the same scheme as that function (i.e. assign the default near the top
of the function rather than add a default case)?

Thierry

>  		(*yuv_input_format) =3D VI_INPUT_YUV_INPUT_FORMAT_YVYU;
>  		break;
>  	}


--825d513444cbcfd21e325bb336a957fc7c42f554a23f2161a262d85b011f
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmYBgFMACgkQ3SOs138+
s6Eydw//W72tYXdcn6FA3pjJOx89WN25ap9DecvjM0hvEGCYVJMvI2Tqxzp515tM
7setppTdJlH3fJIjNYv/LtBogx0bqd9pbyI6XVjKAXCdVuRM+GDHk3GHeUbloF2x
UPAemgsN18OjM6OsXPTqQNnEmcQH8LNaJMoEaursTaWEyIEQjp1e4jDXbeZ+GI2L
BBiQG/HqqpMExqtkulveghFtjrEDvo3WFhsGEyXikSOUmee2D0MBOf06IG7XgayE
SGiNbT7oDItuyZAq52Cic0woWiKsxo21MnVAJryem/0rLZSdDyjP8mORhIDdS2LT
9HrrhJBs7lPoi277e9GoVfDm8IiGtMZ0TIHJR0m93REatLyrhToyvXp6yJpGFDnb
vvoHvVapZBm1jauoE9Tpjf55rwhcEdtWi82ZbDdFzFp0PxDMpPZXPg9xK7hNuY0b
ejVcIjeBlwZHp+pFYawE5tTAyyfobc9zNPL/q7r+uPlhOfUw+pIo1BpNAq/ZYjK6
fgMZqUSX7fEydg63Mva45QKvuEX/LCVDueiieSKZPWwh865jyDgk9VZECSumOwKq
lwj+bwc9/iQBHbfg0KFGNurKz3fpBIC9TazXe63Sr8CPGJdDOMqUdVS+BhXYRxAh
d2kp3EUfFEkG2O5FaAhksqtCAc2Uwf1ZX3hMRz/PL6IYVTwRm4E=
=0X7r
-----END PGP SIGNATURE-----

--825d513444cbcfd21e325bb336a957fc7c42f554a23f2161a262d85b011f--