Received-SPF: pass (google.com: domain of linux-kernel+bounces-117158-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Content-Type: multipart/signed;
 boundary=7c0212269c912adc4455d93afd23d4aee2f75956631fcdfadad28a09c895;
 micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: bulk
Mime-Version: 1.0
Date: Mon, 25 Mar 2024 14:41:08 +0100
Message-Id: <D02VH5KH4A9R.6IOJPPMBF0K5@gmail.com>
Cc: <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
 <lgirdwood@gmail.com>, <jonathanh@nvidia.com>, <mkumard@nvidia.com>,
 <stable@vger.kernel.org>
Subject: Re: [PATCH] ASoC: tegra: Fix DSPK 16-bit playback
From: "Thierry Reding" <thierry.reding@gmail.com>
To: "Sameer Pujar" <spujar@nvidia.com>, <broonie@kernel.org>,
 <linux-sound@vger.kernel.org>
References: <20240325104928.2796868-1-spujar@nvidia.com>
In-Reply-To: <20240325104928.2796868-1-spujar@nvidia.com>

--7c0212269c912adc4455d93afd23d4aee2f75956631fcdfadad28a09c895
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

On Mon Mar 25, 2024 at 11:49 AM CET, Sameer Pujar wrote:
> DSPK configuration is wrong for 16-bit playback and this happens because
> the client config is always fixed at 24-bit in hw_params(). Fix this by
> updating the client config to 16-bit for the respective playback.
>
> Fixes: 327ef6470266 ("ASoC: tegra: Add Tegra186 based DSPK driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> ---
>  sound/soc/tegra/tegra186_dspk.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/tegra/tegra186_dspk.c b/sound/soc/tegra/tegra186_d=
spk.c
> index aa37c4ab0adb..3a152e76122b 100644
> --- a/sound/soc/tegra/tegra186_dspk.c
> +++ b/sound/soc/tegra/tegra186_dspk.c
> @@ -1,8 +1,7 @@
>  // SPDX-License-Identifier: GPL-2.0-only
> +// SPDX-FileCopyrightText: Copyright (c) 2020-2024 NVIDIA CORPORATION & =
AFFILIATES. All rights reserved.
>  //
>  // tegra186_dspk.c - Tegra186 DSPK driver
> -//
> -// Copyright (c) 2020 NVIDIA CORPORATION. All rights reserved.
> =20
>  #include <linux/clk.h>
>  #include <linux/device.h>
> @@ -246,6 +245,7 @@ static int tegra186_dspk_hw_params(struct snd_pcm_sub=
stream *substream,
>  	switch (params_format(params)) {
>  	case SNDRV_PCM_FORMAT_S16_LE:
>  		cif_conf.audio_bits =3D TEGRA_ACIF_BITS_16;
> +		cif_conf.client_bits =3D TEGRA_ACIF_BITS_16;

Do we perhaps want to move the common cif_conf.client_bits assignment
into the S32_LE case now? It doesn't make much sense to have a common
assignment that's overridden for the S16_LE case and only kept for the
only other alternative (S32_LE).

Thierry

--7c0212269c912adc4455d93afd23d4aee2f75956631fcdfadad28a09c895
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmYBfvUACgkQ3SOs138+
s6FALg/+Ife+lFuYpPI7oOhuX256Czmwcb6Ey73+YJeFTYvB51f7oFhaupJh0Urj
Gda3FfgCjHbEU4cMrx2jYyKN//Fvs1Yqc3+JK4tmt7E5JAPV4S52lLty8Lgpmvd/
2aDv5UgrH58PrQgQu/QKHmNcGJ0LrAXp6pH6BGrRJZ0URFiOX0CiGRM3W0YsWw9y
87FYcPkpH8Y0hHjfWhJMeh6npOc6CbcjmCdMo7p3SYjBR9Z88BtJA0JGKyE/JoQ6
tLCMgAnJCXbWGfTuUOqCck5kZE0zo7n9Mu8lDdMHhlyJalyc5ikSBiIhGXuDJQHO
LTEyyPO6d3TVaSKF6nRCq5Vg8eaxVW5L5Knc6EYIm+DgsUvXz12ClhXl08EPKtxe
odUxIZuAajREk8YFon5cGszOLgjLEMbl+/d4abD2+YHe0Ct3Qdxwlb0x6pcdWUeg
bxYPqTpAw57nMkmTfZmaUgi42xcgekE0OnLuw8oQ+gPrhC1S+MBJYxe5sztN6XNm
ubfhqDRdniGPGtvnXw9snSpl30q5ec5ZXArARO593ZUSXC6uKK1Rg5s1+na+iKTS
jaXg+yCMcbx01JO3M/VvC2+fsSuCZ1MjBPskCHg+o2jbs9pbpPLpJRV5xZFISyvT
IZfDLFEuJJ1DUp6dVbJbaLHAbPhIaFJmxWLLZ0pGdWZ5wGEC8Nk=
=TLnc
-----END PGP SIGNATURE-----

--7c0212269c912adc4455d93afd23d4aee2f75956631fcdfadad28a09c895--