Received-SPF: pass (google.com: domain of linux-kernel+bounces-116513-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID:
 <SY4P282MB30638B59AF7677462C051518C5362@SY4P282MB3063.AUSP282.PROD.OUTLOOK.COM>
Date: Mon, 25 Mar 2024 14:27:54 +1000
User-Agent: Mozilla Thunderbird
From: Stephen Horvath <s.horvath@outlook.com.au>
Subject: Re: [PATCH 1/2] platform/chrome: cros_kbd_led_backlight:
 Automatically enable keyboard backlight control if feature present in EC
To: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: Lee Jones <lee@kernel.org>, Benson Leung <bleung@chromium.org>,
 Guenter Roeck <groeck@chromium.org>, chrome-platform@lists.linux.dev,
 linux-kernel@vger.kernel.org
References: <20240322102800.1322022-1-s.horvath@outlook.com.au>
 <SY4P282MB306333469B31348E4A25A1A5C5312@SY4P282MB3063.AUSP282.PROD.OUTLOOK.COM>
 <ZgDuiEYcgMTuZAeA@google.com>
Content-Language: en-AU, en-US, en-GB
In-Reply-To: <ZgDuiEYcgMTuZAeA@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SY4P282MB3063:EE_|ME3P282MB1747:EE_
X-MS-Office365-Filtering-Correlation-Id: 1347cb5e-d267-4cf9-603c-08dc4c83f1d1
X-MS-Exchange-SLBlob-MailProps:
	7qh87CJt6y28mnXrYaz3TbdiDbghv9xw0CB7WsKaKNjE19jLC1uofT5Tcsq7Li+hDHHS09RxIgZhDhlPodWk6r+ENudonLFfukQ7QeF0DDnzTtXCLHxZiO5H435q2tIhg2oUMXmzqs/RY6eYzpXsQgFzGm2CTxe+XLNjRO7W4N+LIEU2R+NUIXOVz/dG1efiIvSfIpoX6XTMVgqcUVUrSmtb6KXpi6Yg5MymgSwi6lJgLB7G7WxZXljZi/+whMM2U6BM3uuZ3ffhsHZt+KvWlvKQ2FayZN3KhOXNspWlUhIOLpAGwzIg/lAP4BDTl1S1onUUYOQ1lTXqVnVCe4bNPG0HfR0HTQyoLLxNqhyhwaIFxlR7IwaL+jS3UN5QhdUmT4ij8aV1Ceia8zmR7bWzB4zE4iCxzLJEwXpAHwyN3I9J8Z+bwc8FD28ZhMA1EkTQ9C2uUtLcv3grQsAxTblBaJEw94FGkF3r1s85LC7POXfNvAgsq57lyVcWCKPom6Z+S3YKPGPItEa3bwdDrG/LfXjs6lyMigQScNM6A9arR97Y7w71p3Q9uhvAsOpweJSXFdHo/nUgAX7x5T0Yt7Cg7CamczFxclj9NkxzEHh17TUn0W1yWyC/Feq/7ojX/nE+t/imjkl1oJY3DqnCMNICTtJkYhCqXb5EkxfVPbv54DA58ptTPmxFoXua7KsoNYPHIqHlSeeDLEbewWNigXmpT5TYmmMPsnAEi7SyqZB1wYVc7vMgXWpOXhj4QnY9LNXE
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4aQaXrk2QPjbjpb9CVUTRgY1+vE+ilo9W0Nc1KMND2Eo+69cBe0nJwDYKJEi9EFlxUsXgvrSFSFGC9fx36WvZ10mHTAraIZI/quPlwlfTl3CBAZBY3vVJ3c1iSDPauvsYa8tBb6NUquhWpSJvWCyAmYc2sOA/ty5zHoE4KAfG39RDWQrpnVJeCk1Txz8oPKCglzdwpqxdY7apeQSxY+uz/OMbigjzd6+yjEV3XT1J8ar+CW7i73dyQy7UOuTS0geDyBl+mexmWlVcVbKYzJdvjVhCmB332idErPeFxZy/TzoVX4cqIr8Wq/JF9SfTtyJbwUqOQyK4pKW42BgXEF9M5QwUIi+hj/3KIADx5688laSzif55pPd/mlWehpf19Qb/9ceNGJA1oxBsCJvQfFlI5RVKsG2n1/nvNfrT8Q3y73NXKBCGXNTX7h87G0FVu288YTuHcG1BMoVsJa9E0uP39YBf7BIwLzSWQlpQXqCuXcUoQY4PQ3+BwJlTbqZjpVNb0IF31eMv2B8X5lAwtSXNDjSid9OaHcFVXCbbDIYmNJ1/cMIVA3fx6NiuWSqghmZ
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dm9VTjRrR0JjYlhwd3F5TzlWZ1RPNThHZjFuV2hCczZzS3JWdDdBeUh2ZjZL?=
 =?utf-8?B?MGNwTVpGUk5FNEZvZE5Nc0dsanVkUm83VmZpMXJtMXNsVE55K0xnOHovNTlS?=
 =?utf-8?B?Qk5QY3piZzQ0WUg4Qi9ld1E0NXBQcitLRHZUa1J5c0FmSkdId2dhT3kyaXMy?=
 =?utf-8?B?WHh1aS8wc2lGbVlZTWNmSDlES0FKNEVkMys2V2NVbWxCWGdZQjc3elJOeGVI?=
 =?utf-8?B?REpCMEY5ZHNYNUYyR0oycVVaK3Z6R2NuY1FONThCaS9NZ0w4TzlTaEdSTTF3?=
 =?utf-8?B?bTZDdHNLQ0xwbkJYSTdzdjl2aHdmOW84K01VTjBhcENPSU1QWTNmNklrL1BG?=
 =?utf-8?B?Y2J3aFE0OGM0NnBlOUJ6YytaYitBWXQyV1Zpc0F0SjBvRE1mV1pHeTBQa3Iw?=
 =?utf-8?B?RDNyRkVmUmZIUjRWVWpwVDdNNkVDeGdGWnQyZ09EVUcrSXY3dkFDRGYydEs2?=
 =?utf-8?B?RHlwbC9Lck9xRGh6SS9HRVFEZUdzZ2hIOFBLVmZxclcrOE1Md2lBYW9HUUdZ?=
 =?utf-8?B?bkVvN29kTUVsWjd3YVlBTWtkV2RDTG1KRnYwNHluZTc3WXRXZGxhNUxWeWNX?=
 =?utf-8?B?QXlPN3MwNU1pc0tDbVRNcUlaYnlpbHQxTGVkbWo2RWRaNjJQNDRDaDNXRTMy?=
 =?utf-8?B?Y2FNNElybUJJYld2YXM3a2ZIbXFOaWpCWlVuMlRJY0RDVjVQOG9CUnZYTEt6?=
 =?utf-8?B?c2ZXYWE1V3k4N25XWEMxajh1S0lnSkpTNlB3dDhNcVJXRThGcDkrWE1TNTFI?=
 =?utf-8?B?WFh3S0lZOTBDRGRLNXRhUXZMZzNBTml3T2ZmSGtjajUzU29NMWpCUU5LamlP?=
 =?utf-8?B?bnRiNWFsL0d5REdhWU1iRVphSUl3T29LN1RvcDV1UE1RVGgrK3dXU2pYeDVj?=
 =?utf-8?B?OENGT0FKVSsrOCtveE8vWGM4cDExc0xRSXZRK1BmaEtIa0ptTmx0REZzTEUw?=
 =?utf-8?B?R0w1RmF4VzZCaXExa0ZWbVdxb01nR2k1ZmZGbkFnZ3R3V2ZJUGczTkRNam9v?=
 =?utf-8?B?eVl6NjBRa2hEWWlyNWQ2MHc3N0pvelhDYUNHTGJhOWJxbmVmV0l3Snc3T3hr?=
 =?utf-8?B?VFJMUWNURmV5bC92bG1aSHNjNE1kRnBweFcxbk1xb2VDTnZYMEF4ZkJGeExl?=
 =?utf-8?B?STJjanJkQnhQRjhWdmtnTHcrZzA5eUNhdEE1akowMVoxY1hOeHFlQWlXUnBI?=
 =?utf-8?B?K1pHTWRhMkxPY0lxRG5tQTMxSE9JWHlIdVlvWlR1ZHRqMmpTbjNBalp2ZC9z?=
 =?utf-8?B?Z3hMazVjMkRnMmt5R0Z6QnhiRXRsQ1NEYklJZmltdU14bEFnbTRMMDBOaVhZ?=
 =?utf-8?B?VHZRRmhmSkNwUFlvSFlDT0tvcWxDU3htMWxtMjBuUnV6UUl5NTJQb0xxNE1D?=
 =?utf-8?B?bnJYVHk4SzJvUHlvckNENVNzbktNWldJRysvN0cySXgwYWdTL291V3ZHazVr?=
 =?utf-8?B?MFBPMzh4OHM4L0hSUkd5YnhSNEp5NGlLMVN2ZXcwUmdrbVp2L3hsdmJrU0Vi?=
 =?utf-8?B?QzJaRXQySEF5anJoZUlkc3hFdzhUYnE5UFVwZmJJd1NHU0JOVnJJZFFGa2Vv?=
 =?utf-8?B?TFRXd09sUXp3UlpRQ09sM2FuZVBxU21mQy9ZKzd4MmV4VDJsOTlOWkpJRnE3?=
 =?utf-8?B?N2UrT1h3dXZsUS9jYmY1bU5Kcmc2MmZic2Rhd2t3M2crVnpkVWZ1THMvSUUy?=
 =?utf-8?B?Z3BnVm5PbmVFZHhaQTMzY3h5WWw0bkR5SEdwRTdkclNsanVWZ0wxVnNGUita?=
 =?utf-8?Q?jtTBAXk2YIUlGO1SiCeBylRXguRAVHH+ejfyPrw?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-746f3.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 1347cb5e-d267-4cf9-603c-08dc4c83f1d1
X-MS-Exchange-CrossTenant-AuthSource: SY4P282MB3063.AUSP282.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2024 04:27:56.2801
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: ME3P282MB1747

On 25/3/24 13:24, Tzung-Bi Shih wrote:
> If they aren't part of commit message, please put them after "---". Please
> separate to an independent patch if they fix different things.

Alright thanks, the separation thing did kinda occur to me after I'd 
send it, but I will do it next time.

> I'm not sure if it really fixes anything.  See [1] or [2].

Ahh okay, I guess it was probably a side effect of me breaking something 
else then, since the module only seemed to crash without that change. 
But I was also mildly confused how it seemed to work fine like that 
elsewhere though.

> By current design, the `drvdata` should be provided by either ACPI or OF match.

Yeah sorry, I didn't really know of a simpler way to do it, since it 
gets started from `mfd_add_hotplug_devices` in cros_ec_dev.c in this 
patch. I'll try and find a better way if I decide to make a v2.

> The patch is ruining the use cases in OF world (e.g. [3]).

I was kinda worried that the module would somehow launch twice, but I 
have a feeling that wouldn't be possible anyway.

Thanks for your feedback!
Steve