Received-SPF: pass (google.com: domain of linux-kernel+bounces-117232-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 25 Mar 2024 14:18:08 +0000
From: Mark Brown <broonie@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: wenst@chromium.org, lgirdwood@gmail.com, robh@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	matthias.bgg@gmail.com, perex@perex.cz, tiwai@suse.com,
	trevor.wu@mediatek.com, maso.huang@mediatek.com,
	xiazhengqiao@huaqin.corp-partner.google.com, arnd@arndb.de,
	kuninori.morimoto.gx@renesas.com, shraash@google.com,
	amergnat@baylibre.com, nicolas.ferre@microchip.com,
	u.kleine-koenig@pengutronix.de, dianders@chromium.org,
	frank.li@vivo.com, allen-kh.cheng@mediatek.com,
	eugen.hristev@collabora.com, claudiu.beznea@tuxon.dev,
	jarkko.nikula@bitmer.com, jiaxin.yu@mediatek.com,
	alpernebiyasak@gmail.com, ckeepax@opensource.cirrus.com,
	zhourui@huaqin.corp-partner.google.com, nfraprado@collabora.com,
	alsa-devel@alsa-project.org, shane.chien@mediatek.com,
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH v3 05/22] ASoC: mediatek: Add common machine soundcard
 driver probe mechanism
Message-ID: <6b9dd2ad-a24e-497a-8a5c-c7c04475cf5d@sirena.org.uk>
References: <20240313110147.1267793-1-angelogioacchino.delregno@collabora.com>
 <20240313110147.1267793-6-angelogioacchino.delregno@collabora.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="HA8wmAlBS5gx6s1i"
Content-Disposition: inline
In-Reply-To: <20240313110147.1267793-6-angelogioacchino.delregno@collabora.com>


--HA8wmAlBS5gx6s1i
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 13, 2024 at 12:01:30PM +0100, AngeloGioacchino Del Regno wrote:
> Add a common machine soundcard driver probe function that supports both
> DSP and AFE-direct usecases and also provides a hook for legacy machine
> soundcard driver probe mechanisms.
>=20
> Note that the hook is there because, even for legacy probe, a lot of the
> actual code can still be commonized, hence still reducing duplication
> for the legacy devicetree retrocompatibility cases.
>=20
> This common probe function deprecates all of the inconsistent previous
> probe mechanisms and aims to settle all of the MediaTek card drivers on
> consistent and common devicetree properties describing wanted DAIs,
> device specific DAI configuration and DAI links to codecs found on
> each device/board.

This breaks allmodconfig builds:


/build/stage/linux/sound/soc/mediatek/common/mtk-dsp-sof-common.c: In funct=
ion =E2=80=98mtk_sof_dai_link_fixup=E2=80=99:
/build/stage/linux/sound/soc/mediatek/common/mtk-dsp-sof-common.c:18:41: er=
ror: initialization discards =E2=80=98const=E2=80=99 qualifier from pointer=
 target type [-Werror=3Ddiscarded-qualifiers]
   18 |         struct mtk_sof_priv *sof_priv =3D soc_card_data->sof_priv;
      |                                         ^~~~~~~~~~~~~
/build/stage/linux/sound/soc/mediatek/common/mtk-dsp-sof-common.c: In funct=
ion =E2=80=98mtk_sof_card_probe=E2=80=99:
/build/stage/linux/sound/soc/mediatek/common/mtk-dsp-sof-common.c:58:41: er=
ror: initialization discards =E2=80=98const=E2=80=99 qualifier from pointer=
 target type [-Werror=3Ddiscarded-qualifiers]
   58 |         struct mtk_sof_priv *sof_priv =3D soc_card_data->sof_priv;
      |                                         ^~~~~~~~~~~~~
/build/stage/linux/sound/soc/mediatek/common/mtk-dsp-sof-common.c: In funct=
ion =E2=80=98mtk_sof_find_tplg_be=E2=80=99:
/build/stage/linux/sound/soc/mediatek/common/mtk-dsp-sof-common.c:76:41: er=
ror: initialization discards =E2=80=98const=E2=80=99 qualifier from pointer=
 target type [-Werror=3Ddiscarded-qualifiers]
   76 |         struct mtk_sof_priv *sof_priv =3D soc_card_data->sof_priv;
      |                                         ^~~~~~~~~~~~~
/build/stage/linux/sound/soc/mediatek/common/mtk-dsp-sof-common.c: In funct=
ion =E2=80=98mtk_sof_check_tplg_be_dai_link_fixup=E2=80=99:
/build/stage/linux/sound/soc/mediatek/common/mtk-dsp-sof-common.c:116:41: e=
rror: initialization discards =E2=80=98const=E2=80=99 qualifier from pointe=
r target type [-Werror=3Ddiscarded-qualifiers]
  116 |         struct mtk_sof_priv *sof_priv =3D soc_card_data->sof_priv;
      |                                         ^~~~~~~~~~~~~
/build/stage/linux/sound/soc/mediatek/common/mtk-dsp-sof-common.c: In funct=
ion =E2=80=98mtk_sof_card_late_probe=E2=80=99:
/build/stage/linux/sound/soc/mediatek/common/mtk-dsp-sof-common.c:147:41: e=
rror: initialization discards =E2=80=98const=E2=80=99 qualifier from pointe=
r target type [-Werror=3Ddiscarded-qualifiers]
  147 |         struct mtk_sof_priv *sof_priv =3D soc_card_data->sof_priv;
      |                                         ^~~~~~~~~~~~~
cc1: all warnings being treated as errors

--HA8wmAlBS5gx6s1i
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmYBh58ACgkQJNaLcl1U
h9Dw2Qf+OK6uEVJdUDAeL+cRMOtxJ5v8lWJ4kCDEd4EzMY8PITg8YZaxDb1HJs18
yfD4+oR2f/uMSGayxCnuRgzBthSs96xOJ34EkRpUgsB81RrC1Jjv5zWwIP1SCQlN
e2rKPS4ccBdE5uowKduc5TIbqbgbjLCArqTpqHDX6IBQP4A3SqYkcv/tOwFHuC/t
kE6+fH8gG7hQ9no9cE3WumRCLDyE8rRca6smAENrfcco8/5DCg2LqJ+SOEC64X+o
TYw0mmtRwPdObNmdHyrCtfk9XppdDLh21bKZrQvpj7WW2+EqSzbYLdyxvArVbzMq
bEqhwUbisC0nv6/RJbKsKWZy/N3IUA==
=6CF1
-----END PGP SIGNATURE-----

--HA8wmAlBS5gx6s1i--