Received-SPF: pass (google.com: domain of linux-kernel+bounces-117325-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Thomas Gleixner <tglx@linutronix.de>
To: Nipun Gupta <nipun.gupta@amd.com>, alex.williamson@redhat.com,
 gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
 kvm@vger.kernel.org
Cc: maz@kernel.org, git@amd.com, harpreet.anand@amd.com,
 pieter.jansen-van-vuuren@amd.com, nikhil.agarwal@amd.com,
 michal.simek@amd.com, abhijit.gangurde@amd.com, srivatsa@csail.mit.edu,
 Nipun Gupta <nipun.gupta@amd.com>
Subject: Re: [PATCH v4 1/2] genirq/msi: add wrapper msi allocation API and
 export msi functions
In-Reply-To: <20240305043040.224127-1-nipun.gupta@amd.com>
References: <20240305043040.224127-1-nipun.gupta@amd.com>
Date: Mon, 25 Mar 2024 16:06:42 +0100
Message-ID: <87edbyfj0d.ffs@tglx>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

On Tue, Mar 05 2024 at 10:00, Nipun Gupta wrote:

  Subject: genirq/msi: Add MSI allocation helper and export MSI functions

> MSI functions can be for allocation and free can be directly
> used by the device drivers without any wrapper provided by
> bus drivers. So export these MSI functions.

s/can be for/for/ otherwise the sentence dos not make sense.

> Also, add a wrapper API to allocate MSIs providing only the
> number of IRQ's rather than range for simpler driver usage.

s/IRQ's/interrupts/ 

> Signed-off-by: Nipun Gupta <nipun.gupta@amd.com>

Other than that:

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>

Alex, feel free to pick this up with the nitpicks resolved and route it
through your tree together with the VFIO driver.

Thanks,

        tglx