Received-SPF: pass (google.com: domain of linux-kernel+bounces-117408-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 25 Mar 2024 16:49:07 +0100
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Richard
 Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH v1 1/1] mtd: core: Align comment with an action in
 mtd_otp_nvmem_add()
Message-ID: <20240325164907.0c8a89fb@xps-13>
In-Reply-To: <ZgGYDMzAWEaPkAXh@smile.fi.intel.com>
References: <20240325151150.3368658-1-andriy.shevchenko@linux.intel.com>
	<ZgGYDMzAWEaPkAXh@smile.fi.intel.com>
Organization: Bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Andy,

andriy.shevchenko@linux.intel.com wrote on Mon, 25 Mar 2024 17:28:12
+0200:

> On Mon, Mar 25, 2024 at 05:11:50PM +0200, Andy Shevchenko wrote:
> > The comment is related to the non-error case, make it more clear
> > by inverting the condition. It also makes code neater at the end. =20
>=20
> Just realized that even semantically it's better as it's done here
> since we have an error path from which we exceptionally return successes
> (in some cases). Tell me if I need to add this to the commit message.
>=20

It's fine like that.

Thanks,
Miqu=C3=A8l