Received-SPF: pass (google.com: domain of linux-kernel+bounces-117419-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 25 Mar 2024 10:55:12 -0500
From: Rob Herring <robh@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: Vinod Koul <vkoul@kernel.org>, linux-kernel@vger.kernel.org,
	Conor Dooley <conor+dt@kernel.org>, devicetree@vger.kernel.org,
	imx@lists.linux.dev, dmaengine@vger.kernel.org,
	Joy Zou <joy.zou@nxp.com>, Peng Fan <peng.fan@nxp.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH v3 4/5] dt-bindings: dma: fsl-edma: add fsl,imx8ulp-edma
 compatible string
Message-ID: <171138211122.4034960.14889461643514509727.robh@kernel.org>
References: <20240323-8ulp_edma-v3-0-c0e981027c05@nxp.com>
 <20240323-8ulp_edma-v3-4-c0e981027c05@nxp.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240323-8ulp_edma-v3-4-c0e981027c05@nxp.com>


On Sat, 23 Mar 2024 11:34:53 -0400, Frank Li wrote:
> From: Joy Zou <joy.zou@nxp.com>
> 
> Introduce the compatible string 'fsl,imx8ulp-edma' to enable support for
> the i.MX8ULP's eDMA, alongside adjusting the clock numbering. The i.MX8ULP
> eDMA architecture features one clock for each DMA channel and an additional
> clock for the core controller. Given a maximum of 32 DMA channels, the
> maximum clock number consequently increases to 33.
> 
> Signed-off-by: Joy Zou <joy.zou@nxp.com>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> 
> Notes:
>      Changes in v3:
>         - Change clock name form CHXX-CLK to chxx
>         - Fix typeo 'clock'
>         - Add dma-cell description
>         - About clock-names:
>           items:
>             oneOf:
>               - const: dma
>               - pattern: ...
> 
>         Which already detect naming wrong, for example:
> 
>         clock-names = "dma", "ch00", "ch01", "ch02", "ch03",
>                       ....
>                       "ch28", "ch29", "ch30", "abcc";
> 
>         arch/arm64/boot/dts/freescale/imx8ulp-evk.dtb: dma-controller@29010000: clock-names:32: 'oneOf' conditional failed, one must be fixed:
>                 'dma' was expected
>                 'abcc' does not match '^ch(0[0-9]|[1-2][0-9]|3[01])$'
> 
>         Only lose order check, such as ch00, dma, ch03, ch02, can pass check.
>         I think it is good enough.
> 
>         I tried rob's suggestion, but met some technology issue. Detail see
> 
>         https://lore.kernel.org/imx/20240229-8ulp_edma-v2-0-9d12f883c8f7@nxp.com/T/#mc5767dd505d4b7cfc66586a0631684a57e735476
> 
>  .../devicetree/bindings/dma/fsl,edma.yaml          | 40 ++++++++++++++++++++--
>  1 file changed, 38 insertions(+), 2 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>