Received-SPF: pass (google.com: domain of linux-kernel+bounces-117440-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 25 Mar 2024 09:10:26 -0700
From: Vanshidhar Konda <vanshikonda@os.amperecomputing.com>
To: Beata Michalska <beata.michalska@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 
	ionela.voinescu@arm.com, sudeep.holla@arm.com, will@kernel.org, catalin.marinas@arm.com, 
	vincent.guittot@linaro.org, sumitg@nvidia.com, yang@os.amperecomputing.com, 
	lihuisong@huawei.com
Subject: Re: [PATCH v3 0/3] Add support for AArch64 AMUv1-based
 arch_freq_get_on_cpu
Message-ID: <5bdlm4kzni6x2bdy7kmmomf7cmyohjhr4nr7v2mb2pchuhkulj@moakmpptnbg5>
References: <20240312083431.3239989-1-beata.michalska@arm.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20240312083431.3239989-1-beata.michalska@arm.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?cxJ6Xr6jcNtIMNL3cawSdWEBVG6Aq/VtGkVoxFreCQBybS4zUezVEOq9Kmtk?=
 =?us-ascii?Q?Mcsmv5LJapwjmxpzW8976sKOGiO5229cpMp0DKBhBwPmeregdt3bIPYe+lxD?=
 =?us-ascii?Q?YjoqTtCG6o8rQwQIj4Hwf50pmRbvgF13oB2gUPAqLASVCD8dgFCNVeRQk4gr?=
 =?us-ascii?Q?HzzeK5DA8aJ9rCi0EyBVDGgT8QEVY/239YbCE2M1DGewWmdkRsq509W3LM1l?=
 =?us-ascii?Q?W7Sn6BXC+iHaQ4Plk42wp6OJjE1EtoUISTtXCVq7NeWED/XW4X2eWHJnbPGs?=
 =?us-ascii?Q?GJ+P8y8btRllqQXuZu6xS1a/vVdbS3gCNqfe594qUmPvAY9PNYUEHu+wor6w?=
 =?us-ascii?Q?Qo0clE8qDiu+W1rlX9MB+6DvouI4Lt2OPken3ZLJQyvW7RNiO1qJCp+6tneO?=
 =?us-ascii?Q?ey9tbxl9Umnj5yE3a+An5iv0xsmMkFw+osbLlX/kPhYjQByKjbjV8m8snK38?=
 =?us-ascii?Q?NxqPEyLzBNMmqVpzIHx7NzMCjxm+wmmtzczdTTG5AP0fqrcX5C0Mlokx+CyN?=
 =?us-ascii?Q?3tMSpqThatWzdQcw/GH3025ZT8L21bEepkD8WyVp0POOrLXlE5TlwOfq1Kd2?=
 =?us-ascii?Q?jEDIu1urBa9anQEBsH66qWFpYcYtuY9vMN+kqxBQ5Dj8d2j3sWgk5glfbdYH?=
 =?us-ascii?Q?99sZBDfJnTKN6B9QFgckDNj/fAELOziIQCFayrfii+8nUXlTmT/1eqJxhBpU?=
 =?us-ascii?Q?2nWlQb2MPMAJGEGUWbx3GYNVLlGU6dY8Smk/MQeDZxjpLnu8NjAdXvJKAp4v?=
 =?us-ascii?Q?alqG5I0vfUKMz0KQskfKCYjt9r1+d2iuJf5k6CPA1WlT09k4EIULGoBh7XTI?=
 =?us-ascii?Q?m2uTIBA2QpESf8pgkitReHjS5aP6iK6MVTMI5dyosBgub6CYPD3hcKcYtlIL?=
 =?us-ascii?Q?6e/ZslHmFrZ01yv3dA7E1jyVs2L96B6fwaDckGziJgO9ADHjP97qOwKlqlvh?=
 =?us-ascii?Q?crdbaddwHtyXJFS9b3MC8Uo9lt+guUzDR2RhcobA8m6c1VgdVZM8Ms4EuL4B?=
 =?us-ascii?Q?G3HUTc1sNbBhq1aYDv1PEqQxLeaXef4WSFCo7XMqSDu2fyQVrRZLSYv8//Ip?=
 =?us-ascii?Q?77qrL+rjLWPKFbfBTxydJfhUygTdRX6GZGshubQb5TPt/UZkY7mF4Kj/5ssR?=
 =?us-ascii?Q?8ussIVoQvomyE3095aw5Ur+fqLiSmAgM8fx2WivwHLseAAreebG1xKC/Yoav?=
 =?us-ascii?Q?qMkRUea0tLKbd7/EoOJo8A8FCCzohROQdsGnw9l1dy2kjj+O7xlORBpul9pF?=
 =?us-ascii?Q?ksLjdU+bMtG88TzVUjSyovC4ybt0JGhuMv0FSgIKCUFvirY4wFpCBp5dnHtR?=
 =?us-ascii?Q?IQOtSxVP1RiYaWNWuB8IwKNHbsVvQZ0sZTpLmzEytzupTXstlOdeOXOIiJ+P?=
 =?us-ascii?Q?9YxNAT1zvqfZHry00k9+gIpsDU3EFsMbC4LI+0Pck2yJzRA+Csx/NZ0k7QgV?=
 =?us-ascii?Q?2KQ3vCmuL+hGNbjQm3EwiIZD81wrLvuGmvFVHDoP0bTrMyec1JL7uHtbL89w?=
 =?us-ascii?Q?N5TxvLXnDvt8MhIRQhuXaYDnYKpINU02SXdNVB/0+ubnUKhU3Rr0+kVM1ok3?=
 =?us-ascii?Q?2YFQyBRwA5hqNw2P8wYRmDtTJ6hzkCsAzmV6acArVkYL+KGlFpsheSwOQggx?=
 =?us-ascii?Q?XjiaJ68go8ArFpKthrTDfNQ=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e184b6f7-62ef-4d50-f26d-08dc4ce61715
X-MS-Exchange-CrossTenant-AuthSource: MW4PR01MB6498.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2024 16:10:29.6149
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dUd67gmX/xxPM7PpYGGRyjaxs41qjwFdiYew88dtkrBH6TtAlEHOqAhdqml5a+Y12EDyrrcKonFPiMskU1lZNi2p6uZ/02Jlvup2fyOq/iwQWrBXXkdKXD9rhtFln0Ya
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR01MB6724

On Tue, Mar 12, 2024 at 08:34:28AM +0000, Beata Michalska wrote:
>Introducing arm64 specific version of arch_freq_get_on_cpu, cashing on
>existing implementation for FIE and AMUv1 support: the frequency scale
>factor, updated on each sched tick, serves as a base for retrieving
>the frequency for a given CPU, representing an average frequency
>reported between the ticks - thus its accuracy is limited.
>
>The changes have been rather lightly (due to some limitations) tested on
>an FVP model.
>

I tested these changes on an Ampere system. The results from reading
scaling_cur_freq look reasonable in the majority of cases I tested. I
only saw some unexpected behavior with cores that were configured for
no_hz full.

I observed the unexplained behavior when I tested as follows:
1. Run stress on all cores
    stress-ng --cpu 186 --timeout 10m --metrics-brief
2. Observe scaling_cur_freq and cpuinfo_cur_freq for all cores
    scaling_cur_freq values were within a few % of cpuinfo_cur_freq
3. Kill stress test
4. Observe scaling_cur_freq and cpuinfo_cur_freq for all cores
    scaling_cur_freq values were within a few % of cpuinfo_cur_freq for
    most cores except the ones configured with no_hz full.

no_hz full = 122-127
core   scaling_cur_freq  cpuinfo_cur_freq
[122]: 2997070           1000000
[123]: 2997070           1000000
[124]: 3000038           1000000
[125]: 2997070           1000000
[126]: 2997070           1000000
[127]: 2997070           1000000

These values were reflected for multiple seconds. I suspect the cores
entered WFI and there was no update to the scale while those cores were
idle.

Thanks,
Vanshi