Received-SPF: pass (google.com: domain of linux-kernel+bounces-117483-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 25 Mar 2024 13:38:40 -0300
From: Jason Gunthorpe <jgg@nvidia.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Andrew Morton <akpm@linux-foundation.org>, Peter Xu <peterx@redhat.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC PATCH 0/8] Reimplement huge pages without hugepd on powerpc
 8xx
Message-ID: <20240325163840.GF6245@nvidia.com>
References: <cover.1711377230.git.christophe.leroy@csgroup.eu>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1711377230.git.christophe.leroy@csgroup.eu>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?1+hPKn5mWK2Yl74bnnvCTvIQyQeKOa+BcxkVDT357pWQGUqTcLN59iGvf2NH?=
 =?us-ascii?Q?B9GIvyY16TTfoLRAyj3snRQ0ixmqCFAlV8jXgzLPR4370N/4JSQJ1t5cWoug?=
 =?us-ascii?Q?pU01nOHNavsW5Qm58JS2ygsFTnnwQYA2LMiYxGd6HGjQFvUuqDPCdl9iisO0?=
 =?us-ascii?Q?kbjFSEVXTHd3wYgShKPL+AyB/9GxqwJK/A+1fp6XdEvZOwQ2hB+j5JBI6vuc?=
 =?us-ascii?Q?jqhPTF15pvN+Egr/Z6Etb1j1hRyEfzX0SOG/H+qSoQUsKIEi2wi/WMxFIIaq?=
 =?us-ascii?Q?0ZlPOqAD/Z8D2qmdGKwQ+C+a80oM61ZB/Ih20glNwzlV0TKAGB8GKvewM63x?=
 =?us-ascii?Q?CI4BCTyqRtrtAC3YSnODBRb8ZiYeBDSt3umj1R1Obfo521NE3LzCsCOfyEQw?=
 =?us-ascii?Q?h+xUdn7dUCbVkVvC+pKdR2+7CXtYbDQo5iGkBBiYDGcQ/gtmzZu2wqvvsTEZ?=
 =?us-ascii?Q?wNvm0Jl9hCQcPlHUiR+Cr8LVwkzDknggeHGGYTthat6u6FLKxm56aKy5MbCU?=
 =?us-ascii?Q?mDe4l/g9gYPrq+giqLXvithYoNUjawBnyKwViQ0yrnATrGSXvApwLf9yI+G5?=
 =?us-ascii?Q?zrbxsklWfAFNJL5GxbJElz71KZEvyoTQoDSrKxrLpOTLH3L+DjKZcV5XD2qT?=
 =?us-ascii?Q?9LdyK39doMlxc2lfm9/4Edg9nBIQgf1xXGXDnVSWRE1rEObu7syaAejJhyAz?=
 =?us-ascii?Q?RetdcWOPte9hkCipLBhEn/gxLuPuZllMFV0LxXaz44bvMJA8RFAycJz00dad?=
 =?us-ascii?Q?REETqT4D6SDAExGqpAKG1rVU2ygD/SpdAxq5oFHEQyqpPhec2q72bPAKY6g8?=
 =?us-ascii?Q?MI+rC4B5gfCk2TTvexrWX/GMQRH9RPbZk9z89yzGiTaD3I0+tUbJs3sZCWNG?=
 =?us-ascii?Q?HWYvHorr55CcNmeaMLE9V9QWIqbr02KLgGqlGc1XlZAuLjjrlX7m/9uPrwsG?=
 =?us-ascii?Q?RI7u1Hbjdq3btzlb4ZRsPIMLOUySidoXjWcF4HbPeW0yb397wu1Djk2tl3Rx?=
 =?us-ascii?Q?6A1aMRmH2RDy/r+NqQ9WqdIx3vd72K4alujHzbE4/UZrXnv2bujicII/l3BD?=
 =?us-ascii?Q?3z8IQ8FMicWcd7yrSD2hipI0OmO10eXKJykeAqCn2EDGgKc42eFuEOkEfBF7?=
 =?us-ascii?Q?NN8C77VH67GwdpiIRsaI1p7rZNnPV2t4xXXb7BjlqvNOUTJQgaLlnlVVgJ7U?=
 =?us-ascii?Q?yEz2son9+kufOPJ0Y6z9nBuZ0rr4WptYyZkajFmEEqlDNYKKnU/2hb0k7sM1?=
 =?us-ascii?Q?DSLH9qwp1+2LiR5GpFLo3Bj/KO15eZA1aXef59EKQwzL0Ng1F7xJVapk50y6?=
 =?us-ascii?Q?/aJq07IOg9Z/hfuD6h5tZzmMf0LFj8tdjbnbdQMJwXvn6s0vyQgFd1OcZzdM?=
 =?us-ascii?Q?NH4e75s8cHhge++NWyjCMqjx2mELPNNtp3wDksmHPlMZod6tBCXNSucpA9RE?=
 =?us-ascii?Q?P6FY+hGYZGrFjj1LdB3fOHbUFZfy4YSUKOYNZ2jh21+6kZhiMnKpXq7Gy/gN?=
 =?us-ascii?Q?gnT3OeLzGnyFj2sBHJLC2HlndsGDNmuMux6nlE4ayqawRl+Ktx3eM/Ezqzvn?=
 =?us-ascii?Q?8GpIaH+qhclSfJQUh8F99ijoqw5QBYA7PcybCCXN?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 289052b2-4db8-46db-a232-08dc4cea078f
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2024 16:38:41.3510
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eB4dPbf7wxfJY+2W/EJ4HlZglZpJlVoBcaKn1vuv6Eitee0t6S4t/g1w8XRrWVv/
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6639

On Mon, Mar 25, 2024 at 03:55:53PM +0100, Christophe Leroy wrote:
> This series reimplements hugepages with hugepd on powerpc 8xx.
> 
> Unlike most architectures, powerpc 8xx HW requires a two-level
> pagetable topology for all page sizes. So a leaf PMD-contig approach
> is not feasible as such.
> 
> Possible sizes are 4k, 16k, 512k and 8M.
> 
> First level (PGD/PMD) covers 4M per entry. For 8M pages, two PMD entries
> must point to a single entry level-2 page table. Until now that was
> done using hugepd. This series changes it to use standard page tables
> where the entry is replicated 1024 times on each of the two pagetables
> refered by the two associated PMD entries for that 8M page.
> 
> At the moment it has to look into each helper to know if the
> hugepage ptep is a PTE or a PMD in order to know it is a 8M page or
> a lower size. I hope this can me handled by core-mm in the future.
> 
> There are probably several ways to implement stuff, so feedback is
> very welcome.

I thought it looks pretty good!

Thanks,
Jason