Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2842617lqp; Mon, 25 Mar 2024 10:43:38 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWP4eETiOBVqdEihwNq9J9qy7HySXJJJfGLRBBQoTPNvXdLsFr9ytftRYPteGkDb1D3JfIk7fUg4+kzSZEw2+FMETE956n7sib7dLS0Ww== X-Google-Smtp-Source: AGHT+IEM3d6STEqZw9lyiAucsDJuu3p2F3vItwCCGmieqELWWsE+htZ+cI4Vug9VauEHIJjd3Sdn X-Received: by 2002:ac2:5054:0:b0:513:c677:a400 with SMTP id a20-20020ac25054000000b00513c677a400mr4897946lfm.0.1711388618707; Mon, 25 Mar 2024 10:43:38 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711388618; cv=pass; d=google.com; s=arc-20160816; b=dezbaDZIpKo7SNehtdUU1TA54x9mttBWVqH+u5hGlQ9wDqlRrS941PQUX+a4tRGo1/ THsaPv6n1GnAVlJ0hrlHREE5jB521NM/jQOI+6wc8XrAoj/J0uflMoRkMniiJ5xfljiV egMxb7JWURRgvoVjGnmUOcCde9Fw1O5AWGAFBizdz9aEpFjxZiW3kh0bFRcdPkwOEq+A GW0DbymP0n1gY6dJh3XnzfNM+fjGMOGJ4q9HkURez+Mbrplxj83p3OItA4C/JO/eYpMp +9+fIM1xVPobMewmlFSU4FZeqpdw9KZ4X3XWRjqCW67HWyOxf8YReIYBnJxpUV4vHTva 0XUw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:references:in-reply-to:date:cc :to:from:subject:message-id:dkim-signature; bh=iqd5OHPf33Dh5alJMaoDDA/B+/g9AZhWz6dwwQoYzH0=; fh=o9FDWiZXhnH2tHHjX4IWyeiBnN6s8t9KBCkjGHeSNmI=; b=MaKyiWhyyj8BXJr6fOVt3brQxRUJvtszOkSOCz9459TVPC4I0siu8aTQGYj/6Q497J YZ+OZCfKSVm03Q/PdpLBsbG/1Bzjam/Z/aiHx6Wc/ZQCITYZ6SgGwklI8F8ba4RkYnhN NWdx1UkARLHXjbX+YpphGWUuk6Xhi93Knj+0+qj0CAYtz8XSud46ynxQbyOhpBVF36aC NQHZUIFLu3TZIYjDNRnoLywdx/UqvJ9pDGXHqroOuiLQrgfmZcslm+JLmUkMUgrDHcJC lDa61iHAgg7bv/hCIXEZFronn09n/89+QWouEWDeuBZJme9TJsv0Z+KRB3qam+BbsY1n 0K/g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=C1ida8Kw; arc=pass (i=1 spf=pass spfdomain=sipsolutions.net dkim=pass dkdomain=sipsolutions.net dmarc=pass fromdomain=sipsolutions.net); spf=pass (google.com: domain of linux-kernel+bounces-117508-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-117508-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id cb26-20020a0564020b7a00b0056b9c4821c2si2757592edb.459.2024.03.25.10.43.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 10:43:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-117508-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=C1ida8Kw; arc=pass (i=1 spf=pass spfdomain=sipsolutions.net dkim=pass dkdomain=sipsolutions.net dmarc=pass fromdomain=sipsolutions.net); spf=pass (google.com: domain of linux-kernel+bounces-117508-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-117508-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5EF9A1F3956E for ; Mon, 25 Mar 2024 17:43:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 89358129A90; Mon, 25 Mar 2024 16:48:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b="C1ida8Kw" Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C65198174F for ; Mon, 25 Mar 2024 16:48:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=168.119.38.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711385295; cv=none; b=pPvpLP7LO4KSyWreHHhnYf5ZWL1bQn2UiUoUT1ti+csZYczbtuqhgPDE1EzCWBxBl+uqTkfT3dcS8fccEh/6sgqvZ9fAcMuyKrO7BjVZNSFHwiFwD9FLSlmv/cHvMLbKxt88JliyQG3YPkaWrc4RyFd5rpTW+Y2OORS9UKrlNiQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711385295; c=relaxed/simple; bh=iqd5OHPf33Dh5alJMaoDDA/B+/g9AZhWz6dwwQoYzH0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=k7ujZSWXaQQVDbARljwzomZajp6zDHevgeYFPhuvAtL37OzS5H8HiNa8bgBmpYDd3SzLrHpd5aTzsp/urXeKHOJG5Hjw4jKNGVFTsLLkRBPGgGrQydiR85qJqdKXB/gaISTfVi8oh4J3wsYnnjrk2xIJvGibM6u1ZH2/HJifGHM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net; spf=pass smtp.mailfrom=sipsolutions.net; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b=C1ida8Kw; arc=none smtp.client-ip=168.119.38.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sipsolutions.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=iqd5OHPf33Dh5alJMaoDDA/B+/g9AZhWz6dwwQoYzH0=; t=1711385293; x=1712594893; b=C1ida8KwueC/hP9xiuLNV5EyVATbTgMKjQWz7O8yOpSIcmy X4DJR2x55vgyTX1Ifxqn4oti/I60HvZxtI3GL+T3R2CkGGf+kUKD2nyGneXxi6N9259HfvTkwu4Rx RV7FzmF4e9EDT1mITDOrqF1U2EfiHsd3E021BaCNg9HZqrXeEvwNd6HqrEJG46T99rXLakUsbvnMk 0TGGGeKZeT354QTTLSh8Nsd2U9leQPJHU2QM7w+najst7113yhUIWVqrIWvYW04+dOzwoHdMBmxXM m+vgN6dxNZRwVIo3kZsLocUYeWERtYSxQAYS73F/VN6tIpXtSobr+lQFMVyV9VMA==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97) (envelope-from ) id 1ronUY-0000000DxcA-1M7f; Mon, 25 Mar 2024 17:48:10 +0100 Message-ID: <4aa1f6ae3ac72a5eb3303740242d53d46a338d6b.camel@sipsolutions.net> Subject: Re: [PATCH v3 1/4] devcoredump: Add dev_coredump_put() From: Johannes Berg To: =?ISO-8859-1?Q?Jos=E9?= Roberto de Souza , linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org Cc: Rodrigo Vivi , Mukesh Ojha , Jonathan Cavitt Date: Mon, 25 Mar 2024 17:48:09 +0100 In-Reply-To: <20240304143905.52740-1-jose.souza@intel.com> References: <20240304143905.52740-1-jose.souza@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-malware-bazaar: not-scanned On Mon, 2024-03-04 at 06:39 -0800, Jos=C3=A9 Roberto de Souza wrote: > It is useful for modules that do not want to keep coredump available > after its unload. Why not though? Maybe if this is a common case we should have devm_... coredump functions? Dunno. Anyway, I'm fine with this, even though I'd like to see a bit more discussion than "do not want". Code looks good. Reviewed-by: Johannes Berg johannes