Received-SPF: pass (google.com: domain of linux-kernel+bounces-117030-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
To: Su Hui <suhui@nfschina.com>, Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Hariprasad Kelam
	<hkelam@marvell.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org"
	<kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "nathan@kernel.org" <nathan@kernel.org>,
        "ndesaulniers@google.com"
	<ndesaulniers@google.com>,
        "morbo@google.com" <morbo@google.com>,
        "justinstitt@google.com" <justinstitt@google.com>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "llvm@lists.linux.dev" <llvm@lists.linux.dev>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: RE: [EXTERNAL] [PATCH 2/2] octeontx2-pf: remove unused variables
 req_hdr and rsp_hdr
Thread-Topic: [EXTERNAL] [PATCH 2/2] octeontx2-pf: remove unused variables
 req_hdr and rsp_hdr
Thread-Index: AQHafocf78zPvIoQlUeZgrhxSP5MI7FIZsYg
Date: Mon, 25 Mar 2024 12:44:44 +0000
Message-ID: 
 <CO1PR18MB466675E232FA99415D766F68A1362@CO1PR18MB4666.namprd18.prod.outlook.com>
References: <20240325073549.823832-1-suhui@nfschina.com>
 <20240325073549.823832-2-suhui@nfschina.com>
In-Reply-To: <20240325073549.823832-2-suhui@nfschina.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?I6SekxjjCyfpSx9/L1CZMNb11pj4fUKTT+/IkIubtA/QP01Gb1qSIH7UY2pW?=
 =?us-ascii?Q?Jvn6JuofNnNe1hmQo5dCJo3nOIrpdF4pu6uO235Llm5qKdCwYXJ6bknqqA0O?=
 =?us-ascii?Q?xhid/ZepJLKjK45gja0c9dIW+B6EyOIYT0rgRX72qJfFzfDMHnYjBi++KIEv?=
 =?us-ascii?Q?wY/brkOVnzACFV3iPNZkVcEA31LA4YGWQOtRUGWrnO1LFRBj82CHJgZcD/Ec?=
 =?us-ascii?Q?b4tNfEU/LD+7FqfdAqxe9hEoUG6XUyxfYZ+ruD5++/SeL11ZrYMLrpDBagWY?=
 =?us-ascii?Q?IO3lqQs3dESk60ETGJFVIoDO5bYi5rr50uYQ20Pa72qcrMPkz5gZSVcf5GOt?=
 =?us-ascii?Q?1YhPWCjF7tkvJKoKTRILc4zjcM1KEeKziYYGrfK6ASgJTG1sJe+45H1R4yZW?=
 =?us-ascii?Q?hN1G7m2hKI/pi4UwOWRrTJZ92ApFafg1StvN26Cgbj5Ks0C8M+Ul/nNhm+sM?=
 =?us-ascii?Q?1bcXG/esscefyeeKwgHzwMRTKDy36baOZkgOtMIvFFzA68LMFq/qWgagR70T?=
 =?us-ascii?Q?tM49hpR0H7Umdx2n0VH3wsBI+PHqalblfJWC6mCi4AktigFUUAJ6M0JyMz5q?=
 =?us-ascii?Q?vX3FIZ6xr88SzVJm4tZpHhCR+xwCtk8aNh0qkz3SWHuq0mnc0v2CcUdt2lfW?=
 =?us-ascii?Q?GeUboI/QR3lzr2Nny7lv+OZM2BoFAAw3vgoc4iRqiYNZTWv9lcowyPPdert6?=
 =?us-ascii?Q?qE7QgohJ3aPUH3RUzfaMMFbHdopO8GKb0SmUk5QCcyalOUOpg/Y9bc1FZ7on?=
 =?us-ascii?Q?JUPt0Chs5qZLY7FI5MHAjRD9WBCJYy1fPFecKOn/WDZdT5/YbgWN39BP61GC?=
 =?us-ascii?Q?Iv1T9slm1+mDiMo1SGglpW7HKQ6lZ08m5bZvkvDxYM1APwP9nb+A/EQYYkYu?=
 =?us-ascii?Q?7NVOO8muE9yySyoZMLtS/lojVloaD3TF/fdaUBshdA8nrjtFSVTa0x7LlNyn?=
 =?us-ascii?Q?J/MxRVm4/UB1IyONHi0mymtdUOvZwIZScPWqeXoJcvWNmZdmndTh+4UOlMSg?=
 =?us-ascii?Q?fQxp42qkqvRDfTDhYkBRzPUuTi/mSEwliK+EqQmQbxbadqhYXL2Nf7eWwPXS?=
 =?us-ascii?Q?K7PFvzmeftD3oi4rd0Ub87c6FRcL0BrSon1PKpYc/D4aIGWrTgAfT9fEGGUH?=
 =?us-ascii?Q?8amiyZplKir7CYXh9VxyNPrk+M6SfxP9XCNdoRsW1uKis267xAp8+iC+XE+O?=
 =?us-ascii?Q?Zn2Fb139KyapiL0PeDRk18lL+sbjPdQiIUp37EJnDpfxoC7suKPXcK65lB08?=
 =?us-ascii?Q?UZ00MWaLp1/+17S8i3n0Ift2iT3ECT9iE9B25gNaDCP1zMUDGQeh53HEB1nf?=
 =?us-ascii?Q?REIroaDCGSeREqmTtVMs/+3gC3Ll9kru1seQ2V2RwEQs4jmJN6+mQ4NyIOjS?=
 =?us-ascii?Q?xiZHudfxdSr7Qgnoyf/7BCiimjtd/unXu9kpGDbmgXx05uy4NMX1TlrXVR4K?=
 =?us-ascii?Q?XqtQKDxKdEZvyq96yjkXmolyMsgb1VqOVBdfodXAE4pTUn13XwXP6fRgDRSm?=
 =?us-ascii?Q?biAXDRFeB6K3qjh+mswE94Q0y4xTbkcyO2+phtyKK3HnSHnwHR2Ies9VvA?=
 =?us-ascii?Q?=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR18MB4666.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c40ca516-c6da-4b72-913a-08dc4cc958cd
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2024 12:44:44.1300
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +ExFDZN/crwUVsOVhjcXPUxWWiDpitW8l+URUosXJFidjZ81It27Nuv1uWXeQcAi9UqRD4GRqPSIKrujLJLQjg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR18MB6094
X-Proofpoint-GUID: qcN6x61j4SekXdjO-AfvbLUS4zgtGHiI
X-Proofpoint-ORIG-GUID: qcN6x61j4SekXdjO-AfvbLUS4zgtGHiI
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-25_08,2024-03-21_02,2023-05-22_02

Hi,

>-----Original Message-----
>From: Su Hui <suhui@nfschina.com>
>Sent: Monday, March 25, 2024 1:06 PM
>To: Sunil Kovvuri Goutham <sgoutham@marvell.com>; Geethasowjanya Akula
><gakula@marvell.com>; Subbaraya Sundeep Bhatta <sbhatta@marvell.com>;
>Hariprasad Kelam <hkelam@marvell.com>; davem@davemloft.net;
>edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
>nathan@kernel.org; ndesaulniers@google.com; morbo@google.com;
>justinstitt@google.com
>Cc: Su Hui <suhui@nfschina.com>; netdev@vger.kernel.org; linux-
>kernel@vger.kernel.org; llvm@lists.linux.dev; kernel-janitors@vger.kernel.=
org
>Subject: [PATCH 2/2] octeontx2-pf: remove unused variables
>req_hdr and rsp_hdr
>
>Clang static checker(scan-buid):
>drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:503:2: warning:
>Value stored to 'rsp_hdr' is never read [deadcode.DeadStores]
>
Consider this also as a fix and add Fixes tag. Also please add "net" in sub=
ject to
easily identify whether this patch as net or net-next material.

Thanks,
Sundeep

>Remove these unused variables to save some space.
>
>Signed-off-by: Su Hui <suhui@nfschina.com>
>---
> drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
>diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
>b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
>index 3f46d5e0fb2e..637b05c79c42 100644
>--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
>+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
>@@ -450,7 +450,6 @@ static void otx2_pfvf_mbox_handler(struct
>work_struct *work)
> 	struct mbox_msghdr *msg =3D NULL;
> 	int offset, vf_idx, id, err;
> 	struct otx2_mbox_dev *mdev;
>-	struct mbox_hdr *req_hdr;
> 	struct otx2_mbox *mbox;
> 	struct mbox *vf_mbox;
> 	struct otx2_nic *pf;
>@@ -461,9 +460,8 @@ static void otx2_pfvf_mbox_handler(struct
>work_struct *work)
>
> 	mbox =3D &pf->mbox_pfvf[0].mbox;
> 	mdev =3D &mbox->dev[vf_idx];
>-	req_hdr =3D (struct mbox_hdr *)(mdev->mbase + mbox->rx_start);
>
>-	offset =3D ALIGN(sizeof(*req_hdr), MBOX_MSG_ALIGN);
>+	offset =3D ALIGN(sizeof(struct mbox_hdr), MBOX_MSG_ALIGN);
>
> 	for (id =3D 0; id < vf_mbox->num_msgs; id++) {
> 		msg =3D (struct mbox_msghdr *)(mdev->mbase + mbox->rx_start
>+
>@@ -494,7 +492,6 @@ static void otx2_pfvf_mbox_up_handler(struct
>work_struct *work)
> 	struct otx2_nic *pf =3D vf_mbox->pfvf;
> 	struct otx2_mbox_dev *mdev;
> 	int offset, id, vf_idx =3D 0;
>-	struct mbox_hdr *rsp_hdr;
> 	struct mbox_msghdr *msg;
> 	struct otx2_mbox *mbox;
>
>@@ -502,8 +499,7 @@ static void otx2_pfvf_mbox_up_handler(struct
>work_struct *work)
> 	mbox =3D &pf->mbox_pfvf[0].mbox_up;
> 	mdev =3D &mbox->dev[vf_idx];
>
>-	rsp_hdr =3D (struct mbox_hdr *)(mdev->mbase + mbox->rx_start);
>-	offset =3D mbox->rx_start + ALIGN(sizeof(*rsp_hdr),
>MBOX_MSG_ALIGN);
>+	offset =3D mbox->rx_start + ALIGN(sizeof(struct mbox_hdr),
>MBOX_MSG_ALIGN);
>
> 	for (id =3D 0; id < vf_mbox->up_num_msgs; id++) {
> 		msg =3D mdev->mbase + offset;
>--
>2.30.2