Received-SPF: pass (google.com: domain of linux-kernel+bounces-117750-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 25 Mar 2024 11:53:08 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Yajun Deng <yajun.deng@linux.dev>
Cc: Liam.Howlett@oracle.com, vbabka@suse.cz, lstoakes@gmail.com,
 linux-mm@kvack.org, linux-kernel@vger.kernel.org, Helge Deller
 <deller@gmx.de>
Subject: Re: [PATCH v2 RESEND] mm/mmap: convert all mas except mas_detach to
 vma iterator
Message-Id: <20240325115308.f6344233a27f1633f642f888@linux-foundation.org>
In-Reply-To: <20240325063258.1437618-1-yajun.deng@linux.dev>
References: <20240325063258.1437618-1-yajun.deng@linux.dev>
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 25 Mar 2024 14:32:58 +0800 Yajun Deng <yajun.deng@linux.dev> wrote:

> There are two types of iterators mas and vmi in the current code. If the
> maple tree comes from the mm structure, we can use the vma iterator. Avoid
> using mas directly as possible.
> 
> Keep using mas for the mt_detach tree, since it doesn't come from the mm
> structure.
> 
> Remove as many uses of mas as possible, but we will still have a few that
> must be passed through in unmap_vmas() and free_pgtables().
> 
> Also introduce vma_iter_reset, vma_iter_{prev, next}_range_limit and
> vma_iter_area_{lowest, highest} helper functions for using the vma
> interator.
> 

I assume Liam's earlier request still applies?

: Helge,
: 
: Yajun has changed code that affects parisc with this patch, which hasn't
: been tested.
: 
: ...
: 
: Can you make sure that the expand_upwards() still functions on parisc?