Received-SPF: pass (google.com: domain of linux-kernel+bounces-117801-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Sender: Tejun Heo <htejun@gmail.com>
Date: Mon, 25 Mar 2024 09:19:35 -1000
From: Tejun Heo <tj@kernel.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] workqueue: Cleanup subsys attribute registration
Message-ID: <ZgHOR3BA2ui5zvVH@slm.duckdns.org>
References: <170987627011.449367.8705596691078598981.stgit@dwillia2-xfh.jf.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <170987627011.449367.8705596691078598981.stgit@dwillia2-xfh.jf.intel.com>

On Thu, Mar 07, 2024 at 09:39:32PM -0800, Dan Williams wrote:
> While reviewing users of subsys_virtual_register() I noticed that
> wq_sysfs_init() ignores the @groups argument. This looks like a
> historical artifact as the original wq_subsys only had one attribute to
> register.
> 
> On the way to building up an @groups argument to pass to
> subsys_virtual_register() a few more cleanups fell out:
> 
> * Use DEVICE_ATTR_RO() and DEVICE_ATTR_RW() for
>   cpumask_{isolated,requested} and cpumask respectively. Rename the
>   @show and @store methods accordingly.
> 
> * Co-locate the attribute definition with the methods. This required
>   moving wq_unbound_cpumask_show down next to wq_unbound_cpumask_store
>   (renamed to cpumask_show() and cpumask_store())
> 
> * Use ATTRIBUTE_GROUPS() to skip some boilerplate declarations
> 
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Lai Jiangshan <jiangshanlai@gmail.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> Hi Tejun, just a drive-by cleanup while poking around sysfs.

Applied to wq/for-6.10. Thank you so much.

-- 
tejun