Received-SPF: pass (google.com: domain of linux-kernel+bounces-117875-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 25 Mar 2024 14:57:59 -0500
From: John Allen <john.allen@amd.com>
To: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: bp@alien8.de, linux-edac@vger.kernel.org, tony.luck@intel.com,
	linux-kernel@vger.kernel.org, avadhut.naik@amd.com,
	muralidhara.mk@amd.com
Subject: Re: [PATCH 3/4] RAS: ATL: Add map_bits_valid to header
Message-ID: <ZgHXR8O7CIoOmfvM@AUS-L1-JOHALLEN.amd.com>
References: <20240314163527.63321-1-john.allen@amd.com>
 <20240314163527.63321-4-john.allen@amd.com>
 <893141c6-41f8-415a-a1a3-d3e4267ec333@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <893141c6-41f8-415a-a1a3-d3e4267ec333@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Kx/6VafgQsGVsTrb4QdF9DjlGCtlXfoj4BHgepTTC7aGl+0Nst6BR1K8UVRn?=
 =?us-ascii?Q?Htupwe6jg1A9LQlQCpAdEIu78R4cAXsfZUYp+xvVGlvmlo6qxdlALJ0Qxjcu?=
 =?us-ascii?Q?B7TqsCwzX0BdxXoiGUMJ1F9Z5+yxXDPa4hjxYZITWuUYKQlsJfU4Shilum51?=
 =?us-ascii?Q?pnessb/tovN4vm5XWTOJRxkDRRriw0goB7zsS5H0mNm63zp+c2ixUXEEytbg?=
 =?us-ascii?Q?XeaN68wvuA++jugUj3NBBMp2f3YGXSGyojy6emULJeKFzQkXjU+7kPLUG7ii?=
 =?us-ascii?Q?u+TjtSsehdpBCLa6AkLyGEV0Rhl4b6VoCAG6LyZrm8qFwAZmbpej7l22CIX1?=
 =?us-ascii?Q?5OJbpKoiYGJuvO7sTYRFuzvfop3YqyP6r/ai8eUi2xqKfQiPvVk5j+bHqyaf?=
 =?us-ascii?Q?iHGAjsGSCG1ntkQnpbrDeIjfiSQK2PqxgX7g6oqgrJa0Vsfkw8LAtdlJ3afJ?=
 =?us-ascii?Q?n/tQdtpVBdJHU0xNnXU/RaxqtEGldeFxUiGjCuu8k3El2xeAi76/LjF7jXGe?=
 =?us-ascii?Q?q18GZHKhIo1YZQoCaaXQzcI2QsDBoCut+/YcTvpMW4fB5Vy3J49Y9H0FjDKw?=
 =?us-ascii?Q?ubpcZGggvCF1XpKzqV7GnZ04gmmlV+dNhN9T6QS5+PBh00NzEYI4XIPTlLt8?=
 =?us-ascii?Q?i2pJ68hwj3BYpUacb94ll8CHXTrXZufpIZQQEKdc8wMkfdoMTPTvZvYjHqfs?=
 =?us-ascii?Q?ol9PSFCkQ07jkFphsOtJ5qSu+AaC0W+RkPHzl+0Z5srgx3w+YUKyyZ06cvCI?=
 =?us-ascii?Q?TtnqoZW437NlCIyIzZhnusk7d591NXnxQMiv1xbbsLNMQGlnKFKOf6wiIEoP?=
 =?us-ascii?Q?r2dhQ8kOnibDp2hrHAU3m+pq1B3Jr5o2S2alxb7/d3YMuhlz2xsfLVA/+GUz?=
 =?us-ascii?Q?OOH0vzhgh9XbmHi+OPL09gpcKc+hZfbm25ilw47iqdCnZL+mlS9EDCLwXo9O?=
 =?us-ascii?Q?5xB9r0XNPmy5ou/bxbOk4OHHCEqEPHdcKP4pBPzlpUa7n69GdYNjumIYyHuX?=
 =?us-ascii?Q?z90LY7p2J4h19JRlIxLYwNBRG0ll2K/YA+Q72LkUKpz7RAKa4n/LJ/4lPtpQ?=
 =?us-ascii?Q?4/scG/uKcVhpIxr2H2YpG3fBQyyrL6QH/LXunYFv0A3I/CfxAWjy/MevvJbq?=
 =?us-ascii?Q?RS3eD6bY0JGZVeo+0IA18gpGKYYl5sWlNogeLkXuF2N8iO4rdRB4VACGVeM0?=
 =?us-ascii?Q?0d23+NYE+nd9PYG90XfEVDhKIJyCUbGJuFaFQ5Y7DQ7ShCQMYFry52UbERjc?=
 =?us-ascii?Q?WkP4GUfUS3S16KPQtCWfuLQsDo1k91P0z5BEEhFm4TU3Zubhm4fmoe07Fv/t?=
 =?us-ascii?Q?WR8oAXQV/LeSHLUXacGecWQsj+olJxMSeT1xG6/PUx98qUlEbFa71Vt0FrEj?=
 =?us-ascii?Q?2pw598Ml7ceWZg6PKGxq2Nusd0JCNiQ2qmPotxgw0rjbEEBaYI9JE8YZanEZ?=
 =?us-ascii?Q?5WDfB3aSQ4qUEZrJaOAj0emhDOuanyHnQh5uhqbVAupfzchusJfaM+XMw0nZ?=
 =?us-ascii?Q?apVqMK0i0Hl3XWInoR/3mVZlI3GE3AKcE85LikcMSeocGbBRHQ5GZNaE0UNh?=
 =?us-ascii?Q?kq4iF+2TxLJwqjNXvAr6C9ib2N/Z5XtCA1N5RTDu?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ba43286-95be-4466-40a1-08dc4d05e402
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5995.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2024 19:58:07.6896
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rCYqNsiUuJNEOgNS2G1vEWKPrroGzEW+LqNK4O2bjDID2P5pNmDuJPSO/dDgjxW6PamaAtoYftszahldRZCoig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4468

On Mon, Mar 18, 2024 at 11:46:39AM -0400, Yazen Ghannam wrote:
> On 3/14/24 12:35, John Allen wrote:
> > Make map_bits_valid available in the AMD ATL internal header as the
> > function can be used in other parts of the library.
> > 
> > Signed-off-by: John Allen <john.allen@amd.com>
> > ---
> >   drivers/ras/amd/atl/dehash.c   | 2 +-
> >   drivers/ras/amd/atl/internal.h | 3 +++
> >   2 files changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/ras/amd/atl/dehash.c b/drivers/ras/amd/atl/dehash.c
> > index 4ea46262c4f5..a20cf615b83a 100644
> > --- a/drivers/ras/amd/atl/dehash.c
> > +++ b/drivers/ras/amd/atl/dehash.c
> > @@ -19,7 +19,7 @@
> >    * If @num_intlv_dies and/or @num_intlv_sockets are 1, it means the
> >    * respective interleaving is disabled.
> >    */
> > -static inline bool map_bits_valid(struct addr_ctx *ctx, u8 bit1, u8 bit2,
> > +inline bool map_bits_valid(struct addr_ctx *ctx, u8 bit1, u8 bit2,
> >   				  u8 num_intlv_dies, u8 num_intlv_sockets)
> >   {
> >   	if (!(ctx->map.intlv_bit_pos == bit1 || ctx->map.intlv_bit_pos == bit2)) {
> > diff --git a/drivers/ras/amd/atl/internal.h b/drivers/ras/amd/atl/internal.h
> > index 05b870fcb24e..4681449321de 100644
> > --- a/drivers/ras/amd/atl/internal.h
> > +++ b/drivers/ras/amd/atl/internal.h
> > @@ -239,6 +239,9 @@ unsigned long convert_umc_mca_addr_to_sys_addr(struct atl_err *err);
> >   u64 add_base_and_hole(struct addr_ctx *ctx, u64 addr);
> >   u64 remove_base_and_hole(struct addr_ctx *ctx, u64 addr);
> > +inline bool map_bits_valid(struct addr_ctx *ctx, u8 bit1, u8 bit2,
> > +			   u8 num_intlv_dies, u8 num_intlv_sockets);
> > +
> >   /*
> >    * Make a gap in @data that is @num_bits long starting at @bit_num.
> >    * e.g. data		= 11111111'b
> 
> Ultimately, the maps should be validated as soon as they are gathered. I
> figured we would do that later. But that would wipe out this change.
> And, after looking at dehash.c again, map_bits_valid() isn't used in too
> many places right now.
> 
> So I think validate_address_map() from the following patch should be
> done for all modes first. That way we don't need to add and then remove
> this function from the header.

I'm not sure I understand. Are you saying that we should just move the
map_bits_valid function to map.c and then make the map_bits_valid calls
that are currently in dehash.c to validate_address_map?

Thanks,
John