Received-SPF: pass (google.com: domain of linux-kernel+bounces-117879-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <b9a8c258-94d4-4c09-8211-31466cdfca7b@gmx.de>
Date: Mon, 25 Mar 2024 21:01:31 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 0/2] platform/x86: Add ACPI quickstart button driver
To: Hans de Goede <hdegoede@redhat.com>, dennisn@dennisn.mooo.com,
 lkml@vorpal.se, ilpo.jarvinen@linux.intel.com
Cc: coproscefalo@gmail.com, platform-driver-x86@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240131111641.4418-1-W_Armin@gmx.de>
 <c1b08bbb-ad57-4f41-9b7b-40a6aeb3da9b@redhat.com>
Content-Language: en-US
From: Armin Wolf <W_Armin@gmx.de>
In-Reply-To: <c1b08bbb-ad57-4f41-9b7b-40a6aeb3da9b@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
UI-OutboundReport: notjunk:1;M01:P0:VVggtnWfhlA=;9csI6wvmgHmZnfVAKKe4OyBqGX3
 0ode2c97zmCcRXW5YuU/Z849v4ExT57EQ2vj3HfCr+335zgKxeC2XHReIGJl3dFHuFdcIUthi
 5b3KvE9MPuBuoOTxVLE2ImoGuPOQ8rDpihfbkjsNqCNXehIGCxIUPKcuCIA1eXvgsEgAvDKNu
 nojdA/dXy7JWqD8hbCB3vYpUfxCBAx7CthM4ITmO40cu/P8jjyKS71VgqbsnzJ6EFhTP6TEH0
 iHndBleszoLd+KzcUlzWqYEp7GL4bhVnL8PU8ENyA1Q29GFmEoIK+fWP0zYzLl4DHe3ICoyp6
 r+2K3bozDVdV+t+Ak6RD0pYLG2sB10vPVeL8cV4ianloIJBhoGLOFEktwCoVSMFH4/obnztZT
 L7hkmhBsJ2lWQ4n/zY0wXQfOlgZedbpdg2SsRYtg3YKV9NdjtdI+87moBzV19KUA1a8c6iOjo
 JQUo95a/GQncumRCOlxsLX8/iQvThhwVDORJuVwItfrcWdwWZ1bFjsa8ByIubF10TCzSC7O+y
 lF3dB/jPxto2KjFxXeM5JFQ91njVoeWpX+6UoR0sCX+Wk8IDKEw/TA1XOVWWJdcQFsoizocB5
 F6XPhG57zyvlLiO7tcsUk2sc5nyf3oSqOHfwTUvBnEzXazcZAAs0RjmyeIdF1HVryxP2aRbHY
 YLie+y4aFM6IHwPjneC496zqCf2MVlAJr4BUCzO4E83kAtSHVAWnbGWFecgtWhvzIkDBTW8gX
 IK9b5GomVkJc+th7n1XmydOEOSO9+NJF5YwnMIkW7BjoxizVsN1EnReyWuCtElQbCIRe+gVLr
 aPw0dhqI/fZgFBr8F2vUrKyAVkGBISEU6OP0z43cY5pzc=

Am 24.03.24 um 15:55 schrieb Hans de Goede:

> Hi Armin and Arvid,
>
> On 1/31/24 12:16 PM, Armin Wolf wrote:
>> This patch series adds support for the ACPI PNP0C32 device as
>> proposed in 2022 by Arvid Norlander. The first patch adds support
>> for the device itself, while the second patch was taken from the
>> original series.
>>
>> Both patches are compile-tested only.
> Armin, thank you for creating a new cleaned up driver for the
> quickstart button support.
>
> I have managed to get my hands on a Toshiba Portege Z830 and
> I have successfully tested this series. That is this makes
> the 2 quickstart application and the toggle-touchpad button
> work when the system is running normally.
>
> Neither the quickstart buttons, nor the touchpad-toggle button
> which also uses the PNP0C32 interface, work to wakeup
> the system from sleep though.
>
> I've also review both patches and they look good to me:
>
> Tested-by: Hans de Goede <hdegoede@redhat.com>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> So I plan to merge this series into pdx86/for-next once
> 6.9-rc1 is out.
>
> Regards,
>
> Hans
>
Hi,

great to hear that the driver works. Can you send me the output of "acpidump" on this machine?
Maybe the quickstart buttons have no wake capabilities?

Thanks,
Armin Wolf

>> Armin Wolf (1):
>>    platform/x86: Add ACPI quickstart button (PNP0C32) driver
>>
>> Arvid Norlander (1):
>>    platform/x86: toshiba_acpi: Add quirk for buttons on Z830
>>
>>   MAINTAINERS                         |   6 +
>>   drivers/platform/x86/Kconfig        |  13 ++
>>   drivers/platform/x86/Makefile       |   3 +
>>   drivers/platform/x86/quickstart.c   | 225 ++++++++++++++++++++++++++++
>>   drivers/platform/x86/toshiba_acpi.c |  36 ++++-
>>   5 files changed, 280 insertions(+), 3 deletions(-)
>>   create mode 100644 drivers/platform/x86/quickstart.c
>>
>> --
>> 2.39.2
>>
>>
>