Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2925438lqp; Mon, 25 Mar 2024 13:16:43 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW6cihiLtG6bdgjEr6+HAvSuOvIVLrrF4p2x6jTKQXDNcJAS6vJzlucVsw3NTUTXlbGNq0BoGUXezX1ixfIBLxn7sx7EeE889K9fN73AQ== X-Google-Smtp-Source: AGHT+IHs9suBHKETjdd0VzQl29LoTojnb9+Jo08T48gkfDs90hRRtcVx5gZrI/DJXIZJr6FRVGlP X-Received: by 2002:a05:6a20:7fa1:b0:1a3:4fd2:a8c0 with SMTP id d33-20020a056a207fa100b001a34fd2a8c0mr10623163pzj.48.1711397803042; Mon, 25 Mar 2024 13:16:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711397803; cv=pass; d=google.com; s=arc-20160816; b=0qsHvHT79eOao5ciDsszF9NMsv4ha4FxmufuTMcKNLIfqswucnfH06Adrw6bWdXAcG b/AyvIsXGQ+dwm6MM1KEt4wgdbffdziZDnL14ZhxlA9e2zjfm79tGZJoMfLho6XyVL+p q9EhyPUHg+Qc68PPegwbGQ+Ii67Pfj1/LDUUB4l23qQkmzImM5c8UvM5Wg+++rszrRjh R5P6rmgLgydjFnvdGxexanemV1KAPPFaNLV8Tlz71C/xR6Ey0bvI0qHWZ/Uyklurnuzd tCbY+HpLI7FqllfSu5lzJKQK/aTM6jgQh+5YLuvD2xRHVudLXW65d1AIT1XwvFSGqbXF xlWg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=MC9YYvGBYzBV4Fv6C5L0vdE+MTP7SoAzS+XZsq9EO5I=; fh=lPDHyWDhTZBRy+3zzm/VgTLa7bM2Muotk+U3z8XW/+4=; b=zuO0cGb6CirRuQsWk2tqNPcIFioCccZ0/evIrURYYO7JCU0oaUm/AzIPpeg6Pc9BI4 BgBPwLS73X3icT7RuVBZlGDjyPzranpuhpZp/GvSnZzCdmmUttu901QIV7bNqrtUJO/n +r81IylwQFn5z8HtummG1JDeekW3Xu43J4/anCCj6vY00em6tYdw6IcUh5oXrw4+XHVP jF6Tze0lfIZnkeNs/g6+smO9keDnMsEbrH7XJzcG0w789T6avJw13QmwFIv1M6BBy00l mjlx66qlf3sSp+Z2IPvjEAY3bdCka/4afyTQ6c66SVr7KG5P1609MqXtF1QslWB8yxYW lWXQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZrtE7cN0; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-117907-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-117907-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id j11-20020a65430b000000b005dc85a7bfe6si8053985pgq.109.2024.03.25.13.16.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 13:16:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-117907-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZrtE7cN0; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-117907-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-117907-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B7D0E301878 for ; Mon, 25 Mar 2024 20:16:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 296ED51C2B; Mon, 25 Mar 2024 20:14:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZrtE7cN0" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4605612E47; Mon, 25 Mar 2024 20:14:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711397687; cv=none; b=pUvyQoW6zYQ6UZWJ4I/z/M5MenpJvloWiBc3gh6WO6J70wW4qpsn/kTLvAY+LqlLPq3ePDbZP2HwDwXk3fdITfCz/+MM/OC5tNTGqtPO0QTdMexE+jZYs0qM+RCJKlrttjiyfZ3B2toLhPyblpr9X4Rvki66wOrS0nCMOdm4/Zw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711397687; c=relaxed/simple; bh=zVzMdPH5x8S0kvUHOTov9W0NIu59GLtknLzc50ShHxQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SyjcNThBY9C3h30q3WnGBr+LxIfqzXbHX45EKjO/L6VO0xR0XcGPC2moFYh+cQQq2WW0/6xFmuFa0xIifiFD7XSahyWsvaP7gH5zOUKnpNHxNl+v7dTc038uDj/Nfu3MRKp4v4GEIfn/ZdB9qObJmdtbDAxQYR/A+Xr8GXY6cTQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZrtE7cN0; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA11AC433C7; Mon, 25 Mar 2024 20:14:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711397686; bh=zVzMdPH5x8S0kvUHOTov9W0NIu59GLtknLzc50ShHxQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZrtE7cN0Onv431Oxd3DmFgzn+O3PToH8vmAvSNGMNV6O2Q0oAGNjTJQeZXS4BDQzX nJpbglY646QwSUDaR6Qw6vnJupO5JnJnWsbIpiyThMaEcv3p/e4+UUzv9L5C8kgIwP QRRDCadDwOjueWAnOfKCH+SxuMxhn3G8TBgPPityvuSpnPTz1fRoaUfSvJ/j97iRGn 52dDC2ZvgRkp4hLFf1gyKcFm0RI5fyDArYiV0ZvnuC/+Ce/v9huRzqFMj0GETjl6De A/w4mXqQ301fosRKGQeqK04OdiqM7kiElzRZmvj9LcrnkQuY91KX7uQR3VrAyqdOIH CBfYZGSvybvow== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1roqic-000000004Wt-420I; Mon, 25 Mar 2024 21:14:55 +0100 Date: Mon, 25 Mar 2024 21:14:54 +0100 From: Johan Hovold To: Luiz Augusto von Dentz Cc: Linux regressions mailing list , Johan Hovold , Marcel Holtmann , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Janaki Ramaiah Thota Subject: Re: [PATCH] Revert "Bluetooth: hci_qca: Set BDA quirk bit if fwnode exists in DT" Message-ID: References: <20240314084412.1127-1-johan+linaro@kernel.org> <964131ff-293d-47d1-8119-a389fa21f385@leemhuis.info> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Mar 25, 2024 at 04:07:03PM -0400, Luiz Augusto von Dentz wrote: > On Mon, Mar 25, 2024 at 3:48 PM Johan Hovold wrote: > > On Mon, Mar 25, 2024 at 03:39:03PM -0400, Luiz Augusto von Dentz wrote: > > > On Mon, Mar 25, 2024 at 1:24 PM Johan Hovold wrote: > > > > On Mon, Mar 25, 2024 at 01:10:13PM -0400, Luiz Augusto von Dentz wrote: > > > > > > > I guess the following is the latest version: > > > > > > > > > > https://patchwork.kernel.org/project/bluetooth/list/?series=836664 > > > > > > > > > > Or are you working on a v5? > > > > > > > > This patch (revert) fixes a separate issue than the series you link to > > > > above, but it is also a prerequisite for that series. > > > > > > > > v4 is indeed the latest version, and it has been acked by Rob and Bjorn > > > > so you can take it all through the Bluetooth tree. Just remember to > > > > apply this patch (the revert) first. > > > > > > Doesn't seem to apply cleanly: > > > > > > Applying: Bluetooth: qca: fix device-address endianness > > > error: patch failed: drivers/bluetooth/hci_qca.c:1904 > > > error: drivers/bluetooth/hci_qca.c: patch does not apply > > > Patch failed at 0004 Bluetooth: qca: fix device-address endianness > > > > Did you apply this patch (the revert) before trying to apply the series? > > Probably needs rebasing: > > Applying: Revert "Bluetooth: hci_qca: Set BDA quirk bit if fwnode exists in DT" > error: drivers/bluetooth/hci_qca.c: does not match index > Patch failed at 0001 Revert "Bluetooth: hci_qca: Set BDA quirk bit if > fwnode exists in DT" I just verified that it applies cleanly to 6.9-rc1. $ git checkout tmp v6.9-rc1 $ b4 am -sl ZgHVFjAZ1uqEiUa2@hovoldconsulting.com ... $ git am ./20240314_johan_linaro_revert_bluetooth_hci_qca_set_bda_quirk_bit_if_fwnode_exists_in_dt.mbx Applying: Revert "Bluetooth: hci_qca: Set BDA quirk bit if fwnode exists in DT" $ b4 am -sl 20240320075554.8178-2-johan+linaro@kernel.org ... $ git am ./v4_20240320_johan_linaro_bluetooth_qca_fix_device_address_endianness.mbx Applying: dt-bindings: bluetooth: add 'qcom,local-bd-address-broken' Applying: arm64: dts: qcom: sc7180-trogdor: mark bluetooth address as broken Applying: Bluetooth: add quirk for broken address properties Applying: Bluetooth: qca: fix device-address endianness Do you have anything else in your tree which may interfere? What tree is that exactly? Johan