Received-SPF: pass (google.com: domain of linux-kernel+bounces-117478-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 25 Mar 2024 18:34:13 +0200
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Patrick Rudolph <patrick.rudolph@9elements.com>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jean Delvare <jdelvare@suse.com>
Subject: Re: [PATCH v1 1/3] hwmon: (pmbus/mp2975) Replace home made version
 of __assign_bit()
Message-ID: <ZgGnhTITTPpKr4rf@smile.fi.intel.com>
References: <20240325120952.3019767-1-andriy.shevchenko@linux.intel.com>
 <20240325120952.3019767-2-andriy.shevchenko@linux.intel.com>
 <e04c9300-b9e8-4ea9-8d4a-464f82cbdb0c@roeck-us.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e04c9300-b9e8-4ea9-8d4a-464f82cbdb0c@roeck-us.net>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Mon, Mar 25, 2024 at 09:29:11AM -0700, Guenter Roeck wrote:
> On Mon, Mar 25, 2024 at 02:07:42PM +0200, Andy Shevchenko wrote:
> > The newly introduced SWAP() macro is quite generic by naming, but
> > moreover it's a repetition of the existing __assign_bit().
> > With this applied, add a missing bits.h (via now required bitops.h).
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Not sure if I like __assign_bit() more than SWAP(),

To add to the mess, we have swap() already defined globally.
This one steps on our toes.

> but at least it is "standard". Applied.

Thank you!

-- 
With Best Regards,
Andy Shevchenko