Received-SPF: pass (google.com: domain of linux-kernel+bounces-116950-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Subject: Re: [PATCH 6.8 000/715] 6.8.2-rc1 review
To: Sasha Levin <sashal@kernel.org>, linux-kernel@vger.kernel.org,
 stable@vger.kernel.org
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
 linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org,
 lkft-triage@lists.linaro.org, florian.fainelli@broadcom.com, pavel@denx.de
References: <20240324223455.1342824-1-sashal@kernel.org>
From: =?UTF-8?Q?Holger_Hoffst=c3=a4tte?= <holger@applied-asynchrony.com>
Organization: Applied Asynchrony, Inc.
Message-ID: <00caf4e2-ea56-5d5e-03a4-df8fc91a0c77@applied-asynchrony.com>
Date: Mon, 25 Mar 2024 12:26:34 +0100
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <20240324223455.1342824-1-sashal@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 2024-03-24 23:22, Sasha Levin wrote:
> 
> This is the start of the stable review cycle for the 6.8.2 release.
> There are 715 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.

Applying the patch to 6.8.1 quickly fails the build of a previously
working config with:

   CALL    scripts/checksyscalls.sh
   DESCEND objtool
   INSTALL libsubcmd_headers
   DESCEND bpf/resolve_btfids
   CC      /tmp/linux-6.8.2/tools/bpf/resolve_btfids/libbpf/staticobjs/bpf.o
In file included from /usr/include/stdio.h:34,
                  from libbpf.h:14,
                  from bpf.c:36:
bpf.c: In function 'bpf_token_create':
bpf.c:1293:60: error: 'union bpf_attr' has no member named 'token_create'; did you mean 'iter_create'?
  1293 |         const size_t attr_sz = offsetofend(union bpf_attr, token_create);
       |                                                            ^~~~~~~~~~~~
bpf.c:1293:32: note: in expansion of macro 'offsetofend'
  1293 |         const size_t attr_sz = offsetofend(union bpf_attr, token_create);
       |                                ^~~~~~~~~~~
In file included from bpf.c:37:
bpf.c:1293:60: error: 'union bpf_attr' has no member named 'token_create'; did you mean 'iter_create'?
  1293 |         const size_t attr_sz = offsetofend(union bpf_attr, token_create);
       |                                                            ^~~~~~~~~~~~
libbpf_internal.h:107:54: note: in definition of macro 'offsetofend'
   107 |         (offsetof(TYPE, FIELD) + sizeof(((TYPE *)0)->FIELD))
       |                                                      ^~~~~
bpf.c:1301:14: error: 'union bpf_attr' has no member named 'token_create'; did you mean 'iter_create'?
  1301 |         attr.token_create.bpffs_fd = bpffs_fd;
       |              ^~~~~~~~~~~~
       |              iter_create
bpf.c:1302:14: error: 'union bpf_attr' has no member named 'token_create'; did you mean 'iter_create'?
  1302 |         attr.token_create.flags = OPTS_GET(opts, flags, 0);
       |              ^~~~~~~~~~~~
       |              iter_create
bpf.c:1304:25: error: 'BPF_TOKEN_CREATE' undeclared (first use in this function); did you mean 'BPF_ITER_CREATE'?
  1304 |         fd = sys_bpf_fd(BPF_TOKEN_CREATE, &attr, attr_sz);
       |                         ^~~~~~~~~~~~~~~~
       |                         BPF_ITER_CREATE

Introduced by "libbpf-add-bpf_token_create-api.patch".

A quick search indicates that at least mainline commit 35f96de04127
aka "bpf: Introduce BPF token object" is missing (but does not apply),
likely others.