Received-SPF: pass (google.com: domain of linux-kernel+bounces-118062-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240325163831.203014-1-herve.codina@bootlin.com>
In-Reply-To: <20240325163831.203014-1-herve.codina@bootlin.com>
From: Saravana Kannan <saravanak@google.com>
Date: Mon, 25 Mar 2024 14:49:38 -0700
Message-ID: <CAGETcx9YpqNhnNgpVNCuxm_nbApVbdXgFRiLVNYP64DKcDEm8g@mail.gmail.com>
Subject: Re: [PATCH v3 RESEND] driver core: Keep the supplier fwnode
 consistent with the device
To: Herve Codina <herve.codina@bootlin.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J. Wysocki" <rafael@kernel.org>, 
	linux-kernel@vger.kernel.org, Allan Nielsen <allan.nielsen@microchip.com>, 
	Horatiu Vultur <horatiu.vultur@microchip.com>, 
	Steen Hegelund <steen.hegelund@microchip.com>, 
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>, stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 25, 2024 at 9:39=E2=80=AFAM Herve Codina <herve.codina@bootlin.=
com> wrote:
>
> The commit 3a2dbc510c43 ("driver core: fw_devlink: Don't purge child
> fwnode's consumer links") introduces the possibility to use the
> supplier's parent device instead of the supplier itself.
> In that case the supplier fwnode used is not updated and is no more
> consistent with the supplier device used.
>
> Use the fwnode consistent with the supplier device when checking flags.

Please drop this patch. It's unnecessary churn. fw_devlink took years
to get to where it is. There are lots of corner cases. So I'd rather
not touch something if it's not broken. If a particular case for you
is broken, start with describing the issue please and then we can
figure out if it needs a change and what's a good way to do it.

Nack.

-Saravana

>
> Fixes: 3a2dbc510c43 ("driver core: fw_devlink: Don't purge child fwnode's=
 consumer links")
> Cc: stable@vger.kernel.org
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> ---
> Changes v2 -> v3:
>   Do not update the supplier handle in order to keep the original handle
>   for debug traces.
>
> Changes v1 -> v2:
>   Remove sup_handle check and related pr_debug() call as sup_handle canno=
t be
>   invalid if sup_dev is valid.
>
>  drivers/base/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index b93f3c5716ae..0d335b0dc396 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -2163,7 +2163,7 @@ static int fw_devlink_create_devlink(struct device =
*con,
>                  * supplier device indefinitely.
>                  */
>                 if (sup_dev->links.status =3D=3D DL_DEV_NO_DRIVER &&
> -                   sup_handle->flags & FWNODE_FLAG_INITIALIZED) {
> +                   sup_dev->fwnode->flags & FWNODE_FLAG_INITIALIZED) {
>                         dev_dbg(con,
>                                 "Not linking %pfwf - dev might never prob=
e\n",
>                                 sup_handle);
> --
> 2.44.0
>