Received-SPF: pass (google.com: domain of linux-kernel+bounces-118067-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 25 Mar 2024 21:56:30 +0000
To: Wedson Almeida Filho <wedsonaf@gmail.com>
From: Benno Lossin <benno.lossin@proton.me>
Cc: rust-for-linux@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>, Alex Gaynor <alex.gaynor@gmail.com>, Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>, =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>, Andreas Hindborg <a.hindborg@samsung.com>, Alice Ryhl <aliceryhl@google.com>, linux-kernel@vger.kernel.org, Wedson Almeida Filho <walmeida@microsoft.com>
Subject: Re: [PATCH 01/10] rust: kernel: move `allocator` module under `alloc`
Message-ID: <-uzW9xCfocYgSqqwoHB8D6k5CKhc5Rxnrmjq9N8XmTTNVZI3CYHIK9uigpGprs7EDYHWkALopDuv7e9w_FVfZW-9iGh3VlV9WpuSAKAWhFc=@proton.me>
In-Reply-To: <20240325195418.166013-2-wedsonaf@gmail.com>
References: <20240325195418.166013-1-wedsonaf@gmail.com> <20240325195418.166013-2-wedsonaf@gmail.com>
Feedback-ID: 71780778:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 25.03.24 20:54, Wedson Almeida Filho wrote:> From: Wedson Almeida Filho =
<walmeida@microsoft.com>
>=20
> We will add more to the `alloc` module in subsequent patches (e.g.,
> allocation flags and extension traits).
>=20
> Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>

One nit below, but feel free to add:

Reviewed-by: Benno Lossin <benno.lossin@proton.me>

> ---
>   rust/kernel/alloc.rs                 | 7 +++++++
>   rust/kernel/{ =3D> alloc}/allocator.rs | 0
>   rust/kernel/lib.rs                   | 4 +---
>   3 files changed, 8 insertions(+), 3 deletions(-)
>   create mode 100644 rust/kernel/alloc.rs
>   rename rust/kernel/{ =3D> alloc}/allocator.rs (100%)
>=20
> diff --git a/rust/kernel/alloc.rs b/rust/kernel/alloc.rs
> new file mode 100644
> index 000000000000..ccd4149932c3
> --- /dev/null
> +++ b/rust/kernel/alloc.rs
> @@ -0,0 +1,7 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +//! Allocation support.

I think 'Extensions to the `alloc` crate.' fits better.

--=20
Cheers,
Benno

> +
> +#[cfg(not(test))]
> +#[cfg(not(testlib))]
> +mod allocator;
> diff --git a/rust/kernel/allocator.rs b/rust/kernel/alloc/allocator.rs
> similarity index 100%
> rename from rust/kernel/allocator.rs
> rename to rust/kernel/alloc/allocator.rs
> diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs
> index be68d5e567b1..51f30e55bd00 100644
> --- a/rust/kernel/lib.rs
> +++ b/rust/kernel/lib.rs
> @@ -28,9 +28,7 @@
>   // Allow proc-macros to refer to `::kernel` inside the `kernel` crate (=
this crate).
>   extern crate self as kernel;
>=20
> -#[cfg(not(test))]
> -#[cfg(not(testlib))]
> -mod allocator;
> +pub mod alloc;
>   mod build_assert;
>   pub mod error;
>   pub mod init;
> --
> 2.34.1
>