Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2969997lqp; Mon, 25 Mar 2024 15:04:08 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXWhOApFQXnxKoXI5oi0KqeaDrztLxgtbQkOJGdIMDq/dVoFCYkFqjJAyHdh0f6c5poleMei6tJV/C+bPr4fs9aZWMH96llko9Rk3/K1A== X-Google-Smtp-Source: AGHT+IGK08RkU7Gl5O6bU0Y8xrHks/ptgyCPiSOLyM0v6cmcRmfxcf7kbhLP7+Rh/GYMStimQRmF X-Received: by 2002:a05:6820:990:b0:5a5:16e7:7a4f with SMTP id cg16-20020a056820099000b005a516e77a4fmr9275026oob.0.1711404247942; Mon, 25 Mar 2024 15:04:07 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711404247; cv=pass; d=google.com; s=arc-20160816; b=M3oypl8OVaeTGx48Hc+mn4GVPq9kihEfyFdGPxQIIPlUnZ+kh2ouVLJCorqDJ+oR+n S+TFKsI4Xug0PSrOHP4DcqWL+8zDGyxlBny8gR8CkeXdtaPuVlS9rsFVr+l+xGr9yV/M rhPBHDy0fn5LfxRKNi98I42MbB3+QnbM99SK9iGP7w4ODdKONhyK8qdW0N7VY9ZoZ+9E geZtMVOqLVwfWa9HzPRHXJEMgn97lDKQZHB1tXiRIpPCpsWqy1WP2aeumLNSi0JE7QdO jiEEKmqUwws73XAg9QzYKGhF8NZuNLAKMCrLiqCTXKzZwCWevufuhrAawgstAcUXSTkv PcBg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=2OzuWBfEHlvCPliRQEPtFXIhtGtXUhL5As0E4wq6onI=; fh=4sNJtPmtJhy5VhkreSU+T9XrLEwfNALAejbqKWBiaJc=; b=vDOubl0xAPEaQi2PTgRUZqSJYHl1v+fqIV1kQIwIsGIw/zY8wtrhC9VdEG2tSx1fCc 5pfxqEfKtVU68FDYIFW3ARgzvC/IJ5YwycuQVyRgflrsd7r0W6UP5eaqPYku/6mkN+7D KNQHaL6OG3KMyjbyfhAoMXRZ112J43LW6ugRE4wJ62YAtzzvGR39M6I6LJApEyCqc3Xl gUTrAaKYwng+GDkzIxHDp+uKHOAz82e+zNBfEsIKPkEhpSW+IWxmBaZbv1fOGUXFcOou SxdtJNI8zvp966I3qpsB0zSB4VARyd/vXhAvSMR38vWgB8aIJR2HZUWKIyttPmltTph8 Ri4w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=wcWZDahR; arc=pass (i=1 spf=pass spfdomain=ideasonboard.com dkim=pass dkdomain=ideasonboard.com); spf=pass (google.com: domain of linux-kernel+bounces-118076-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-118076-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id t16-20020ac85890000000b0043160497969si1722238qta.170.2024.03.25.15.04.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 15:04:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-118076-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=wcWZDahR; arc=pass (i=1 spf=pass spfdomain=ideasonboard.com dkim=pass dkdomain=ideasonboard.com); spf=pass (google.com: domain of linux-kernel+bounces-118076-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-118076-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9A00B1C39122 for ; Mon, 25 Mar 2024 22:04:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A082971738; Mon, 25 Mar 2024 22:03:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="wcWZDahR" Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CED356F520; Mon, 25 Mar 2024 22:03:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711404230; cv=none; b=kJ1uW5ab9p0IT7JUa0yiUWVlwkUYEDHKTvOY27Rae9s8qco6TSQd/0CbkeYX0eenPmLV+d1FHijcv2nvbUAoVdDVPsb60d5Dm1VIjLM59bzNMpltPUZmu3FKbkCa3pDlh5ovUw88+IRwypktYT775U0aVAfl/i/W+d49VadkvlM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711404230; c=relaxed/simple; bh=wILjujuHwaXE035Qg6th/X7umy8fExbM4hbSiy6UlSs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UFM8qNuz8ar4A4C2BPQFh5NH7t+rBjFKJNyh8MQ3xDDckntmKfb6e1jAERNjXFMmKjLVDjeybuZKttXPPswG9sfrwNlTtl9A8gDjEXX8L7DCj2D5ByU6o05PEKJ0tO0LcsS//Emz0FVSdacoy4+caa+CjpOo59nrK/TMSDDaMMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=wcWZDahR; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 236467E4; Mon, 25 Mar 2024 23:03:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1711404194; bh=wILjujuHwaXE035Qg6th/X7umy8fExbM4hbSiy6UlSs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wcWZDahRijyytCUtYxvi42I6OWjBMYCCwpdBuNX3lnAyLMuPxYi/Mdq6egt4xO8XK XMtYknsnFJZ//PKJvUpADXqEw/O82d5bSIcqU23dtK23anMAGJXVI3pYYAHNZUTnHa oO7GkoR/0ZssUxzL7/ZU63sf7x3TJ7xPWf8Lhg+M= Date: Tue, 26 Mar 2024 00:03:38 +0200 From: Laurent Pinchart To: Tommaso Merciai Cc: Adam Ford , linux-arm-kernel@lists.infradead.org, marex@denx.de, alexander.stein@ew.tq-group.com, frieder.schrempf@kontron.de, Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Vinod Koul , Kishon Vijay Abraham I , Catalin Marinas , Will Deacon , Liu Ying , Ulf Hansson , Lucas Stach , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH V8 00/12] soc: imx8mp: Add support for HDMI Message-ID: <20240325220338.GE23988@pendragon.ideasonboard.com> References: <20240203165307.7806-1-aford173@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Hi Tommaso, On Mon, Mar 25, 2024 at 10:48:56PM +0100, Tommaso Merciai wrote: > Hi Adam, Lucas, > Thanks for this series. > > This series make HDMI work on evk. > All is working properly on my side. > > Tested on: Linux imx8mp-lpddr4-evk 6.9.0-rc1. > Hope this help. > > Tested-by: Tommaso Merciai The DRM side has been merged already. The only missing patches are for the PHY, and the latest version can be found in https://lore.kernel.org/linux-phy/20240227220444.77566-1-aford173@gmail.com/. You can test that series and send a Tested-by tag. I'm crossing my fingers and hoping it will be merged in v6.10. > On Sat, Feb 03, 2024 at 10:52:40AM -0600, Adam Ford wrote: > > The i.MX8M Plus has an HDMI controller, but it depends on two > > other systems, the Parallel Video Interface (PVI) and the > > HDMI PHY from Samsung. The LCDIF controller generates the display > > and routes it to the PVI which converts passes the parallel video > > to the HDMI bridge. The HDMI system has a corresponding power > > domain controller whose driver was partially written, but the > > device tree for it was never applied, so some changes to the > > power domain should be harmless because they've not really been > > used yet. > > > > This series is adapted from multiple series from Lucas Stach with > > edits and suggestions from feedback from various series, but it > > since it's difficult to use and test them independently, > > I merged them into on unified series. The version history is a > > bit ambiguous since different components were submitted at different > > times and had different amount of retries. In an effort to merge them > > I used the highest version attempt. > > > > Adam Ford (3): > > dt-bindings: soc: imx: add missing clock and power-domains to > > imx8mp-hdmi-blk-ctrl > > pmdomain: imx8mp-blk-ctrl: imx8mp_blk: Add fdcc clock to hdmimix > > domain > > arm64: defconfig: Enable DRM_IMX8MP_DW_HDMI_BRIDGE as module > > > > Lucas Stach (9): > > dt-bindings: phy: add binding for the i.MX8MP HDMI PHY > > phy: freescale: add Samsung HDMI PHY > > arm64: dts: imx8mp: add HDMI power-domains > > arm64: dts: imx8mp: add HDMI irqsteer > > dt-bindings: display: imx: add binding for i.MX8MP HDMI PVI > > drm/bridge: imx: add driver for HDMI TX Parallel Video Interface > > dt-bindings: display: imx: add binding for i.MX8MP HDMI TX > > drm/bridge: imx: add bridge wrapper driver for i.MX8MP DWC HDMI > > arm64: dts: imx8mp: add HDMI display pipeline > > > > .../display/bridge/fsl,imx8mp-hdmi-tx.yaml | 102 ++ > > .../display/imx/fsl,imx8mp-hdmi-pvi.yaml | 84 ++ > > .../bindings/phy/fsl,imx8mp-hdmi-phy.yaml | 62 + > > .../soc/imx/fsl,imx8mp-hdmi-blk-ctrl.yaml | 22 +- > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 145 +++ > > arch/arm64/configs/defconfig | 1 + > > drivers/gpu/drm/bridge/imx/Kconfig | 18 + > > drivers/gpu/drm/bridge/imx/Makefile | 2 + > > drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c | 207 ++++ > > drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx.c | 154 +++ > > drivers/phy/freescale/Kconfig | 6 + > > drivers/phy/freescale/Makefile | 1 + > > drivers/phy/freescale/phy-fsl-samsung-hdmi.c | 1075 +++++++++++++++++ > > drivers/pmdomain/imx/imx8mp-blk-ctrl.c | 10 +- > > 14 files changed, 1876 insertions(+), 13 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/display/bridge/fsl,imx8mp-hdmi-tx.yaml > > create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi-pvi.yaml > > create mode 100644 Documentation/devicetree/bindings/phy/fsl,imx8mp-hdmi-phy.yaml > > create mode 100644 drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c > > create mode 100644 drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx.c > > create mode 100644 drivers/phy/freescale/phy-fsl-samsung-hdmi.c -- Regards, Laurent Pinchart