Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2971242lqp; Mon, 25 Mar 2024 15:06:34 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVD1Rzo7fNKFNS2HuX+92EDQ7Ft5Pc4KD4fprWIS91yG3CIIjT+rM15A4/DYN/wcp2/5IEmyO94IBcGrsgMF6DjA1WGS0LshWYkjFLKAQ== X-Google-Smtp-Source: AGHT+IFqZ27vwdG8Hhgn6abtDLelaDYGVQ5JFtSL+WmpNPeU/4eWiKgtcmXoUK0IKhyRqQFV1Bh2 X-Received: by 2002:a17:903:230e:b0:1e0:b75a:8f8b with SMTP id d14-20020a170903230e00b001e0b75a8f8bmr7124804plh.45.1711404394328; Mon, 25 Mar 2024 15:06:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711404394; cv=pass; d=google.com; s=arc-20160816; b=XRkasIR/X7bAqSai5gi5MofbYDQMwaBxS4y1HjRp5rEG7JesMZSlMUGD6apQzYtjhN hHFjL/r5ZEr9GhIxeg2sXVHxG3F4jRDUx0dJ37nz7ktZodmVSEVh/FIMuDnUmrka8Tb7 73ahZvgWtdy+CDkLHNbFgCRBDtS78thcX+7VnqYvTOeEa4+gdzYeOUaXoV8kKIOhEzjb po/xoR9HXrF1vv0CVld7shHMBH3uWhTowtS5tBwayvPYtK5YVlZk8FZdHEogL1oUO/f9 g9uBgTVDl+6fnrhbq+ozycFAbFIJ8Bzae20kYju1VKs6GM7/8OADNljnpKvl7M+DXE4C euUg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=t+qHrhPlru2e52ipXA5uXUvARKQdfYvK+BlThr4IgnE=; fh=Ydwm7fBzNAnRgi4EMcOm2kdfXGrkSF4qGDI74FB8j6s=; b=czUiXq6Io4fp+nNF7XByB68jvaqw2tI1SCNCG2azgrq9BMkkf63PKL44cDPEZYoOW+ hs+B10B4/cY3nmWH/hLx/TMkwhwp7tecHDSYWVcR1n91Z3bMI411rqeU6ElQe7pdJ89m 6lpgdZsE5kd9VpNjDZHja1CRdhxGGwbU+fLbPookYrUjDK/FxvegaqHNA5D6Q7ZqFOAj eRbO63hMRQuxVfH0xuFWm+5OgkZ+zRoq+iBh9WvMO/3CBo4pEQVMBooKDcf/5RBhGAEd IYYUDtUpobsUIjV7IwCgHOPDeUE/Q/RelX8uAlLqve9Zw9jO3t9c+ZajtC5Pk0MO1EeA fAcQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=lLqvdpov; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-117925-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-117925-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id p7-20020a631e47000000b005e838ab0edfsi8395036pgm.542.2024.03.25.15.06.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 15:06:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-117925-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=lLqvdpov; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-117925-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-117925-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id EDCE8B2B2ED for ; Mon, 25 Mar 2024 20:29:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 645BB48CF2; Mon, 25 Mar 2024 20:29:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="lLqvdpov" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B5C445037 for ; Mon, 25 Mar 2024 20:29:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711398551; cv=none; b=cvxWYKQ5bGa9qSzo5XXw/d98uqK2TtxPsP0SJIbB+ih6NqzJ0ojpWAKhHCmgh3GOj+pSAygkKleseEpyta9YByA41eXFQAIpeZecdTV3PwbcNCyD4Bw/0zmyDnbJz95X+mcAZkYA3z2Iabyb+1ux84f91HyZYm+JiL8ZhhenI1c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711398551; c=relaxed/simple; bh=nfVLFY97TTH4TNsZH8G5ndSxRhKAMtXtADlNh6V0jyk=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=VMBAz2ABgrgyzy3Obk11+cUu6YCLHKPoV08Qjn0NZOA5pXLCqWok+s0Nqs7HfMXwqCnLJ9mfBbC3U3hLuSSExNUdukzMF5+84FvOOkY18pc1DhqmHrxwrLkG0O/Rd7nTeuabekWD3CdKDC5/97cEddPUlWqqlPw3FwRjsWawNvA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=lLqvdpov; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DD3AC433C7; Mon, 25 Mar 2024 20:29:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1711398550; bh=nfVLFY97TTH4TNsZH8G5ndSxRhKAMtXtADlNh6V0jyk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lLqvdpovYZYCLrBxcniicIdrfgG84STczHwD082AmwsVdLSbADv7f8H+LXhIBvDgn jFPLERwXKBBCnDazptInYJ5w1EdJJyIqLziwHyHzqpdNzPQkPg/xibLzKrLh5VcNub DEDjxkQPrWn24SyhoPel+o+zO2Rr/LLZoK2Ccv4E= Date: Mon, 25 Mar 2024 13:29:09 -0700 From: Andrew Morton To: Baoquan He Cc: kexec@lists.infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, chenhuacai@loongson.cn, dyoung@redhat.com, jbohac@suse.cz, lihuafei1@huawei.com, chenhaixiang3@huawei.com Subject: Re: [PATCH v2] crash: use macro to add crashk_res into iomem early for specific arch Message-Id: <20240325132909.741ae47a8a05837c175a981e@linux-foundation.org> In-Reply-To: References: <20240324033513.1027427-1-bhe@redhat.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 25 Mar 2024 09:50:50 +0800 Baoquan He wrote: > There are regression reports[1][2] that crashkernel region on x86_64 can't > be added into iomem tree sometime. This causes the later failure of kdump > loading. So I think a cc:stable is needed. > This happened after commit 4a693ce65b18 ("kdump: defer the insertion of > crashkernel resources") was merged. > > Even though, these reported issues are proved to be related to other > component, they are just exposed after above commmit applied, I still > would like to keep crashk_res and crashk_low_res being added into iomem > early as before because the early adding has been always there on x86_64 > and working very well. For safety of kdump, Let's change it back. I'll use 4a693ce65b18 as the Fixes: target, since there is no "Exposed-by-non-buggy-patch:" tag. To tell the -stable tree maintainers how far back in history this should be backported.