Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2972806lqp; Mon, 25 Mar 2024 15:09:56 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWsbLd3nMWk3XSGhU6ASYyMx2JJADKgRf1aC85YANm3RLTsiXveaFtS1dvabBoMkhDtovoWqxUY1Cz6p7n8z26a0JnAKFa/0t1Bf0wc5w== X-Google-Smtp-Source: AGHT+IHJNTcAhNvKleUaK+EsP6EXXxyr7UmooBGjIqIJoC4qBSohTcUYXCcJ3wzRgo+kxptuRLBv X-Received: by 2002:a05:622a:1009:b0:431:62a8:491e with SMTP id d9-20020a05622a100900b0043162a8491emr2474475qte.55.1711404596667; Mon, 25 Mar 2024 15:09:56 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711404596; cv=pass; d=google.com; s=arc-20160816; b=J7vevjFTi3fkSofPDizuA8ZiEf0oeOTWkmJxve0cBH7JpSH4mkhD1JctgB8zxLorDP pPHfaQf3SFG4Zx4znBpZh7MIGY7aXvRChsARRQZfQZ6kT/AGZKKi3QRmGYbnTV7IEkSJ wW0TRElm3pKUmRN2zhkpqiCoWLTszTbgpOPQ/f+DL97PAAeyfcgtw4GymASPpYISpfbj 5d9Q0WlDsG1Vf/xc4DqYMAsxzPwJlWvTYLORnDybH8OAiv5PWYET53WHRfhHI+U3WwoB Wnx4MtLHaiAEcZQOPwcIoxaxvhO+L3QyMJzx5jWK726DGgSDqDvKLzghh4tmIpbooAZf wzTA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=Q0AK3v/WZL5n+7QrQYzC51AQLPr27FiV8Hf4JW0/Qkg=; fh=shp5gDxCmjYvVhJPMad5NZ06xhXbN9U72Nx4hPLX3VM=; b=skhkEFuTf2ZZrA075BYzgAAMZS/C0SXYiiDhMUJ5sWZdQ0wFIsQ9zBVgAXUPthzRoZ hKzb7QmKxRoYwFKCoF47QuTxYraw4mUGDyy+TsnrQjyJd8TC6uuq8wfObF6Cw0UZ3Iqj TQ/LhHXnMcqRxJfpXtYYbZBhDoE1elhtZ+3CfoTPjp/CKR4V56ChVIY0dSntcYKOK/+0 rWj6MAWKMTWnX2+2D2mevnGytED9u5mSSRVGfVk7F2z2K/theLkZjYWsxiSlyS/Odc0g vgPcyZehv+NAZ0XsfI8oXqrU6KiX6nzAyd/tf6fBBuohtxkVC+2rA3WoczU3CWFFkaZq MQ6g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NSnWZsxW; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-118085-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-118085-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id cc10-20020a05622a410a00b0042f248aea57si6607290qtb.448.2024.03.25.15.09.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 15:09:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-118085-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NSnWZsxW; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-118085-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-118085-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 670BA1C3C9DA for ; Mon, 25 Mar 2024 22:09:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C0EB773163; Mon, 25 Mar 2024 22:09:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NSnWZsxW" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF23E71732; Mon, 25 Mar 2024 22:09:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711404587; cv=none; b=BfVNFMtYav3sKRSKstOe12zgqMFoOndTQV3GO9hlD4dZq3FvlwzAl83BNYqyZWY/zmwBzq94hiGfUp/6LRTviWImCSO9uCu7yolBByFAIRIHsomWdzWyQru+pirQ7Jhe2lv7MUux2NYHS/67k2zAsB8TpxoItve7wxYvgBciHIg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711404587; c=relaxed/simple; bh=MHgrmDbY6yGfAgeqDr3txltVR53Kng8qLPXpLxZiglw=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=UZXUWe7hAm2h54yFmEOjyJfbQcV/MThirZykPyEhKfrJo+Z8fjiACHX3Idikn4AEe5IT34lvwGrtca8QNqfXUY0qbrc4sf2il2AiZlMSIsFmXuOFnJkWdHRDJddxXYvz1i9FLTWTRgfyfWMibVACzVn6bx7Lx/3051HOEJAaZFA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NSnWZsxW; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E98FC433C7; Mon, 25 Mar 2024 22:09:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711404586; bh=MHgrmDbY6yGfAgeqDr3txltVR53Kng8qLPXpLxZiglw=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=NSnWZsxWV5zih75kzQMss0dcrkir5jVOC2GifM2BBPN77g5hkoNR3oxgkh/zNR3j6 S2Bq5lxz+2EPod17risV9ZyCEhMThjo9Lf1Xx/wzwwzgX3sxKDx0GrYnFB06OD76Xx 0IZO8QQPVYf1VgGcq9PrcoDQ9b4vcF7kMdMIkzHiikVNpbaNYZ0YBwYno3KdjNth5R TD/rmv+qrAzCcx+Xxhb+zxSyXDPaLVHDD/3Vr5jteguD4BNhJ0qhvagGmCpj4EPwZ8 L7ptgGeLIynCCC9OhLlGawsSKuX/+wbiaNAq2lBg7WzJLyLwPYt2GQJ578dFIZ9wV0 9XlVUjpnhJEYw== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 26 Mar 2024 00:09:42 +0200 Message-Id: Subject: Re: [PATCH v5 1/2] kprobes: textmem API From: "Jarkko Sakkinen" To: "Jarkko Sakkinen" , Cc: "Masami Hiramatsu" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , , "Luis Chamberlain" , , "Naveen N . Rao" , "Anil S Keshavamurthy" , "David S . Miller" X-Mailer: aerc 0.17.0 References: <20240325215502.660-1-jarkko@kernel.org> In-Reply-To: <20240325215502.660-1-jarkko@kernel.org> On Mon Mar 25, 2024 at 11:55 PM EET, Jarkko Sakkinen wrote: > +#ifdef CONFIG_MODULES > if (register_module_notifier(&trace_kprobe_module_nb)) > return -EINVAL; > +#endif /* CONFIG_MODULES */ register_module_notifier() does have "dummy" version but what would I pass to it. It makes more mess than it cleans to declare also a "dummy" version of trace_kprobe_module_nb. The callback itself has too tight module subsystem bindings so that they could be simply flagged with IS_DEFINED() (or correct if I'm mistaken, this the conclusion I've ended up with). BR, Jarkko