Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2974452lqp; Mon, 25 Mar 2024 15:13:33 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVIe8ePhjQ76FAJIeWdWthTnhih1TAUVlPwCW7zDcxbpjwMCjTufVZMZIkI+q9iRwWgvoi8fHgBj9MDHFG3wqpcLZFBKXZFAUwtmlXA9w== X-Google-Smtp-Source: AGHT+IGB5k9BcoSrVmQWQQ9jR1vOA6cpCjKhwopIliMCYbw+xXk1AaXszewEy4DQhscIHUZkuVli X-Received: by 2002:a05:6a21:19d:b0:1a3:50be:b3bb with SMTP id le29-20020a056a21019d00b001a350beb3bbmr8882559pzb.53.1711404813151; Mon, 25 Mar 2024 15:13:33 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711404813; cv=pass; d=google.com; s=arc-20160816; b=t/L1jPCpeGahKehusZ42LR1ExJZRp/fkK9iv8e0quiUCt8pgg514jebXxQZ1MBKked 2DUnuQQi1fARvmQpR7pV0ypLJHOWDaot0Du/IXUDTQo9S30h0A+ecCdY0o/XmBtW7AYR I14NELHm3/v1Q0pGkvu7vRDpCYT2fG61vdxtHmyIjA+K+el0xD/CU/1s3DByScmslwSB yjx0NrX71MfAfBhid2UvzQlbSfJMfXJe5/IvWERYRY2bgeg6q5P7n87QJxn1e/rZA66N w+oDznjcbdrdgVKd4R25sReqh9nen5g5UHZZ0NqgRsB48LmI4COhX4wwH+uZiOBB5eBI XdPA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=1GTrfqhG6UWYdvXljUBH703qg34G3qexfv7v4t4TONE=; fh=z39VAMq2J5oCN7NMDgbgCOXzI1IH5r9ULEJ0lq7y5FQ=; b=0r9WydMc+mwlj0+0R/t9NbZBWZ6KCEWv9jH85Mg9/Q4lKzbcjhZZRfALu3Kg1KIl7X yHYn2bFUTAe8lvHgPr54fjV5JFTLWJI8E4t9JKL1Y0T2YhR3y6IQSywUH/hp2O4781DJ 2tkHV35LqlifgjVtiUdkZ/5pXgY5fWuEALgOhMD8kvg5DvJ0iYECMNeIaEzyiOHHNwV3 O60SETSehd99iTQ/K6+0V4cLhF7tmr85dK7gU1zctRbtQ6JVsm9mygu1ma3CHDQdX+V8 V8cWLqGxql0raQ2ZPfQtnBfqUC7SCylF5H1QE+ajFw7Exb4PRcKkLBhtX2gasf/eg/aY XUwQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=L+1Z1mz5; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-117510-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-117510-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id b2-20020a17090a100200b0029c5e28d936si8549739pja.146.2024.03.25.15.13.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 15:13:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-117510-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=L+1Z1mz5; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-117510-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-117510-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 3A771B2E2C2 for ; Mon, 25 Mar 2024 17:44:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4B2299457; Mon, 25 Mar 2024 16:51:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="L+1Z1mz5" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C3963DABE6; Mon, 25 Mar 2024 16:51:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711385500; cv=none; b=Kq9QH+OFUGkfeu+5Gd3IqzokcHv59vZ55wSrGKU0Q1fp0V2C6j5bPxZ58z4bVNmVyLCBAZm/uRBAQoNYerHoKivBuNDVCBqIwYihebk9SPfHP1Gzxj1W5EYxVsluzeD8wWQtjEo6w+2hbsdPTY+7I7DyG/heLNFvjZmDim+g+Kw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711385500; c=relaxed/simple; bh=Iu8KBH2J8gwOqs7CFvo2VClDZQn6xBSmERMdX7llFo8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GM2czId06c0OLTVA2RLWVhxNVin5C16vMr0+Mm+aTE1MV3n1kDKMIezXaOXe0naXvZJncsfXqcAVlGDnWAubajLLyCfSosHfrip+trja6bp7/HQpXKTp1KTIljc2TuxVRmuQCM6ZoD72UpHMGuSdWjJIJO+3a2rOnwFXN3sevho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=L+1Z1mz5; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01C34C433F1; Mon, 25 Mar 2024 16:51:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711385499; bh=Iu8KBH2J8gwOqs7CFvo2VClDZQn6xBSmERMdX7llFo8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L+1Z1mz5ihW5gtjTmBfXU5UZzmTBjUNp01p6oqQq/GUwWiPlxi93qpigozpyMTMdN Z/RYEiSHUpzkN8D3UW4ZwuFRlwHPXMqLDkSbDU+gJ8FFfyUQyxioYcVF/rCCAp1F85 9I/JK9X/c3o4/4EiuImJaIPNd1yCZCXKY6+fMEtiPjGeClxpLuIw1JhpxpYvLY1RbO juXjB9bSH0cMkzqpqfIxk/37qFpNvpYVN5p778mv5OjQv4X90GMRNY9hXKnyODne4U 6p3OccFTTYq5TUbKg3NrI0/vR+uMQ5k8domUKwN80L9w3S0FFsRJ06pI/L0LoIYN/d G3Hu2FiM65sFg== Date: Mon, 25 Mar 2024 16:51:34 +0000 From: Lee Jones To: Matti Vaittinen Cc: Andreas Kemnade , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: Re: [RFC PATCH 2/2] mfd: rohm-bd71828: Add power off functionality Message-ID: <20240325165134.GP13211@google.com> References: <20240324201210.232301-1-andreas@kemnade.info> <20240324201210.232301-3-andreas@kemnade.info> <472c6eaf-6cbc-484c-bc94-571d115176aa@gmail.com> <20240325131605.6607b778@aktux> <81bf6604-9160-4bae-8da6-7034f8aa3f92@gmail.com> <20240325141032.GO13211@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240325141032.GO13211@google.com> On Mon, 25 Mar 2024, Lee Jones wrote: > On Mon, 25 Mar 2024, Matti Vaittinen wrote: > > > Hi Andreas, > > > > On 3/25/24 14:16, Andreas Kemnade wrote: > > > On Mon, 25 Mar 2024 13:31:15 +0200 > > > Matti Vaittinen wrote: > > > > > > > On 3/24/24 22:12, Andreas Kemnade wrote: > > > > > Since the chip can power off the system, add the corresponding > > > > > functionality. > > > > > Based on https://github.com/kobolabs/Kobo-Reader/raw/master/hw/imx6sll-clara2e/kernel.tar.bz2 > > > > > No information source about the magic numbers found. > > > > > > > > Oh, interesting repository :) Thanks for linking to it! I didn't know > > > > someone had reworked this driver... > > > > > > > which btw: contains this interesting snippet (output from fdtdump) > > > bd71828-i2c@4b { > > > reg = <0x0000004b>; > > > compatible = "rohm,bd71828"; > > > gpio_int = <0x00000008 0x00000013 0x00000001>; > > > gpio_wdogb = <0x00000039 0x00000018 0x00000001>; > > > #address-cells = <0x00000001>; > > > #size-cells = <0x00000000>; > > > pmic@4b { > > > compatible = "rohm,bd71828"; > > > regulators { > > > BUCK1 { > > > regulator-name = "buck1"; > > > > > > > > > and to make it work since basically no regulators are registered > > > instead just some regmap_write()s are done to configure something > > > in probe(). It is a pitfall to think that the information below pmic@4b > > > is used, especially since it is not that obvious in the source. > > Odd! Not only did I not receive the original patch, I also did not > receive your response Andreas. Spam is empty too. > > LORE too: https://lore.kernel.org/all/?q=%22mfd:%20rohm-bd71828:%20Add%20power%20off%20functionality%22 Super weird! They just all came through. The LORE link above is now working too. I suspect an issue with kernel.org. -- Lee Jones [李琼斯]