Received-SPF: pass (google.com: domain of linux-kernel+bounces-118156-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <e5a06991c5540219366db84ce4e820e22a939929.camel@irl.hu>
Subject: Re: [PATCH 3/3] ALSA: hda/tas2781: add debug statements to kcontrols
From: Gergo Koteles <soyer@irl.hu>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
  Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
  Baojun Xu <baojun.xu@ti.com>, Jaroslav Kysela <perex@perex.cz>,
  Takashi Iwai <tiwai@suse.com>,
  Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
  linux-kernel@vger.kernel.org
Date: Tue, 26 Mar 2024 00:13:40 +0100
In-Reply-To: <377e0f33-697c-4baf-ac48-baff6199dd53@linux.intel.com>
References: <cover.1711401621.git.soyer@irl.hu>
	 <cbdc337b911bee0f80f805b936041fd59c1db54a.1711401621.git.soyer@irl.hu>
	 <377e0f33-697c-4baf-ac48-baff6199dd53@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

Hi Pierre-Louis,

On Mon, 2024-03-25 at 17:01 -0500, Pierre-Louis Bossart wrote:
>=20
>=20
> > +++ b/sound/pci/hda/tas2781_hda_i2c.c
> > @@ -189,6 +189,9 @@ static int tasdevice_get_profile_id(struct snd_kcon=
trol *kcontrol,
> > =20
> >  	ucontrol->value.integer.value[0] =3D tas_priv->rcabin.profile_cfg_id;
> > =20
> > +	dev_dbg(tas_priv->dev, "%s: %d\n", __func__,
>=20
> Nit-pick: you don't need to add __func__ to dev_dbg logs, the user can
> add the information with the dyndbg parameter, e.g.
>=20
> options snd_intel_dspcfg dyndbg=3D+pmf
>=20
> dev_err/warn don't have this functionality though so in those cases
> there's no replacement for __func__
>=20

Thanks. I just put a #define DEBUG into the first line and rebuilt the
module. It will be faster this way :)

I will send a v2.


Regards,
Gergo