Received-SPF: pass (google.com: domain of linux-kernel+bounces-118054-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <fb97f97e-c6d0-4584-813b-5b81facc4325@vorpal.se>
Date: Mon, 25 Mar 2024 22:37:01 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 0/2] platform/x86: Add ACPI quickstart button driver
To: Hans de Goede <hdegoede@redhat.com>, Armin Wolf <W_Armin@gmx.de>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240131111641.4418-1-W_Armin@gmx.de>
 <c1b08bbb-ad57-4f41-9b7b-40a6aeb3da9b@redhat.com>
Content-Language: en-US
From: Arvid Norlander <lkml@vorpal.se>
In-Reply-To: <c1b08bbb-ad57-4f41-9b7b-40a6aeb3da9b@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 2024-03-24 15:55, Hans de Goede wrote:
> Hi Armin and Arvid,
> 
> On 1/31/24 12:16 PM, Armin Wolf wrote:
>> This patch series adds support for the ACPI PNP0C32 device as
>> proposed in 2022 by Arvid Norlander. The first patch adds support
>> for the device itself, while the second patch was taken from the
>> original series.
>>
>> Both patches are compile-tested only.
> 
> Armin, thank you for creating a new cleaned up driver for the
> quickstart button support.
> 
> I have managed to get my hands on a Toshiba Portege Z830 and
> I have successfully tested this series. That is this makes
> the 2 quickstart application and the toggle-touchpad button
> work when the system is running normally.

That is some dedication! Sorry for completely dropping the ball on this,
real life happened and I had to prioritise. My beginning "carreer" as a
kernel developer was one of the things that ended up getting cut.

I'm going to do a quick bug report while I'm writing an email here. I
noticed on my Z830 that the readouts of the charge control thresholds
didn't seem to work when I last tested it. Setting worked just fine, but
reading it always returns 100%. Didn't get around to debugging this, but I
assume it a simple error.

Also my Z830 have developed a whole horizontal line of stuck red pixels
across the middle of the screen, so it seems quite unlikely I'll use it
much more or even keep it long term.

> Neither the quickstart buttons, nor the touchpad-toggle button
> which also uses the PNP0C32 interface, work to wakeup
> the system from sleep though.

This is probably a limitation of the hardware. Though there are IIRC some
BIOS options for what should wake the laptop from power-off, including any
keyboard press whatsoever. (Fun fact: The Toshiba ACPI interface allows
changing these BIOS settings from the OS, though you would have to do it by
hand from user space currently as it is not exposed in the driver.)

Best regards,
Arvid Norlander