Received-SPF: pass (google.com: domain of linux-kernel+bounces-118168-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 26 Mar 2024 07:35:16 +0800
From: Baoquan He <bhe@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kexec@lists.infradead.org, mingo@kernel.org,
	linux-kernel@vger.kernel.org, x86@kernel.org,
	chenhuacai@loongson.cn, dyoung@redhat.com, jbohac@suse.cz,
	lihuafei1@huawei.com, chenhaixiang3@huawei.com
Subject: Re: [PATCH v2] crash: use macro to add crashk_res into iomem early
 for specific arch
Message-ID: <ZgIKNNZ8hc14FI8a@MiWiFi-R3L-srv>
References: <20240324033513.1027427-1-bhe@redhat.com>
 <ZgDYemRQ2jxjLkq+@MiWiFi-R3L-srv>
 <20240325132909.741ae47a8a05837c175a981e@linux-foundation.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240325132909.741ae47a8a05837c175a981e@linux-foundation.org>

On 03/25/24 at 01:29pm, Andrew Morton wrote:
> On Mon, 25 Mar 2024 09:50:50 +0800 Baoquan He <bhe@redhat.com> wrote:
> 
> > There are regression reports[1][2] that crashkernel region on x86_64 can't
> > be added into iomem tree sometime. This causes the later failure of kdump
> > loading.
> 
> So I think a cc:stable is needed.

Yeah, I forgot this.

> 
> > This happened after commit 4a693ce65b18 ("kdump: defer the insertion of
> > crashkernel resources") was merged.
> > 
> > Even though, these reported issues are proved to be related to other
> > component, they are just exposed after above commmit applied, I still
> > would like to keep crashk_res and crashk_low_res being added into iomem
> > early as before because the early adding has been always there on x86_64
> > and working very well. For safety of kdump, Let's change it back.
> 
> I'll use 4a693ce65b18 as the Fixes: target, since there is no
> "Exposed-by-non-buggy-patch:" tag.  To tell the -stable tree
> maintainers how far back in history this should be backported.

Thanks a lot.