Received-SPF: pass (google.com: domain of linux-kernel+bounces-117988-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
To: Avri Altman <avri.altman@wdc.com>
Cc: "James E . J . Bottomley" <jejb@linux.ibm.com>,
        "Martin K . Petersen"
 <martin.petersen@oracle.com>,
        Bart Van Assche <bvanassche@acm.org>, Bean
 Huo <beanhuo@micron.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/4] Re-use device management code fragments
From: "Martin K. Petersen" <martin.petersen@oracle.com>
In-Reply-To: <20240309081104.5006-1-avri.altman@wdc.com> (Avri Altman's
	message of "Sat, 9 Mar 2024 10:10:58 +0200")
Organization: Oracle Corporation
Message-ID: <yq1r0fy9gpv.fsf@ca-mkp.ca.oracle.com>
References: <20240309081104.5006-1-avri.altman@wdc.com>
Date: Mon, 25 Mar 2024 16:52:54 -0400
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?JE4jC4TIIrowpfv6hBgsbuE5JEgZ/AB2U/oGldVxvVdXZqSLtW9jQfqT08JV?=
 =?us-ascii?Q?YXpTGBWUcrOjmG60z8G14lLe3ed1y2gzzvaU6nOjuKCwoWA8q69D+FxwMr7o?=
 =?us-ascii?Q?xaJ9U+Tv+B3lz0RgtENOVoi6AbxsvicT4SKBULqAqZitEgWxzQob/xfwXTPJ?=
 =?us-ascii?Q?qgRMOliRkqjLFgIFT9KKO68JwnNB22U8SuVelphzrtcdAJjG86Qtcu+PV79A?=
 =?us-ascii?Q?5297ALxLY3S+DEqeBBezPbP+rIu+HcnNFeEjqxAgb4KC9IrxBRg0Owha28r+?=
 =?us-ascii?Q?WBn9a2k5e+3HCpzPl3xUbxp2pDKvoUd8/xtQnMOtazl9qE0ooPm6ATAFETqZ?=
 =?us-ascii?Q?TPk1Q6SLQfWWUdsOG2xlL4t51SKuI9qhIBbbyPJQkf3EfE99hCKOvodxJzer?=
 =?us-ascii?Q?ltXxT6SpOe4SgEs4MneLUMgmlhiLSDuo9pY0Iw2FG8tBtjXcg61wUS/xKZC5?=
 =?us-ascii?Q?u/QiJAQMVwX7RTMvLQggr5oTZ0PGDFEH/UEzHPivBCKkbApuqKVLDJ5NoA1H?=
 =?us-ascii?Q?B/faDBNPaOC9piszInkJUfBR7L3Jlsp122dbf0lFyDfGYhMi5JatAitgDn+N?=
 =?us-ascii?Q?85pZpgBXfTnhTp/QfWPbYoISWIEk6Wbuk0XBxGx1TSnm6EXxBqZvUZe2S5ZT?=
 =?us-ascii?Q?xXXDWFCYbEaD11mse6s5AjZXLZy4M3XvqZVCDs7DU5mB0aPKyhZ6OQpD37Je?=
 =?us-ascii?Q?N4MWvCX5Y/bVkNAPVBRfh9lePQW0iBUr88OWQlym3yZkvqrYD0ddS2+IsBZB?=
 =?us-ascii?Q?pVHYyo88MTtZarnlPq87w5Kfj+RzSRoAt1fr9JEaAqodFrJWYNkHptE2Vlm1?=
 =?us-ascii?Q?anZe4CXuqi0SQMzoJ1tQ/NoAMWAaWpgOke7OTeCUL0LNzn70ghkiXPWEH0A9?=
 =?us-ascii?Q?xYc/LEqd2sd1M1d58GEtWYlKPWC3QVsbTOE5d9J2ZbAnZEbEvq4JX1Dz/510?=
 =?us-ascii?Q?DFZBn2sps8woAWwQOIl99mpFBy6Bj/XEPVnMoo2gZHTc+pKQtX80LemR27zK?=
 =?us-ascii?Q?xCZZtuTDJ0XBZqbe7FJ+GIAcJRGEfTQ6CSqi15XSEqzm61N7FWWA6jjx1LWH?=
 =?us-ascii?Q?/Pcvi/1pUQrloX9ruKVrAilm21UeqzUAibFbRuCw4AqdHFUdpyHt1IZFYSJm?=
 =?us-ascii?Q?3ASWGn/4qzwIcy8H7YGPLtX7dOA7MSkobW7EWl2DeB0oWidWjaQwzPdsieu6?=
 =?us-ascii?Q?Dhv4ZPT3C6AMMqKr4MNBoINBCUPWXUFe2Q9OzBPBqd6JYAcUhQGHTeSVLuXY?=
 =?us-ascii?Q?/kEtU9i4vg1ya5ki70P2gKHFwSsTrNaU3i5UpfR/M6ShjMQkZKL7uiyuD7uY?=
 =?us-ascii?Q?EMUtatiagvEeGkCnefIvQU4/YFzZhbbYWqRgqsYd5fOg2kQWu6bKXxlXv8bH?=
 =?us-ascii?Q?7EvHU4jUVUVmLBa52tlr2YPFlHEW2GwOXX87OVJ4zYCS4vVqRgLqSmjHqgPo?=
 =?us-ascii?Q?rzsBtfbrpYIF1PnlVDoChza/lzLbJIdbOilkHIFJ7fmp2mNcV7FkQbGWY/CV?=
 =?us-ascii?Q?tRDr1JcTKn+I5onePdKKc51gto4ldI6sG2XlzVLoot5FQ3MIEMfcDYJPiEs6?=
 =?us-ascii?Q?3HzxqItws1VkX4ffoX2eluuTJVWNljx3+4QMGvM8fVIOa6uiGqWjPBdyKvh8?=
 =?us-ascii?Q?og=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	j2iHTRTHFdKjue8o6/wUIlVaTE3yYAcpXsoJRHPBbYWW7Bsvjh9P5Drzmsl78hyYaPeDLEBUVDj7u1Vb1tQvak3L7Fu95baGQYpcL9lNDbLCWYI0KGDLhC8IPydPGaMKhoD0/FkOJCSFpj1I0pPsgext1wmjp1j9X5UNxZiaRnAHfazSvYtgNh1aKDpFt1c2VQjfo2QBSLGP184d/Tj9B7WHnH84/tLRXhb3Y/4qGsfPC/PV7MPjnZkjQjkgJKVNCEvWblur/SBVPosrxYFqUI9jW5llHnnBJGMQhnT3NdK+yi+mcVTqBbv2ik4pQdasvaGxloD0ifwFDJi8ScbSSgjsu9NynYJUcu/4mBQ0bnOUVtUtvsWIMXvQ2tHz7xt6bdreEBQvMSNbgX58ZegGXqkjbu/xvrfo7u1dKgOomNG70lktMxxZ1Atp2l8CKGdpgcu1pz9uGuIMZEdIbIFQPnfQ7P4Qq6r//Cx1sVBN54jvvbwEzNrRgNd/TB7q0JpSnX8MWoXVjHw7slVM9hkNOKsId3XYAaKZCcpmqCs/x2eZN+wC8gN8l0dcb0tdQ67YVlM2pU4oHfQFleFdKQyGI5WmnFBllA8pwUfs2I8L9A8=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: efd0aacd-414f-47e7-43c0-08dc4d0d8c64
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2024 20:52:56.6054
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CHUJ6kEF36xEAB0oKwKsdlwcy1mIhdfQ7vuw7zMuAr3JR4VabREksBnYWc2i1H2Xe9IQq8ZuXlz+lU56pjFKs/mS+kz8Xh/xbTlo0CRrQo8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR10MB6067
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-25_19,2024-03-21_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=996 phishscore=0
 bulkscore=0 spamscore=0 adultscore=0 mlxscore=0 suspectscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2403210000 definitions=main-2403250128
X-Proofpoint-GUID: h7XXSwoTFuB6ckdoWVdc7TBbER6D_0XW
X-Proofpoint-ORIG-GUID: h7XXSwoTFuB6ckdoWVdc7TBbER6D_0XW


Avri,

> Device management commands are constructed for query commands that are
> being issued by the driver, but also for raw device management
> commands originated by the bsg module, and recently, by the advanced
> rpmb handler. Thus, the same code fragments, e.g. locking, composing
> the command, composing the upiu etc., appear over and over. Remove
> those duplications. Theoretically, there should be no functional
> change.

Applied to 6.10/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering