Received-SPF: pass (google.com: domain of linux-kernel+bounces-118213-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID:
 <SY4P282MB3063048C537120C8D3477774C5352@SY4P282MB3063.AUSP282.PROD.OUTLOOK.COM>
Date: Tue, 26 Mar 2024 10:30:07 +1000
User-Agent: Mozilla Thunderbird
From: Stephen Horvath <s.horvath@outlook.com.au>
Subject: Re: [PATCH 2/2] platform/chrome: cros_kbd_led_backlight: Remove
 obsolete commands (EC_CMD_PWM_*_KEYBOARD_BACKLIGHT)
To: Brian Norris <briannorris@chromium.org>
Cc: Lee Jones <lee@kernel.org>, Benson Leung <bleung@chromium.org>,
 Guenter Roeck <groeck@chromium.org>, Tzung-Bi Shih <tzungbi@kernel.org>,
 chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20240322102800.1322022-1-s.horvath@outlook.com.au>
 <SY4P282MB3063D447DA09D35F5FBD4721C5312@SY4P282MB3063.AUSP282.PROD.OUTLOOK.COM>
 <CA+ASDXM9=0jQA=MWpBOttUT7k67wmEDFGoOObQfYm=ca_HL8GQ@mail.gmail.com>
Content-Language: en-US, en-AU, en-GB
In-Reply-To: <CA+ASDXM9=0jQA=MWpBOttUT7k67wmEDFGoOObQfYm=ca_HL8GQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SY4P282MB3063:EE_|SY8P282MB5035:EE_
X-MS-Office365-Filtering-Correlation-Id: 36b583d5-d24c-49cb-b710-08dc4d2be4e6
X-MS-Exchange-SLBlob-MailProps:
	AlkLxVwsndlo1+lFrDZI3pEF+l+HiLrLZstFIgrv3fimowAJMhy+41S1UlNDYOI2KcWZNqgzZxL6VrkxNBtvUEz3z9MI55XwRQU29wKmECsL59KEvIbDjPYVts/f3BF23B0HBFnEFvhVFz4vEpLyu/dhDtlV6m79/BOLcwkl26K/M/XtkwwUlFIs7Wj3SEBe2cPxwe3IyAjcIFIzITIsZYOqyyVlF5cVR+Z/EVNVy+vVi7bx3ic2tlwWW+gMIBKc/roZXcqyCc7LkpnXNbezm+vWqpMOjvMW9h1jB4a2slzPsDp7TY4XuqD5yH6h16RGmPdowA/PDGrjR0ilSMWk1SzCsD5v8F9QbZwSGiIVom+QqZYQAXy1Up0TaOIJ1uIm4ioin+edpBu3zaC06EeZrEBdF7YizweUz85dNcKylyZha2Z55AFQqUEszFAyxb4gRSimFBOcWZgpajsd6he9CzoH8UD7pv4hhIGmL5qcLdIyG5qJ+zlnjI82CB2hIyoHyIDU7lw/9vPyfKSLyDzepu189eTJ1A+3EyU6mLJ9kiKx3++tv0NbYN0bXJzO47QIc8N4Y6bwuyV8eBJQJeliFePgzHW3ROovEMBZn6Ds8hOQ1bmhMLPkyIZuwK8SMD6HX6+kz49+dMRVfQ2Ysr/EpZUV6D9ABpy1glDD6kASiHu976zBaeWU3SczsPkiBrRPuS7ky+EB6BacgqspSNE8KVLUtguhtjjsUdXAQ6ZVsY2o8fIxoUuFZJNOsU4zK2JLEF5We89fxqwZGNuUb35isrtOyMLnPdbx
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	s1ccXyS6SzdQeZglRqzhx/2p4iCvG3xjswftys3OZX8liCr/Z5oGGNeLzdXm/pVid8fXHkugEuks8ik4ZH94bjg4jjjv68TuPYunSGzcEYu7FrQqm41dgOS7Lffjrc4l+OvMtxj8bg6olfoGmAXL1GJ/LeWD5R5RLZbDeIwMNRZD0/VUDSBnbeT5qc6nTNwkGi2r/yjy4KGCYJWnDk2IKsx/iHdmZMPzIpEmRwdyLnTSkbOYCstd3keIs1MROwbRpdtZXt2aR1D51ZbCQ3ni7WZiCE/rDw4AKcQiu1TwqOzluDVDktNvBo01CsQECtej0+zOqlI8VdJww132SX3ht339afTAEJmY4Abi9CjR624W52ReKh5STWbR447EPAIwUtmhcAS0VdScI6yQYWQBz12Jm23pWYBvPT9aig9MV2K7YWlXL+hYgia9LtGO/D7an8d2U4Gk9oIVyufhwicxAH2eQDuQqS7PvJSzWNeFbzcs0dJsCc7XOW+UfFbThxihUdGgJx4yYaoSAHqO1vXKNdfvf1rUEHoi/xpdwcPg90SDdYDGzoYSsQBV/SGjjifx
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RjRrSHBsdXo2S3NNN2ZES0MyU2I4a0VyZzF3aUJYZ0laK3NUWld5NXFDT3hy?=
 =?utf-8?B?WVNMR01MWGFTUkRCeVl0WHFOdHFWVkd3VVJvQjRLdFZrVVVjSXBLYjMwWFRE?=
 =?utf-8?B?NTNPekJKNzFWMC9EajZVbmh6Z01JVkpweVNUUGZDRjQ2N1NkZ2JuTXhDblN4?=
 =?utf-8?B?Z1Y3TVB1RmFEVHRmak5UdDdXMHhCUWRhbGxHYTh5TVo1TkFzVjIvOTJ0bllY?=
 =?utf-8?B?TWJBc1VDQWFDRFBzR2ZGLzZrOTBwb2JBSDEyM2k2RU9LUUJKQ3J6Vmk1L1BJ?=
 =?utf-8?B?ZTQ2bVpKdDJGZnJGc0ZQY1BNQlpDKzZpRXl0NVpTd3BuQTJQWXlmVHR6elJP?=
 =?utf-8?B?Q3ZjazdxcTJPRFBTU215bzVrMDVIQnd5Rmp6M3FKaUlFQlY4anJ5SVoxcjFD?=
 =?utf-8?B?ZVJzYkNTNU92cmdZQjcyc1pXYmVVVVk4dS9oOEUzUkVoTWh4aFJ3czVzempD?=
 =?utf-8?B?SU9mb2tpZk0vdm5YM25xTEJMYnNFQUt0YitwOEpSNjUwK1V3SUFJeHlNSERT?=
 =?utf-8?B?MW1GdnQvWmlJZVVpR0h5YytNVnJZSk1idzNjQ0JxVlBwOTN1VW1WMVRreXlO?=
 =?utf-8?B?RXVNNnNGSU56K3Z2VlNSbFp0anBZQ01sK2xBdlNQcE9wUEJWTmgxRjlpajlo?=
 =?utf-8?B?UndmTUlLRloyNXdSS3BNK1FPSlJxaFFieCtFeFdlS255SVB2a3lPR0FJZkxO?=
 =?utf-8?B?SjRwZ013OUZZOEFYWDc1dk1rVDFPdEt1VkpSTWxUaWZaSXQvVjhIcDcvQm1i?=
 =?utf-8?B?aTFYZGRpRHJtMFg2QlJ5QzFITURRek5oSUxySUtyM1VQZU5sSTJLaFlHWkRo?=
 =?utf-8?B?eFhpSE82VjRtUlhJbGtKUEI4MlUyL212MitYMHNrVWNlZnVBVnhTc2IveFJM?=
 =?utf-8?B?OVJ1blE0M2lkeHAwN0xQYkxRVElzblJGQUNzRHZRQVgwbGNoV2tadmVXaG5s?=
 =?utf-8?B?eTJvNVVzZ1Urb1hQSHZuRHJhMzQ3dWZDdVpqN1A0eXU0dm02OU5KaVFkYWdK?=
 =?utf-8?B?dDJMd1FTSEt3WHg3MThHYWVEbVdyQkUva1pHazZoMHhld2h0TGVnS3RDdEI5?=
 =?utf-8?B?NHM3aU9HeG5obmd0NnFZTlFTMDRZWS9WckQxUExEL3VROVhWdjY5OThCZFlk?=
 =?utf-8?B?cU5lM3laWkNyTUVydDRQd0VPUDFpN3lTNXhjUVk1cGloakJwWFhrZDR4akNI?=
 =?utf-8?B?bWdWemtkQ1daRjhub210amY0OFJJdnZ5TlZreStqcExMbGxZVHdOZXdjUTFh?=
 =?utf-8?B?Wm5JV2JZREVOTC9PMW8vTGRIc2FSeFUzTHl0bjNFYmpTeUxnSUlWSWR2QXJk?=
 =?utf-8?B?eFhGdm1OTU1pUVpiVEJjV3ltanZmeDU1VU96Mm9uL0oxVDN6T05ReHMxZkl0?=
 =?utf-8?B?b0hBNlpad29PWThzL3BWaWdnUk1Cd3F3SzJsQWcrUW5LczNEWk5xQkFVMC9R?=
 =?utf-8?B?My9UdDA1aHVPbzAzWmtsMkU5bjgyUVZQNGQzY0tndGJmOUtPNzRWWDIwdGFO?=
 =?utf-8?B?anlmbU4yNFRSMzBKa2tRQzhhbVdsKzZGd2VmbSt2cFlnMElkUjdCWFJRa1k2?=
 =?utf-8?B?bkhhdzZoTndFMHhmeUNxREZZakM0QXRZNDVZK2lQYS9HVElZMzNOVlFIcmkr?=
 =?utf-8?B?WGpwNnd4RkxSRlFNSFRFRGhhWDlEWVNoYVYyQTB3SHlVYUNpUlJWWktzcGZp?=
 =?utf-8?Q?Q2fua/nqhKv/flthSqsM?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-746f3.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 36b583d5-d24c-49cb-b710-08dc4d2be4e6
X-MS-Exchange-CrossTenant-AuthSource: SY4P282MB3063.AUSP282.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2024 00:30:10.1237
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SY8P282MB5035


On 26/3/24 04:45, Brian Norris wrote:
> Just because the EC firmware repository marks these as obsolete (and
> yes, we copy that header mostly as-is into the kernel repository ...
> but it's still a firmware header) doesn't mean it's truly ready to be
> removed. I believe the intention is to direct *firmware* developers
> not to use them -- any new developments should be using the new
> commands.
> 
> From a kernel perspective, we could still be supporting old firmware
> on old devices, and so we may want/need to continue to support these
> commands.

Alright that makes sense.

> I don't know off the top of my head which firmware branches support
> which commands, on devices that have such keyboard backlights. (The
> Chromium EC repository is open source though, with various firmware-*
> branches still around, so this information is available.) But without
> a better explanation as to why these are truly ready to be removed,
> I'll say "NAK."

Yeah that's fair enough, my laptop seems to support both so I'll agree 
the older commands are probably the safer option.

Thanks a lot for your feedback!
Steve