Received-SPF: pass (google.com: domain of linux-kernel+bounces-117924-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 25 Mar 2024 16:26:48 -0400
From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To: Helge Deller <deller@gmx.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Yajun Deng <yajun.deng@linux.dev>, vbabka@suse.cz, lstoakes@gmail.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 RESEND] mm/mmap: convert all mas except mas_detach to
 vma iterator
Message-ID: <20240325202648.ogekznob5vsayd6k@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
	Helge Deller <deller@gmx.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Yajun Deng <yajun.deng@linux.dev>, vbabka@suse.cz,
	lstoakes@gmail.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
References: <20240325063258.1437618-1-yajun.deng@linux.dev>
 <20240325115308.f6344233a27f1633f642f888@linux-foundation.org>
 <5dc6860f-df05-457c-8b78-067f276e423b@gmx.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5dc6860f-df05-457c-8b78-067f276e423b@gmx.de>
User-Agent: NeoMutt/20220429
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?eY6zb/eV+xbIB4uA7LkovTCCH/cJM/ePzHAx5lH9pPYIhwSF3oWmhizTGtL/?=
 =?us-ascii?Q?eY7Jhe860gJlMjtEGIUA0iZjzx83OjB/O1mfNQ3adovuT6QkCVjWOkrWhFJ5?=
 =?us-ascii?Q?pqECWZTDWhGlxGlLoVfhJ21BieVbucUWaBQ6lmie9a/zu90d3jb/EckEm2I+?=
 =?us-ascii?Q?eTjQKsw6O9FspuIWtKPFR6uhV7OseMIELKMaWHcYXCcySAdQP0siT2XqA+DC?=
 =?us-ascii?Q?5+Mp04ILN3IhClmGsILN8HyAiRZzo5bsGLVouvi6SLo7pQ72NzTO/YkHw/G8?=
 =?us-ascii?Q?ZGFa0qceOMUaSo+BBCb1pnOK2CrlrhQsthLlhuqS8OvxEtZ+5HdQePVTJ3Vv?=
 =?us-ascii?Q?fY6arGmMxD1eHlYiK6d9K9sHdCEzofebSep0MGao7c5QYT9a9Q889UzcXFlQ?=
 =?us-ascii?Q?J9rE7ibG6NhY0lZx4glws7tiv+LuCR4iWARIESgqkPrwYfR3oYX2qO3ctiBP?=
 =?us-ascii?Q?nQV3job0STg3Ow6JZMFg9CnOIUk75BvgANQ/7AZUO8sOqC8nSvBT8JXU2oHg?=
 =?us-ascii?Q?CkdDzLHRl0o9ZqWmUuwiBcu2rvz4PtYM5H3wKjpJKwmpxF+6sd6ZWdnrbDHB?=
 =?us-ascii?Q?4N3rYQg0mTait+P4zdR5JjZY2E3AHnt+y68Vz7cS0LkWws4Glgr4oTyMiOed?=
 =?us-ascii?Q?MlF0Lc82ROs/AM3hZI9nxJjp28IvrdkgmpB8VdPYL59rERElWtDcGNYF9ZiJ?=
 =?us-ascii?Q?NXCh2EsbmlmwfPVM222I2S5K++tGtxdjIdH8SelxSMHz9+pRSgsE+cYB1by4?=
 =?us-ascii?Q?8emLhA+zvnY4HfOOi/dTm1d5EGZe4Fr9kQy15y5w8+aaDbspN10fmMvWYd1q?=
 =?us-ascii?Q?NNkRGKL6PDIGLV+T0peaJRoflTLhSNd24vCJYPxSRTZfyvhvTI0mla9aYMep?=
 =?us-ascii?Q?3KapzU1VMBERhWvotjxHHP8a5+6Ha56+iJej6HSdIG+XgINfV29UMREK8kEp?=
 =?us-ascii?Q?fhG57Fg/ZRSEuHQH2vEl9wb5g9myyVXR1wjGVf/rPaJoRWlJ9KeukQvV+wBl?=
 =?us-ascii?Q?y3P3ZdQWbS9nHIl8aHAkoYyXe0P2iTauoScfzCmb+faSiwkYUdqz+/9Vzgy9?=
 =?us-ascii?Q?Qd0yomWFesqqReoJPHJrHD5df5isq1pOSS7rQv+tvZTrhJvCM0fJKiqNo66v?=
 =?us-ascii?Q?YwLPj/INfq9QmefBADgLcn1GaDhdS5sjxprYndPeXfFiE4or2IYuetSTZHg4?=
 =?us-ascii?Q?NFn9TgWrmUU/0xc5Pskz8UFoBMB3fhhwDvOx90ZgO6FjDHtIJDExh/bc0b0P?=
 =?us-ascii?Q?TdsPSiPT92v/Vsrr8Am8/35y8WrxQc4kIUGpplVgNV/lMtjTHTBUetgVQ9/y?=
 =?us-ascii?Q?L9jdfb0A/Uxh9va2JfmRc98HeoilIIbk/9EHbMmlrXewwWVG5Zt6Iw9WQD/4?=
 =?us-ascii?Q?YmS1n5pT0w4EOvybqt5CEtNcbE7Blf71UhpDWlD6ugzybByHVveZ5JkkuueE?=
 =?us-ascii?Q?ikPTfZeuUVMBGkQPLTBLVCx5R2SXKvD2ImEXUGQ1peOo5rUtM6H9MbS4Pt/k?=
 =?us-ascii?Q?Ak7gGLNW0XRh8rOcSCoF9lTHisdzNndTZXGgzfDcIkwESOiq3g/YyMjCN1no?=
 =?us-ascii?Q?MuaFpofc8G+rJVk43HyvPqKmHWSYSPW9o1+yrfz0?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	fl+5/ZaRDkdb4w9TuD6AdeKedR7R8cdbRMy4Yraf0SeCS/47aYCjA+OyyYgq5ZS1q4iYscLJnC5rPsxITBGqV3kCHutc+REXkJwUKeMB+JMnwDiloDLH4Hgs0/nW/OGMcKPx6pp5Ct+91oWW92gD7DmxFSUheL9WGyvv8zH5Fika9aod8srYTBM42S0lz75FTikQKWTONZYClhFJfZwYqL6sfxskvwFmF0N2qOtw+g64xkFWxHs3Hdn2Ahreg9Ce71WY/u4dSPzucPXupCyL0xSOgjzB1V3WyVO5HfWoQRJH3XgL0Vw+OzeOCOWPF2VhlYAtaHj0qQdJMVc/5i76NwpfE3cmWkXH+TSy8e3rGnEkPMlNSU1KD/Toad9KFSoC6inlRPKjmF4b88rwdrIgyPGEjO4l9nL5XpjkhqYIbzSTeRy+BoFP5m7GT35WN13NzixYEp8LTM6mygmnNzhEDYQq1q0hZxD9XXybvNpvDV6GRCWlcKDNURV3zvOptxV8BT+ePMNBbJZcGOUZVS6wLZNh2K71MlwnUSxJMqbk5zBUV+088fgbr0F0ES8PQ2VM4pd1eJ+J3eYiA7fUvW9nb8WjzO3EHc8A04UOvK4kcVQ=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b6ae3e18-30d2-4eb4-8b5b-08dc4d09e6b9
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2024 20:26:50.1816
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0O+DMZCdzPEQ9082wjOBeRTNUucGML2n4kPnPKujVITHS53EBUT0q3GfsvCRlENu4JLAkPuUfPrPiH37LIC6AQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5039
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-25_19,2024-03-21_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0
 adultscore=0 mlxscore=0 phishscore=0 malwarescore=0 spamscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2403210000 definitions=main-2403250125
X-Proofpoint-ORIG-GUID: gJ03k5Sp79oHw3ulk6xOUPD03xxEY1oO
X-Proofpoint-GUID: gJ03k5Sp79oHw3ulk6xOUPD03xxEY1oO

* Helge Deller <deller@gmx.de> [240325 16:24]:
> On 3/25/24 19:53, Andrew Morton wrote:
> > On Mon, 25 Mar 2024 14:32:58 +0800 Yajun Deng <yajun.deng@linux.dev> wrote:
> > 
> > > There are two types of iterators mas and vmi in the current code. If the
> > > maple tree comes from the mm structure, we can use the vma iterator. Avoid
> > > using mas directly as possible.
> > > 
> > > Keep using mas for the mt_detach tree, since it doesn't come from the mm
> > > structure.
> > > 
> > > Remove as many uses of mas as possible, but we will still have a few that
> > > must be passed through in unmap_vmas() and free_pgtables().
> > > 
> > > Also introduce vma_iter_reset, vma_iter_{prev, next}_range_limit and
> > > vma_iter_area_{lowest, highest} helper functions for using the vma
> > > interator.
> > > 
> > 
> > I assume Liam's earlier request still applies?
> > 
> > : Helge,
> > :
> > : Yajun has changed code that affects parisc with this patch, which hasn't
> > : been tested.
> > : ...
> > : Can you make sure that the expand_upwards() still functions on parisc?
> 
> Oh, I didn't noticed that request earlier.
> Anyway, I now tested this patch on top of 6.9-rc1, and the kernel still
> boots up nicely on parisc and as such expand_upwards() seem to work as before.
> So, you may add:
> 
> Tested-by: Helge Deller <deller@gmx.de> # parisc

Thanks Helge!

Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>