Received-SPF: pass (google.com: domain of linux-kernel+bounces-117937-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 25 Mar 2024 21:31:47 +0100
From: Borislav Petkov <bp@alien8.de>
To: "Naik, Avadhut" <avadnaik@amd.com>
Cc: linux-trace-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
	tony.luck@intel.com, x86@kernel.org, linux-kernel@vger.kernel.org,
	yazen.ghannam@amd.com, Steven Rostedt <rostedt@goodmis.org>,
	Avadhut Naik <avadhut.naik@amd.com>
Subject: Re: [PATCH v3 0/2] Update mce_record tracepoint
Message-ID: <20240325203147.GIZgHfM6yqPbK2YLOl@fat_crate.local>
References: <20240126075800.1174583-1-avadhut.naik@amd.com>
 <20240208121013.1946ef7f@rorschach.local.home>
 <9e68a369-2667-4dd4-b715-ca1e13948a8f@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <9e68a369-2667-4dd4-b715-ca1e13948a8f@amd.com>

On Mon, Mar 25, 2024 at 03:12:14PM -0500, Naik, Avadhut wrote:
> Can this patchset be merged in? Or would you prefer me sending out
> another revision with Steven's "Reviewed-by:" tag?

First of all, please do not top-post.

Then, you were on Cc on the previous thread. Please summarize from it
and put in the commit message *why* it is good to have each field added.

And then, above the tracepoint, I'd like you to add a rule which
states what information can and should be added to the tracepoint. And
no, "just because" is not good enough. The previous thread has hints.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette