Received-SPF: pass (google.com: domain of linux-kernel+bounces-118251-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Peng Fan <peng.fan@nxp.com>
To: Thomas Gleixner <tglx@linutronix.de>, Jason Gunthorpe <jgg@ziepe.ca>,
	"Peng Fan (OSS)" <peng.fan@oss.nxp.com>
CC: Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, Joerg
 Roedel <joro@8bytes.org>, Marc Zyngier <maz@kernel.org>, Bixuan Cui
	<cuibixuan@huawei.com>, "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "iommu@lists.linux.dev"
	<iommu@lists.linux.dev>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 3/3] iommu/arm-smmu-v3: support suspend/resume
Thread-Topic: [PATCH 3/3] iommu/arm-smmu-v3: support suspend/resume
Thread-Index: AQHafeW5Y57Zt6YgTUODhc56ZNJBpbFIeocAgAA9iYCAAIRpIA==
Date: Tue, 26 Mar 2024 01:26:01 +0000
Message-ID:
 <DU0PR04MB941779A13906E00ACAC987AA88352@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20240324-smmu-v3-v1-0-11bc96e156a5@nxp.com>
 <20240324-smmu-v3-v1-3-11bc96e156a5@nxp.com> <20240325134848.GA8419@ziepe.ca>
 <87bk72fcf4.ffs@tglx>
In-Reply-To: <87bk72fcf4.ffs@tglx>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?+2r99nOaAtZXfoPJw3+sJ0P+P3x4t351O6E5nv3ewoE70OAQKjWexG0q10/A?=
 =?us-ascii?Q?4fvUlkQVUUc6uDO9H/tCNEw7aCe3TDVDM6MYIIVozrENIaJ5sqRW17sIoG36?=
 =?us-ascii?Q?9AKzxa6TpAk+r9hxPBCxe6ipBI5wOCpFPp3KdHKh8+9VmxcyuGvVAGSf2wH7?=
 =?us-ascii?Q?lwq39EDW6GjZPKXZzi92AP8wSZqz69cg/oSSO6GqH1OEpmSu1w/URpsLvxWo?=
 =?us-ascii?Q?BNwrsmhplmHHMA11haqE88FXLHa9zzRJ27TbdLE7RTz3XPEhyFMbc8Fg/8LV?=
 =?us-ascii?Q?fnB9J/M1d4pxNxRYkZvKplOhO0pEEq57orHRy6wd5ZwOkXtjDKONHsj1Q62b?=
 =?us-ascii?Q?fSu2J2DgMEf9b3zxWum47P3KxRlJax9QniNSumDpO0k5qdL7RRQirnUhZOMl?=
 =?us-ascii?Q?BWYwZhHflV+KK5gdFCt4XpcNaHpzKDrdeEr36P13tzJMTnyM7yaZZ6Qxw6Ld?=
 =?us-ascii?Q?L0ihcYEsNphp6VVVd16Wbt4fGzh3JqnEWyI7VrvQIAc/HQUoeytmgQGSmehM?=
 =?us-ascii?Q?SsQ2Ys/dgIRcKIFfMQqqD+jVjf99kvwYmR3KW3IWknmk0+xHzH/FAc2Laorh?=
 =?us-ascii?Q?EWcj7ZBcWezpsy1m3pXV1Wo1+QG1aV1DTN+HpEmS2qJay/wpRwadSzv/U536?=
 =?us-ascii?Q?pGGhqiEgpOjeoJ4u0MS7kzAF/g64x1L4vaDedxnIy324wPMeq01eiMHwd6TO?=
 =?us-ascii?Q?6zri2b/1U9jJliEOu4PHfC/eegic7LapBnaSM69eo2RNwSylsgvtZ41+NKdW?=
 =?us-ascii?Q?g4nxWUmIyMJGAY00hOSTU8decvnZyOpQwLhz7kFNE9U6wpVV1G3OkfyQDeMs?=
 =?us-ascii?Q?N6b7UH+IUUslNE4TpzHQUdQ1cOuTS/7SYmPdtIOayYTAAR1qwBrObfzwS9ZF?=
 =?us-ascii?Q?gA1oKHvaGH62NkhwLUwDBRmw2kPsIZtBZSYmcpjA0k2h2LwWr4sh7JDi15/a?=
 =?us-ascii?Q?dSxCeM3qjF5q4ypnJ/sJ78oVv8to01flMDit/2658bpiIIP0P+F1VJ2Ap+WB?=
 =?us-ascii?Q?qTpFbGqCewezmjLmw8RCNPlxYsVb+aY83hQs6Vm8tLGamWtMnUuPvqdagwSG?=
 =?us-ascii?Q?uyfu3tna2mGoPCZX/H/uInmK9Dr5bsTW8KSnUo6FlQDuMCTtbL0wUKMMcDqm?=
 =?us-ascii?Q?43PjmrlTpxE4M1+YR2YBodlBxO4vscozcVdobKpal/yl5wTxPdxJu0iVW1th?=
 =?us-ascii?Q?KaXejnJjXWltHpoJleQ6HWzM6jL7TfrOqwTCzb40izWZbDHUxSmdNlPsxYl4?=
 =?us-ascii?Q?lWJ9xAfpaIEvIvvJ+kz46XGvZw8A3JKFQok9zQ8zqZRfh5tNVXOMTYLOPI4f?=
 =?us-ascii?Q?th6l3ZXoKMSmL7bgOtErDRjUwOAnaPWtFkf9PVWuxMvG7ZCSRF8Nb3Y11Cc3?=
 =?us-ascii?Q?NLKJi/xVvZQm0qbSS3LMTDudAwSR6I4Zj7q4/wYwh/5y/3T2xq6rJ0jxiVg7?=
 =?us-ascii?Q?lw+3doWMSHT60EBZLPd6DiLFtPoMyWhNtitHuKJFKlnSGyZhGpxcenExT92v?=
 =?us-ascii?Q?lWfiVURu1i52LyXNr7RDDCMDVV1lHibxaUxpUNY14VOztJTIpdcwAPJyn31E?=
 =?us-ascii?Q?kEaNEWUxRnvUxHKlokc=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2b32f518-a8c2-478a-50a3-08dc4d33b2d0
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Mar 2024 01:26:01.7926
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PvsCvVLjO5l8xh+yHBtkrjvSDDFrZj5epW2WCis+SbdNQDKua4xBpaexiLlyp/hJiU032eycCQoCcsDA3lghvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9867

> Subject: Re: [PATCH 3/3] iommu/arm-smmu-v3: support suspend/resume
>=20
> On Mon, Mar 25 2024 at 10:48, Jason Gunthorpe wrote:
> > On Sun, Mar 24, 2024 at 08:29:00PM +0800, Peng Fan (OSS) wrote:
> >> +static void arm_smmu_resume_unique_irqs(struct arm_smmu_device
> >> +*smmu) {
> >> +	struct device *dev =3D smmu->dev;
> >> +	struct msi_desc *desc;
> >> +	struct msi_msg msg;
> >> +
> >> +	if (!dev->msi.domain)
> >> +		return;
> >> +
> >> +	desc =3D irq_get_msi_desc(smmu->evtq.q.irq);
> >> +	if (desc) {
> >> +		get_cached_msi_msg(smmu->evtq.q.irq, &msg);
> >> +		arm_smmu_write_msi_msg(desc, &msg);
> >> +	}
> >> +
> >> +	desc =3D irq_get_msi_desc(smmu->gerr_irq);
> >> +	if (desc) {
> >> +		get_cached_msi_msg(smmu->gerr_irq, &msg);
> >> +		arm_smmu_write_msi_msg(desc, &msg);
> >> +	}
> >> +
> >> +	if (smmu->features & ARM_SMMU_FEAT_PRI) {
> >> +		desc =3D irq_get_msi_desc(smmu->priq.q.irq);
> >> +		if (desc) {
> >> +			get_cached_msi_msg(smmu->priq.q.irq, &msg);
> >> +			arm_smmu_write_msi_msg(desc, &msg);
> >> +		}
> >> +	}
> >> +}
> >
> > I wonder if this should be done instead by converting the driver away
> > from platform MSI to the new MSI mechanism?
>=20
> There is work in progress for that. Should come around in the next weeks.

Then I need to wait for your patches, and rebase this patchset, or could
the non-msi part be reviewed first?

Thanks,
Peng.