Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp3061978lqp; Mon, 25 Mar 2024 19:29:07 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVtUoGC3HMm5/GyPDZVzrRwKmFnQM+Q2HM20bJ9XiK3yuimdU5+O+mpNuioBhhK9qxmSvfx7cc8+4v3Pl2LWj2RbPe4Cdy8s8Qew97wKA== X-Google-Smtp-Source: AGHT+IG/BYaKeH1csD9YYB1HBkLwagWHBVKZrrTR7Xyt+7aMU+onO2fZIQdCkICrk3t518sIW3Wa X-Received: by 2002:a05:6214:5282:b0:696:3cdb:13f5 with SMTP id kj2-20020a056214528200b006963cdb13f5mr10002440qvb.20.1711420147421; Mon, 25 Mar 2024 19:29:07 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711420147; cv=pass; d=google.com; s=arc-20160816; b=pGYuNWrlhde6vIItxEcgPDkMUmmZkvWYbas+6Yp5+jXCuicG+YvsQ/NxFX1L+kSKaS SzM4V6IaTPvGZLxe7D2rSnj7lz+Lx3IREBwUyGRQfggFRsg37LW9Z8mnVedMhGtj3ssx Txm7nve6eaLJmy4KDuxdFNIHABpbhnl9hA8a/mqsP+fo9zoEGjCnkgcuCfXxl9MZxBL/ pLReuSr4p0Rpx5qhlLYh1kIEHkBr+SyKjnk8qWjCc5Uq/l8Yj2Yp3lbP1Fu5XlSWHe6Q fP3TKnyuZuhWK/OH4w15UW7V+LeDBMVyOKN5HKasV3hsFdvFSRvr4X7s+nfWI/0mAzOe uZ7w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=+lc7Uh/98jCa43giZwdwHgKxZpNbzzVYKHyLFtaqIZY=; fh=L3lZPtJSWBMHSqm3Xw1UNPrMhL/oDMhx2ByB8NCVFGs=; b=SMQe5WkyzTs6juYsPeYkncDvSvQa5cRKxujTO4zU+3+N3gFIVQVJ9aG2f6tL3mxDqp hqmgVbZBfzcBGyb4cS3DVUQO0mTvg1bNBlMVPGLL/UfPi3u0V+OE+RMjJhLWcI3rdUcC heJZFKUcMARtwArzUfsXsxgtaYi7xr8/oHMthpEHlpM05QQOuAgTB3y0KS/tMbm9KnJM u14IGkMkCNOhNUXpm6KdtrQPbZufewpNvVSk9Jl4mGv66IppBxSDPbk2SFyDK5BXxsQ4 N7e08h5J4wn5S2ndAkhIpv6mKCPrss7+/46D7ELqHe9yJbdRf7F2CuSIXFg+9Tsd3nYI vZAw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=udTdxOGA; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-118298-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-118298-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id jr11-20020a0562142a8b00b0068f53323cc9si9251658qvb.289.2024.03.25.19.29.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 19:29:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-118298-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=udTdxOGA; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-118298-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-118298-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 159171C27CFC for ; Tue, 26 Mar 2024 02:29:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1931082D74; Tue, 26 Mar 2024 02:28:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="udTdxOGA" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39B654E1A8; Tue, 26 Mar 2024 02:28:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711420137; cv=none; b=MMakkP2L5rxoXtyh2YNjdC2RCavSl0n9+vEW0mRx1hXBaYEG6TO6JcDLGI5b1Z0/f745FPYphLBUDfP66ag4+MYNKrHHnotGlG+7BH8Ggd+sZkmHOKDFh4szrLQYXVKubNPuMRsJtp+AXBNsEOqiPjTlKCdAAAMxv44bgiIg8j8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711420137; c=relaxed/simple; bh=Ktz9UbpIvvzi2R8AiNv+RRMOy4vq7/ZgvePg/K1Kn8s=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=s1d0S0ScxnUdDCjpUlzx+FwF+CdAm2koJxmI7/p1c86tpV+mY2kba6SucD8Oj8cfcri+ba4l8gfrEdpYtDISOuin2nJ6ucoZWlP3pLFNCLjRePu6Dj4/Suv6nOwbBHBRhHvMA0JiufUCnJLVDyT306feyUKso90T0SXzPu2x61c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=udTdxOGA; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60579C433C7; Tue, 26 Mar 2024 02:28:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711420137; bh=Ktz9UbpIvvzi2R8AiNv+RRMOy4vq7/ZgvePg/K1Kn8s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=udTdxOGAJBrg51gfL1uwJ93+ngK3GMR3Fm0SHsW8NFMKc9VeZ8WX9rURwWXQQ1s0e X3QpkfyFYRd5auxgAHs/WDPfEgWkK7wSdwbRSK6qHf0/CGPL8KpZO9/fEKWPQ2XdIY jnlKG4Dht0MQ7vuTO/6bx6UbifyWIgKxFgzP8LfsnjvuliAD1b+X6o3pf/hbIgdu7n y+/cszBAu+5pTmwVTHjeiB8jAJDHwN24rlH/UglH/enj2pq0nZaEqnDaDJPPBOzfQq mZV1xvO24t1nWKFsmZujrP5oEVBubPo6ks4hFNQzy5B7k/2WcFzNu7DrmpBWk+Gcdc DMB3pyfzrPbRw== Date: Mon, 25 Mar 2024 19:28:55 -0700 From: Jakub Kicinski To: Balazs Scheidler Cc: kerneljasonxing@gmail.com, kuniyu@amazon.com, netdev@vger.kernel.org, Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Willem de Bruijn , "David S. Miller" , David Ahern , Eric Dumazet , Paolo Abeni , Balazs Scheidler , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3 2/2] net: udp: add IP/port data to the tracepoint udp/udp_fail_queue_rcv_skb Message-ID: <20240325192855.1fb3c331@kernel.org> In-Reply-To: <34a9c221a6d644f18c826a1beddba58af6b7a64c.1711361723.git.balazs.scheidler@axoflow.com> References: <34a9c221a6d644f18c826a1beddba58af6b7a64c.1711361723.git.balazs.scheidler@axoflow.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 25 Mar 2024 11:29:18 +0100 Balazs Scheidler wrote: > + memset(__entry->saddr, 0, sizeof(struct sockaddr_in6)); > + memset(__entry->daddr, 0, sizeof(struct sockaddr_in6)); Indent with tabs please, checkpatch says: ERROR: code indent should use tabs where possible #59: FILE: include/trace/events/udp.h:38: + memset(__entry->saddr, 0, sizeof(struct sockaddr_in6));$ WARNING: please, no spaces at the start of a line #59: FILE: include/trace/events/udp.h:38: + memset(__entry->saddr, 0, sizeof(struct sockaddr_in6));$ ERROR: code indent should use tabs where possible #60: FILE: include/trace/events/udp.h:39: + memset(__entry->daddr, 0, sizeof(struct sockaddr_in6));$ WARNING: please, no spaces at the start of a line #60: FILE: include/trace/events/udp.h:39: + memset(__entry->daddr, 0, sizeof(struct sockaddr_in6));$ -- pw-bot: cr