Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp3063618lqp; Mon, 25 Mar 2024 19:34:07 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWiuUihBJ6XMZlfgddc/jYMa1VjHtI5DrwJzhVoM1cvIr7PkpKcRDtb25YipEzJ/LvXiR0r56OmC7TQ0rBYGKn4eKYlf7QSeTH4jcCmPg== X-Google-Smtp-Source: AGHT+IECvMSwg9yC1FPW/2fsLx69SYunJ7LkkXOAKUZHpSl9BO7rvKi5Y09RHx7b70n7wwINqhhh X-Received: by 2002:a05:6a20:244d:b0:1a3:c8bf:737b with SMTP id t13-20020a056a20244d00b001a3c8bf737bmr4065166pzc.46.1711420447059; Mon, 25 Mar 2024 19:34:07 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711420447; cv=pass; d=google.com; s=arc-20160816; b=RCEhocXDZApI2baiZ9bXq/3M7RpN8mGK3xLpsByfe0OPNkrbDVfNygjvkr6IBIqyBA a48a3J1EF05GOOkyN0EkBWxKs7Tq9AF99FINBkH9gX8e2us3KWNtw0xTbDuPBgLxkvYw vZliaOC1JOWLdptkXDx+aE5kDvcu4E8UC9rmL8RNgOr6CfoGYOm2doiVimXtCuonAWGG qBrHq1uuxb7bRi3n9vK+A2Mx4/NHK8y4QyYOmGRzGnX1nbZPSW+K/Cj0GvjvtCnj3PCo Nk0HCJLGyPsuUGWElIhrSAeZVFGT7jIl12D4s3KKzZNErPGcZ/tSYxtNu6cMWjX3pj+t ed9Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=8GAfDA1bHzqCBZqy+GmCAakxad59mlKRyGEkqtPqyeI=; fh=qXHSDid8/2kOPiwVs+uVL1Gso2rMiGx0QDFvT6Qt4vY=; b=M7ITT3/EP7JRV8w6KP+sdh5EIVV4Gn4TmwFn5/okUMm0To+/oRNIhQxLV+mfc5mKKl XzacIlp/ZDyLME3ceZ4LmAlXhfKeDTEkNI6zps+FJTtiQDq0r2fGWBo1pFvzW1eWJ5Jo 6HjkzdgUBNMSW4AaGyp5TjEOIucSwGNe6NpkMcr2HbH3YnnMX1innrTcFEjKMV75NPYh EKOWDDeFuww9omjJx4njtvRioZnlxY6RBiWVTi762D0Lyw6ogwF7XxunD4s+MWipxaNp JDHRwR62m6tG9QXATShM6Ai8up/2reCrhInBKoBvlhuWyBH6H4F2M2CX8l35fueP6a/n 1MkA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Nr4BgcbT; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-118302-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-118302-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id i11-20020a17090332cb00b001e03b2f7ab3si6444859plr.446.2024.03.25.19.34.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 19:34:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-118302-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Nr4BgcbT; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-118302-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-118302-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 47417B22CFC for ; Tue, 26 Mar 2024 02:33:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DB99412839B; Tue, 26 Mar 2024 02:33:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Nr4BgcbT" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00A5D1272DC; Tue, 26 Mar 2024 02:33:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711420421; cv=none; b=fAG+oHgScDenvqYC79RGLZ33s3KUp58x4MNnt79vsff/BFGLTYfST/biJKdGLfPnm4xjZHLix/37fesMhdJMxuf8AcdBH9iE1oiZ/eoGu3ZB2Rmk+jdHKdDQhFRBLB2vgNjIolcbJM2iLaNMGH0XLMp48DFN+ZuRke8L9K89HKo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711420421; c=relaxed/simple; bh=PWWez+GCtzHxL+Q3cBOsyLC3Pjq/o440jxyRuUA0HBE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=meXvpgOb3C1jIns9U7xkb2xD6XbB6dv0OQae5WEZTMfnqE/riXFyyBrSbwDNupuGz6xbp1JNxJp+o6KpVs0dsgQj21ilypNunBICnRYemJh88+zAvxaktnAThoqaMs3lPn3kp3SrMpd1Qq1/w1Jp0UmiO2N75nIgRNtMwdM9XuY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Nr4BgcbT; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F1C2C433F1; Tue, 26 Mar 2024 02:33:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711420420; bh=PWWez+GCtzHxL+Q3cBOsyLC3Pjq/o440jxyRuUA0HBE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Nr4BgcbTvRaBmyTyiDaqh0FqlHuYfefFC+IXxVFq/ApLTk1sVLb0xjv7r92kJ1iqV 2ZYyhky/tPHOmOjpy7qvb4YoufvMY14ilBjZ+3zTbAzbh7GAIN5cEmXgC+xAfJ8e6E qD1MN4pmY5qylBsJ3UNrBubrI6A1PPhYyb2wORcke8wmPAyeHrrkq8FfcH/LENJqzn ZVoC1igpWA10v1Mn7ViEqvNT9d107JB5gFcpeVsNJBX6dnjQRxkYdoZUnqM+1P3zu0 XXLP8GvSOwQS9KyjaLMkf8Smbbqf0jWPUn3YrHsIL9q4u1yAwqGxKBKJ9rspU9iLJX 8+1/BFu4yearg== Date: Mon, 25 Mar 2024 19:33:38 -0700 From: Jakub Kicinski To: Richard Gobert Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, willemdebruijn.kernel@gmail.com, dsahern@kernel.org, xeb@mail.ru, shuah@kernel.org, idosch@nvidia.com, amcohen@nvidia.com, petrm@nvidia.com, jbenc@redhat.com, bpoirier@nvidia.com, b.galvani@gmail.com, liujian56@huawei.com, horms@kernel.org, linyunsheng@huawei.com, therbert@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH net-next v4 4/4] net: gro: move L3 flush checks to tcp_gro_receive Message-ID: <20240325193338.565a4e45@kernel.org> In-Reply-To: <20240325182543.87683-5-richardbgobert@gmail.com> References: <20240325182543.87683-1-richardbgobert@gmail.com> <20240325182543.87683-5-richardbgobert@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 25 Mar 2024 19:25:43 +0100 Richard Gobert wrote: > + const u32 id = ntohl(*(__be32 *)&iph->id); > + const u32 id2 = ntohl(*(__be32 *)&iph2->id); > + const int flush_id = ntohs(id >> 16) - ntohs(id2 >> 16); The endian conversions don't match types here. sparse is unhappy. If id is in host endian shouldn't it be htons(id >> 16) ? Also if you cast to a bitwise type you need __force -- pw-bot: cr