Received-SPF: pass (google.com: domain of linux-kernel+bounces-118363-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 26 Mar 2024 10:23:03 +0530
From: Dhruva Gole <d-gole@ti.com>
To: Bjorn Helgaas <helgaas@kernel.org>
CC: "Rafael J . Wysocki" <rafael@kernel.org>, Len Brown <len.brown@intel.com>,
        Pavel Machek <pavel@ucw.cz>, <linux-pm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] Documentation: PM: Update platform_pci_wakeup_init()
 reference
Message-ID: <20240326045303.qy4przp73jcoutvh@dhruva>
References: <20240325220952.1453477-1-helgaas@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240325220952.1453477-1-helgaas@kernel.org>

Hi,

On Mar 25, 2024 at 17:09:53 -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> platform_pci_wakeup_init() was removed by d2e5f0c16ad6 ("ACPI / PCI: Rework
> the setup and cleanup of device wakeup") but was still mentioned in the
> documentation.
> 
> Update the doc to refer to pci_acpi_setup(), which does the equivalent
> work.
> 

Thanks! Documentation does go unnoticed sometimes.

> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> 
> pci_acpi_setup() is a firmware-specific wart in this otherwise generic
> paragraph, so maybe there's some better way to express this?
> 
>  Documentation/power/pci.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/power/pci.rst b/Documentation/power/pci.rst
> index 12070320307e..e2c1fb8a569a 100644
> --- a/Documentation/power/pci.rst
> +++ b/Documentation/power/pci.rst
> @@ -333,7 +333,7 @@ struct pci_dev.
>  The PCI subsystem's first task related to device power management is to
>  prepare the device for power management and initialize the fields of struct
>  pci_dev used for this purpose.  This happens in two functions defined in
> -drivers/pci/pci.c, pci_pm_init() and platform_pci_wakeup_init().
> +drivers/pci/, pci_pm_init() and pci_acpi_setup().

Reviewed-by: Dhruva Gole <d-gole@ti.com>


-- 
Best regards,
Dhruva