Received-SPF: pass (google.com: domain of linux-kernel+bounces-118376-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <0e719692-a166-1f56-4226-e71f7503aa94@nfschina.com>
Date: Tue, 26 Mar 2024 13:41:24 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] drm/amdkfd: return negative error code in svm_ioctl()
Content-Language: en-US
To: Philip Yang <yangp@amd.com>, Felix.Kuehling@amd.com,
 alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com,
 airlied@gmail.com, daniel@ffwll.ch
Cc: Philip.Yang@amd.com, alex.sierra@amd.com, amd-gfx@lists.freedesktop.org,
 dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
 kernel-janitors@vger.kernel.org
From: Su Hui <suhui@nfschina.com>
In-Reply-To: <b4af9fda-8685-d486-95aa-ca46c11a2cc5@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 2024/3/25 22:09, Philip Yang wrote:
>
>
> On 2024-03-25 02:31, Su Hui wrote:
>
> Good catch, ioctl should return -errno. I will apply it to drm-next.
>
> Reviewed-by: Philip Yang<philip.yang@amd.com>
>
>> ---
>> Ps: When I try to compile this file, there is a error :
>> drivers/gpu/drm/amd/amdkfd/kfd_migrate.c:28:10: fatal error: amdgpu_sync.h:
>> No such file or directory.
>>
>> Maybe there are some steps I missed or this place need to be corrected?
>
> Don't know how you compile the driver, amdgpu_sync.h is located under 
> amdgpu folder, amdkfd/Makefile is included from amdgpu/Makefile, which 
> set ccflag-y -I correctly.
>
Got it,  I should using 'make 
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_migrate.o'
rather than 'make drivers/gpu/drm/amd/amdkfd/kfd_migrate.o'.

Thanks a lot!

Regards,
Su Hui