Received-SPF: pass (google.com: domain of linux-kernel+bounces-118455-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <cover.1711361723.git.balazs.scheidler@axoflow.com>
 <34a9c221a6d644f18c826a1beddba58af6b7a64c.1711361723.git.balazs.scheidler@axoflow.com>
 <20240325192855.1fb3c331@kernel.org>
In-Reply-To: <20240325192855.1fb3c331@kernel.org>
From: Jason Xing <kerneljasonxing@gmail.com>
Date: Tue, 26 Mar 2024 15:25:21 +0800
Message-ID: <CAL+tcoDXHSMmqUeuMSSObco=_2Vr5tDSRFzXUSsAneOP314jqg@mail.gmail.com>
Subject: Re: [PATCH net-next v3 2/2] net: udp: add IP/port data to the
 tracepoint udp/udp_fail_queue_rcv_skb
To: Jakub Kicinski <kuba@kernel.org>
Cc: Balazs Scheidler <bazsi77@gmail.com>, kuniyu@amazon.com, netdev@vger.kernel.org, 
	Steven Rostedt <rostedt@goodmis.org>, Masami Hiramatsu <mhiramat@kernel.org>, 
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, 
	Willem de Bruijn <willemdebruijn.kernel@gmail.com>, "David S. Miller" <davem@davemloft.net>, 
	David Ahern <dsahern@kernel.org>, Eric Dumazet <edumazet@google.com>, 
	Paolo Abeni <pabeni@redhat.com>, Balazs Scheidler <balazs.scheidler@axoflow.com>, 
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 26, 2024 at 10:28=E2=80=AFAM Jakub Kicinski <kuba@kernel.org> w=
rote:
>
> On Mon, 25 Mar 2024 11:29:18 +0100 Balazs Scheidler wrote:
> > +                memset(__entry->saddr, 0, sizeof(struct sockaddr_in6))=
;
> > +                memset(__entry->daddr, 0, sizeof(struct sockaddr_in6))=
;
>
> Indent with tabs please, checkpatch says:
>
> ERROR: code indent should use tabs where possible
> #59: FILE: include/trace/events/udp.h:38:
> +                memset(__entry->saddr, 0, sizeof(struct sockaddr_in6));$
>
> WARNING: please, no spaces at the start of a line
> #59: FILE: include/trace/events/udp.h:38:
> +                memset(__entry->saddr, 0, sizeof(struct sockaddr_in6));$
>
> ERROR: code indent should use tabs where possible
> #60: FILE: include/trace/events/udp.h:39:
> +                memset(__entry->daddr, 0, sizeof(struct sockaddr_in6));$
>
> WARNING: please, no spaces at the start of a line
> #60: FILE: include/trace/events/udp.h:39:
> +                memset(__entry->daddr, 0, sizeof(struct sockaddr_in6));$

More than this, it would be better to put "From Balazs Scheidler
<balazs.scheidler@axoflow.com>" in the first line of each patch to
eliminate the mismatched email address warning.

Link (Jakub referred to):
https://patchwork.kernel.org/project/netdevbpf/patch/34a9c221a6d644f18c826a=
1beddba58af6b7a64c.1711361723.git.balazs.scheidler@axoflow.com/
Detailed info: https://netdev.bots.linux.dev/static/nipa/837832/13601927/ch=
eckpatch/stdout

> --
> pw-bot: cr