Received-SPF: pass (google.com: domain of linux-kernel+bounces-118457-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 26 Mar 2024 08:27:47 +0100
From: Andi Shyti <andi.shyti@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/64] i2c: au1550: reword according to newest
 specification
Message-ID: <r32ljnxrlpfl4ksqprkteu5jg3zlbfm3qxkxgao7ziajnhqwvr@tqfvqv2ljw3x>
References: <20240322132619.6389-1-wsa+renesas@sang-engineering.com>
 <20240322132619.6389-7-wsa+renesas@sang-engineering.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240322132619.6389-7-wsa+renesas@sang-engineering.com>

Hi Wolfram,

On Fri, Mar 22, 2024 at 02:24:59PM +0100, Wolfram Sang wrote:
> Match the wording of this driver wrt. the newest I2C v7, SMBus 3.2, I3C
> specifications and replace "master/slave" with more appropriate terms.
> They are also more specific because we distinguish now between a remote
> entity ("client") and a local one ("target").

..

> -static int wait_master_done(struct i2c_au1550_data *adap)
> +static int wait_host_done(struct i2c_au1550_data *adap)
>  {
>  	int i;
>  
> -	/* Wait for Master Done. */
> +	/* Wait for Host Done. */

here, rather than Master/Controller, the change is Master/Host,
which is different from what is stated in the commit log.

..

> @@ -246,7 +246,7 @@ static u32 au1550_func(struct i2c_adapter *adap)
>  }
>  
>  static const struct i2c_algorithm au1550_algo = {
> -	.master_xfer	= au1550_xfer,
> +	.xfer	= au1550_xfer,
>  	.functionality	= au1550_func,

Here there was some alignment which now is gone.

Andi