Received-SPF: pass (google.com: domain of linux-kernel+bounces-118477-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <cover.1711361723.git.balazs.scheidler@axoflow.com> <394f9d55197681e910d104dbd35e62fb4098712b.1711361723.git.balazs.scheidler@axoflow.com>
In-Reply-To: <394f9d55197681e910d104dbd35e62fb4098712b.1711361723.git.balazs.scheidler@axoflow.com>
From: Jason Xing <kerneljasonxing@gmail.com>
Date: Tue, 26 Mar 2024 15:39:59 +0800
Message-ID: <CAL+tcoAy1VU6-pMOsqSCU8EUkyo5q9SEkM=GeDWjW9Mw6os=RQ@mail.gmail.com>
Subject: Re: [PATCH net-next v3 1/2] net: port TP_STORE_ADDR_PORTS_SKB macro
 to be tcp/udp independent
To: Balazs Scheidler <bazsi77@gmail.com>
Cc: kuniyu@amazon.com, netdev@vger.kernel.org, 
	Steven Rostedt <rostedt@goodmis.org>, Masami Hiramatsu <mhiramat@kernel.org>, 
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, Eric Dumazet <edumazet@google.com>, 
	Balazs Scheidler <balazs.scheidler@axoflow.com>, linux-kernel@vger.kernel.org, 
	linux-trace-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 25, 2024 at 6:29=E2=80=AFPM Balazs Scheidler <bazsi77@gmail.com=
> wrote:
>
> This patch moves TP_STORE_ADDR_PORTS_SKB() to a common header and removes
> the TCP specific implementation details.
>
> Previously the macro assumed the skb passed as an argument is a
> TCP packet, the implementation now uses an argument to the L4 header and
> uses that to extract the source/destination ports, which happen
> to be named the same in "struct tcphdr" and "struct udphdr"
>
> Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>

The patch itself looks good to me, feel free to add:
Reviewed-by: Jason Xing <kerneljasonxing@gmail.com>